1. 24 Aug, 2012 1 commit
    • Arthur O'Dwyer's avatar
      The "count_" out-parameter is doubled instead of unchanged. · a48751b3
      Arthur O'Dwyer authored
      Static analysis says:
      src\zmq.cpp(489): error V220: Suspicious sequence of types castings: memsize -> 32-bit integer -> memsize. The value being casted: '* count_'.
      src\zmq.cpp(510): error V127: An overflow of the 32-bit 'nread' variable is possible inside a long cycle which utilizes a memsize-type loop counter.
      
      I've silenced the warning on line 489 and ignored the other.
      But also, it looks to me like there's a serious bug here: The
      out-parameter "count_" is never set to zero before we start
      incrementing it. So its final value will always be between
      1 and 2 times its initial value. The fix seems obvious.
      a48751b3
  2. 23 Aug, 2012 4 commits
    • Ian Barber's avatar
      Merge pull request #410 from Quuxplusone/LIBZMQ-414 · d588dbf2
      Ian Barber authored
      [LIBZMQ-414] Fix an error in the inline assembly for Thumb2.
      d588dbf2
    • Ian Barber's avatar
      Merge pull request #411 from Quuxplusone/fix-test_monitor-bug · 033e311d
      Ian Barber authored
      Fix a bug reported on the mailing list.
      033e311d
    • Arthur O'Dwyer's avatar
      Fix a bug reported on the mailing list. · f718d2be
      Arthur O'Dwyer authored
      Both memcmp and strcmp return zero on equal, nonzero on nonequal;
      so all of these tests were backwards.
      
      The original committer fixed the failure by comparing 22 bytes instead
      of the correct 21, so that the assertions would trigger only if the
      22nd byte happened to match exactly --- which was rare.
      
      The correct fix is to compare the right number of bytes with the
      right sense.  (I think all of the ".addr" fields are null-terminated,
      in which case it's more appropriate to use strcmp throughout.)
      f718d2be
    • Arthur O'Dwyer's avatar
      Fix an error in the inline assembly for Thumb2. · 28c9255d
      Arthur O'Dwyer authored
      Notice that ZeroMQ has never been compiled for Thumb2 before,
      and I personally don't make any guarantees that it will actually
      behave correctly once compiled. But after this patch, it is at
      least *possible* to compile it for Thumb2.
      
      (Thumb2 is the target for most iOS devices.)
      28c9255d
  3. 12 Aug, 2012 1 commit
  4. 11 Aug, 2012 1 commit
  5. 05 Aug, 2012 2 commits
  6. 04 Aug, 2012 3 commits
  7. 31 Jul, 2012 2 commits
    • Ian Barber's avatar
      Merge pull request #406 from hurtonm/master · 1f229547
      Ian Barber authored
      Fix issue #406
      1f229547
    • Martin Hurton's avatar
      Fix issue #406 · 9fab9937
      Martin Hurton authored
      When a peer reconnects, the router socket receives an identity
      message containing this peer id. When this happens, the current
      implementation crashes.
      
      This patch makes a router socket to silently ignore all identity
      messages coming from reconnected peers.
      9fab9937
  8. 29 Jul, 2012 1 commit
  9. 28 Jul, 2012 1 commit
  10. 26 Jul, 2012 3 commits
  11. 24 Jul, 2012 1 commit
  12. 18 Jul, 2012 1 commit
  13. 17 Jul, 2012 1 commit
  14. 13 Jul, 2012 2 commits
  15. 11 Jul, 2012 4 commits
  16. 06 Jul, 2012 8 commits
  17. 04 Jul, 2012 3 commits
  18. 03 Jul, 2012 1 commit