1. 27 May, 2018 1 commit
  2. 26 May, 2018 1 commit
  3. 22 May, 2018 1 commit
  4. 02 Feb, 2018 1 commit
  5. 08 Aug, 2017 1 commit
    • Simon Giesecke's avatar
      Problem: ZAP status codes != 200 do not result in an appropriate monitor event (#2665) · a6cef4ef
      Simon Giesecke authored
      * Problem: missing test for status code 300, inadequate assertion for status code 500
      
      Solution: add test, change assertion (currently test fails)
      
      * Problem: gcc compiler error deprecated conversion from string constant
      
      Solution: declare variable as const
      
      * Problem: in case of ZAP handler returning a status code other than 200, no appropriate event is emitted
      
      Solution: immediately emit event after receiving reply from ZAP handler
      
      * Problem: endpoint address is not included in zap-reply monitor event
      
      Solution: added functions to retrieve endpoint address in zmq::i_engine and zmq::session_base_t
      removed unused code block in zmq::stream_engine_t::next_handshake_command
      
      * Problem: wrong formatting
      
      Solution: fix formatting
      
      * Problem: test fails because of EPIPE
      
      Solution: add EPIPE/ECONNRESET/ECONNAGAIN handling for more test cases
      a6cef4ef
  6. 28 Jan, 2016 2 commits
  7. 02 Jun, 2015 1 commit
  8. 22 Jan, 2015 1 commit
  9. 03 Dec, 2014 1 commit
  10. 11 Sep, 2014 1 commit
  11. 17 May, 2014 1 commit
  12. 12 Mar, 2014 1 commit
  13. 02 Jan, 2014 1 commit
  14. 03 Dec, 2013 1 commit
  15. 06 Jun, 2013 3 commits
  16. 11 Apr, 2013 1 commit
  17. 12 Mar, 2013 1 commit
    • Pieter Hintjens's avatar
      Removed corporate advertisements from source file headers · f0f16505
      Pieter Hintjens authored
      Copyrights had become ads for Sustrik's corporate sponsors, going against the original
      agreement to share copyrights with the community (that agreement was: one line stating
      iMatix copyright + one reference to AUTHORS file). The proliferation of corporate ads
      is also unfair to the many individual authors. I've removed ALL corporate title from
      the source files so the copyright statements can now be centralized in AUTHORS and
      source files can be properly updated on an annual basis.
      f0f16505
  18. 21 Sep, 2012 1 commit
  19. 02 Sep, 2012 1 commit
  20. 24 Aug, 2012 1 commit
    • Arthur O'Dwyer's avatar
      Fix monitor_event() to work at all. · 7fadd708
      Arthur O'Dwyer authored
      There are three versions of monitor_event(), all taking
      variadic arguments. The original code just has the first one
      creating a va_list and passing that va_list variadically to
      the second one... which creates a new va_list and passes it
      variadically to the third one... and of course everything
      blows up when we try to pull a non-va_list argument off the
      stack.
      
      The correct approach matches the C standard library's use
      of printf/vprintf, scanf/vscanf, and so on. Once you make
      a va_list, you must pass it only to functions which expect
      a va_list parameter.
      7fadd708
  21. 11 Aug, 2012 1 commit
  22. 04 Aug, 2012 1 commit
  23. 12 Jun, 2012 13 commits
    • Ian Barber's avatar
      Add asserts and rename pipe set · bc9ae715
      Ian Barber authored
      Rename the pipeset to terminating_pipes, as suggested by Martin H. Adds
      asserts to test the pipe is contained in the terminating set where
      appropriate.
      bc9ae715
    • Ian Barber's avatar
      Allow blocking while connect() is completing · e5904e63
      Ian Barber authored
      This patch, salvaged from a trainwreck accidental merge earlier, adds a
      new sockopt, ZMQ_DELAY_ATTACH_ON_CONNECT which prevents a end point
      being available to push messages to until it has fully connected, making
      connect work more like bind. This also applies to reconnecting sockets,
      which may cause message loss of in-queue messages, so it is sensible to
      use this in conjunction with a low HWM and potentially an alternative
      acknowledgement path.
      
      Notes on most of the individual commits can be found the repository log.
      e5904e63
    • Ian Barber's avatar
      Revert "After speaking with Ben Gray and the discussion on the mailing list,… · 95cbad38
      Ian Barber authored
      Revert "After speaking with Ben Gray and the discussion on the mailing list, this is an attempt to create a sockopt to allow connecting pipes to not immediately be available for traffic. The problem is in a PUSH to many PULL situation, where there is a connect to a PULL which is not there. This connect will immediately create a pipe (unlike bind), and traffic will be load balanced to that pipe. This means if there is a persistently unavailable end point then the traffic will queue until HWM is hit, and older messages will be lost."
      
      This reverts commit fe3fb419.
      95cbad38
    • Ian Barber's avatar
      Revert "Remove the extra outpipe handling as the session is quite capable of… · 5b167aa8
      Ian Barber authored
      Revert "Remove the extra outpipe handling as the session is quite capable of delaying the creation of the pipe until the connection has happened. Simply don't build the pipe, and let it do that automatically."
      
      This reverts commit 06485d92.
      5b167aa8
    • Ian Barber's avatar
      Revert "Fix a number of whitespace issues in various parts of the code, add… · 81b8362a
      Ian Barber authored
      Revert "Fix a number of whitespace issues in various parts of the code, add validation to most calls on the test and take a first stab at implementing the reconnection pipe blocking."
      
      This reverts commit 6f6466f0.
      81b8362a
    • Ian Barber's avatar
      Revert "Removing unnecessary outpipe values that had been used for reconnecting… · 74175dec
      Ian Barber authored
      Revert "Removing unnecessary outpipe values that had been used for reconnecting existing pipes - no longer needed when using a pipe term for the delay_attach situation."
      
      This reverts commit ace7c99b.
      74175dec
    • Ian Barber's avatar
      Revert "The previous code to block the socket from receiving on that pipe during… · 836fa4b7
      Ian Barber authored
      Revert "The previous code to block the socket from receiving on that pipe during a disconnect was vulnerable to a race condition. This code calls with the terminate functions of both ends of the pipe - I believe this should be safer. This required storing a pointer to the socket end of the pipe"
      
      This reverts commit 336f7272.
      836fa4b7
    • Ian Barber's avatar
      Revert "Reverted to a simpler shutdown. This seems to disconnect and reconnect… · 2c6f2615
      Ian Barber authored
      Revert "Reverted to a simpler shutdown. This seems to disconnect and reconnect the pipe properly, but there is a problem in overall shutdown when the pipe has blocked and reconnected - the session seems to get terminated() called on it only in shutdown for the original pipe, by which point it has been replaced. I am not sure at the moment why this only happens then, but this does mean this patch is broken at the moment"
      
      This reverts commit b84b0079.
      2c6f2615
    • Ian Barber's avatar
      Revert "As Martin pointed out, there is a race condition in the old code where a… · c9926f6f
      Ian Barber authored
      Revert "As Martin pointed out, there is a race condition in the old code where a pipe could start shutting down after disconnection, but the new one could connect first. This connection would not get a pipe created for it, so the messages could never flow. The simplest way round this would be a flag, but it is possibly for a very bouncy but fast connection to go up and down twice I imagine, so instead I have added a counter. This starts at zero, and will null out the pipe if terminate is called while it is zero. On a disconnect situation the counter is incremented, and the pipe is the not nulled if the value is non zero. In the terminated function it is decremented for each pipe that is shut down, and the assertion that the terminated pipe == the current pipe is skipped while it is non-zero. This should deal with the race condition and not allow any extra terminated() calls without hitting the assertion."
      
      This reverts commit a5f7300d.
      c9926f6f
    • Ian Barber's avatar
      Revert "Revert "Merge branch 'master' of github.com:ianbarber/libzmq"" · eb14890d
      Ian Barber authored
      This reverts commit 029d3dfa.
      eb14890d
    • Ian Barber's avatar
      Revert "Merge branch 'master' of github.com:ianbarber/libzmq" · 029d3dfa
      Ian Barber authored
      This reverts commit 33459029, reversing
      changes made to 889b0e6f.
      029d3dfa
    • Ian Barber's avatar
      Revert "Replace incomplete count with a std::set" · 6117a2b0
      Ian Barber authored
      This reverts commit 4aa5ba3d.
      Unintentional merge
      6117a2b0
    • Ian Barber's avatar
      Replace incomplete count with a std::set · 4aa5ba3d
      Ian Barber authored
      This commit removes the countdown flag and adds a set to store the pipes
      that are currently being disconnected.
      4aa5ba3d
  24. 10 Jun, 2012 1 commit
    • Ian Barber's avatar
      As Martin pointed out, there is a race condition in the old code where a pipe… · a5f7300d
      Ian Barber authored
      As Martin pointed out, there is a race condition in the old code where a pipe could start shutting down after disconnection, but the new one could connect first. This connection would not get a pipe created for it, so the messages could never flow. The simplest way round this would be a flag, but it is possibly for a very bouncy but fast connection to go up and down twice I imagine, so instead I have added a counter. This starts at zero, and will null out the pipe if terminate is called while it is zero. On a disconnect situation the counter is incremented, and the pipe is the not nulled if the value is non zero. In the terminated function it is decremented for each pipe that is shut down, and the assertion that the terminated pipe == the current pipe is skipped while it is non-zero. This should deal with the race condition and not allow any extra terminated() calls without hitting the assertion.
      a5f7300d
  25. 06 Jun, 2012 1 commit
    • Ian Barber's avatar
      Reverted to a simpler shutdown. This seems to disconnect and reconnect the pipe… · b84b0079
      Ian Barber authored
      Reverted to a simpler shutdown. This seems to disconnect and reconnect the pipe properly, but there is a problem in overall shutdown when the pipe has blocked and reconnected - the session seems to get terminated() called on it only in shutdown for the original pipe, by which point it has been replaced. I am not sure at the moment why this only happens then, but this does mean this patch is broken at the moment
      b84b0079