1. 12 Mar, 2013 2 commits
  2. 08 Mar, 2013 2 commits
  3. 19 Feb, 2013 2 commits
  4. 31 Jan, 2013 2 commits
  5. 02 Jan, 2013 2 commits
  6. 04 Dec, 2012 4 commits
  7. 22 Nov, 2012 1 commit
  8. 21 Nov, 2012 1 commit
  9. 17 Nov, 2012 1 commit
  10. 14 Nov, 2012 1 commit
  11. 09 Nov, 2012 4 commits
  12. 29 Oct, 2012 1 commit
  13. 24 Oct, 2012 1 commit
  14. 18 Oct, 2012 1 commit
  15. 21 Sep, 2012 1 commit
  16. 27 Aug, 2012 1 commit
    • Arthur O'Dwyer's avatar
      Silence all "unused parameter" warnings from Clang. · 3b984d40
      Arthur O'Dwyer authored
      Compiling without warnings is a good goal, because it makes
      new warnings (which probably indicate bugs) stand out rather
      than getting lost in the spam.
      
      My fixes fall into two categories:
      
          - Adding (void) casts of unused parameters, where their
            unusedness seems like a TODO (or in some cases a bug?).
      
          - Removing parameter names altogether, where the function
            is clearly a stub that will never use its parameters.
      
      Should be no change in behavior.
      3b984d40
  17. 26 Aug, 2012 2 commits
  18. 24 Aug, 2012 1 commit
    • Arthur O'Dwyer's avatar
      Fix monitor_event() to work at all. · 7fadd708
      Arthur O'Dwyer authored
      There are three versions of monitor_event(), all taking
      variadic arguments. The original code just has the first one
      creating a va_list and passing that va_list variadically to
      the second one... which creates a new va_list and passes it
      variadically to the third one... and of course everything
      blows up when we try to pull a non-va_list argument off the
      stack.
      
      The correct approach matches the C standard library's use
      of printf/vprintf, scanf/vscanf, and so on. Once you make
      a va_list, you must pass it only to functions which expect
      a va_list parameter.
      7fadd708
  19. 11 Aug, 2012 1 commit
  20. 17 Jul, 2012 1 commit
  21. 06 Jul, 2012 1 commit
  22. 12 Jun, 2012 7 commits
    • Ian Barber's avatar
      Allow blocking while connect() is completing · e5904e63
      Ian Barber authored
      This patch, salvaged from a trainwreck accidental merge earlier, adds a
      new sockopt, ZMQ_DELAY_ATTACH_ON_CONNECT which prevents a end point
      being available to push messages to until it has fully connected, making
      connect work more like bind. This also applies to reconnecting sockets,
      which may cause message loss of in-queue messages, so it is sensible to
      use this in conjunction with a low HWM and potentially an alternative
      acknowledgement path.
      
      Notes on most of the individual commits can be found the repository log.
      e5904e63
    • Ian Barber's avatar
      Revert "After speaking with Ben Gray and the discussion on the mailing list,… · 95cbad38
      Ian Barber authored
      Revert "After speaking with Ben Gray and the discussion on the mailing list, this is an attempt to create a sockopt to allow connecting pipes to not immediately be available for traffic. The problem is in a PUSH to many PULL situation, where there is a connect to a PULL which is not there. This connect will immediately create a pipe (unlike bind), and traffic will be load balanced to that pipe. This means if there is a persistently unavailable end point then the traffic will queue until HWM is hit, and older messages will be lost."
      
      This reverts commit fe3fb419.
      95cbad38
    • Ian Barber's avatar
      Revert "Remove the extra outpipe handling as the session is quite capable of… · 5b167aa8
      Ian Barber authored
      Revert "Remove the extra outpipe handling as the session is quite capable of delaying the creation of the pipe until the connection has happened. Simply don't build the pipe, and let it do that automatically."
      
      This reverts commit 06485d92.
      5b167aa8
    • Ian Barber's avatar
      Revert "Fix a number of whitespace issues in various parts of the code, add… · 81b8362a
      Ian Barber authored
      Revert "Fix a number of whitespace issues in various parts of the code, add validation to most calls on the test and take a first stab at implementing the reconnection pipe blocking."
      
      This reverts commit 6f6466f0.
      81b8362a
    • Ian Barber's avatar
      Revert "Fix condition so that PGM and EPGM sockets always create pipes… · 48d39776
      Ian Barber authored
      Revert "Fix condition so that PGM and EPGM sockets always create pipes immediately, even if delay_attach_on_connect is set. This allows passing through the icanhasall flag, and is realistic given the fact those protocols should be able to connect immediately"
      
      This reverts commit b5ace39e.
      48d39776
    • Ian Barber's avatar
      Revert "On the advice of Martin Hurton, removed the new command type and just… · f0920caf
      Ian Barber authored
      Revert "On the advice of Martin Hurton, removed the new command type and just terminated the pipe in a reconnect situation, and notified the socket of the same. This handles the blocking properly, but at the cost of potentially losing in flight messages. However, this is a reasonable trade off given how much simpler it makes the patch."
      
      This reverts commit c13f1d52.
      f0920caf
    • Ian Barber's avatar
      Revert "Use the hiccup mechanism to notify the socket end of the pair of the… · 3ae68d67
      Ian Barber authored
      Revert "Use the hiccup mechanism to notify the socket end of the pair of the change in state, and have it shutdown that end, and shutdown the local end normally. This seems to resolve the shutdown and race condition issues."
      
      This reverts commit 67497a26.
      3ae68d67