Solution: change comments
Fixes: #3036

Fix assertion failure when calling zmq_poller_destroy after zmq_ctx_term

Problem: socket_poller destruction after context shutdown is only tested with a non-thread-safe socket

Solution: test with both thread-safe and non-thread-safe sockets

Solution: do not call getsockopt to query thread-safety of a socket

Solution: Added test case to reproduce, not solving the problem!

Problem: clang-format Travis job broken

Solution: don't run configure

* always run tests from tarball of `make dist`

ensures that tests will not pass if critical files are omitted from releases

* add explicit make dist only for non-default builds

distcheck should already cover this for default builds

* don’t verify that valgrind/coverage tests can be run from dists

* add various files missing from dists

- missing template from cmake
- add missing android build files
- add some missing ci_build.sh scripts

Problem: 4.2.5 is out, we need to restore API changes and 4.3.x

Solution: revert the revert!

Revert "Problem: regression in 4.2.3 went unnoticed, want to release 4.2.5"

This reverts commit 5f17e26f.

Problem: regression in 4.2.3 needs to be fixed before 4.3

Solution: note bug fixes

Solution: revert DRAFT -> STABLE API transition so that we can do a
bugfix-only 4.2.5 release.
Will be re-reverted once tagged.

Revert "Problem: ZMQ_BINDTODEVICE has met STABLE conditions"

This reverts commit 3cb79f50.

Revert "Problem: ZMQ_MSG_GSSAPI_* have met STABLE conditions"

This reverts commit 374da420.

Revert "Problem: ZMQ_MSG_T_SIZE has met STABLE conditions"

This reverts commit 6411c4a2.

Revert "Problem: docs say STABLE API still in DRAFT"

This reverts commit 9f2f30b7.

Problem: backward incompatible change to NULL with ZAP

Solution: like for other mechanism, do not enforce strict ZAP protocol
adherence unless the specific socket option is enabled with NULL auth.

Add test to exercise this functionality, and fix ZAP test to set the
socket option when it uses NULL auth.

See: https://github.com/zeromq/pyzmq/pull/1152

Solution: override unused parameter for NULL wrapper

Problem: some inaccuracies in manpages

Solution: fix it, as since 4.2.0 there is no ordering constraint
anymore
Fixes: #2854

Solution: clarify it since it's a common source of confusion

Solution: update them

Fix gcc build problem

Fixed gcc-related build problem resulting from `-errwarn=%all` switch.

Fixes #3012.

Problems: some APIs have met stable conditions

Solution: move them from DRAFT to STABLE since it's been in a public
release, committed for 6+ months and has not changed.

Solution: move them from DRAFT to STABLE since it's been in a public
release, committed for 6+ months and has not changed.

Solution: update manpages

Solution: move it from DRAFT to STABLE since it's been in a public
release, committed for 6+ months and has not changed.
Given a new STABLE symbol has been added, bump minor version number.

Problem: 4.2.4 is out, version is out of date

Solution: bump to 4.2.5

Solution: add it

Migrate test_reqrep_tcp to unity

Solution: replaced by a comment explaining why the calls are in the test

Solution: extracted make_connect_address

Solution: extracted bind_loopback

Solution: migrate to unity

Problem: NEWS out of date

Solution: note new features, APIs and major user-visible bug fixes

Problem: Unnecessary errno_assert