Solution: replace by C++-style casts

Solution: restructured code, inverted condition

Solution: handle types properly

Solution: use a typedef instead

Solution: check and return an error on invalid arguments. Fixes #3088

Solution: extract common code into functions

Solution: return NULL and set errno to ENOMEM

Solution: commit clang-format-diff

* Problem: Still need to port over more files to VxWorks 6.x

Solution: Port more files to VxWorks 6.x

* Problem: Need to port over remaining files to VxWorks 6.x. Also remove POSIX thread dependency for VxWorks (because of priority inversion problem in POSIX mutexes with VxWorks 6.x processes)

Solution: Port over remaining files to VxWorks 6.x. Also removed POSIX thread dependency for VxWorks

* Problem: Needed to modify TCP, UDP, TIPC classes with #ifdefs to be compatible with VxWorks 6.x.

Solution:  Modify TCP, UDP, TIPC classes with #ifdefs to be compatible with VxWorks 6.x

Solution: run make clang-format-diff and commit the changes.

reuse

Solution: extract into functions defined in ip.hpp

Problem: signaler_t::make_fdpair not reusable

Solution: move make_fdpair to ip.hpp

Problem: epoll worker with no fds cannot be stopped

Solution: use interruptible epoll_pwait call

Problem: insufficient unit tests for poller

Solution: add test cases

Solution: applied clang-format

Solution: signal error to caller, and apply appropriate cleanup

Solution: replace by "routing id"

Solution: replace by "routing id"

Solution: add initial implementation

Solution: extract as_socket_base_t function

Solution: added test case (with dummy implementation of zmq_socket_get_peer_state)

Solution: replace ETIMEDOUT within socket_poller_t and all client code by EAGAIN

Fixes #2713

Solution: Return EBADF instead

Problem: calling zmq_poller_wait* with NULL events causes an assertion, as opposed to other NULL arguments, which return an error

Solution: return EFAULT when such an operation is attempted

Solution: add checks, added test cases

solution: fix it

In particular, on Windows, using FD_ZERO is much more efficient than
zeroing out the whole structure.

Problem: FD set copying on Windows still not optimal on some places. Solution: Improved memcpy() of FD sets for Windows builds.

Unnecessary dynamic memory allocation for zmq::socket_poller_t in zmq_poller_poll(). Fixed by allocating zmq::socket_poller_t from stack.

Solution: Pass (std::nothrow) as done in all other places.

As discussed in #2307

Solution: fix the check for the socket.
This regression happens when using zloop with zmq_pollitem_it with
only file descriptors registerted through zloop_poller.

item.fd should be ignored if item.socket is defined.

Failing to check .socket could cause false-matches, raising EINVAL in zmq_poller_modify_fd.

This block of code will either return -1 or fall through.
The while (true) does nothing.
The braces limit the scope of int rc.

Solution: honor it

* Doing so was zmq_poller_poll to always return 0.

This should restore full compatibility with earlier zmq_poll behavior.

It complicates things a little bit, as collisions must be detected, and when collisions are found:

- event masks must be merged
- pollitems, events arrays are no longer co-ordered

Reverts the recent zmq_proxy patch to workaround the lack of repeat-item support in zmq_poll that is now fixed.

not -1, ETIMEDOUT like zmq_poller

Return value is the number of events found. This also propagates to the return value of zmq_poller_wait_all.

zmq_poller_wait was only returning events on the first-registered socket.

variable-size array allocation is not allowed by some compilers

enables zmq_poll on threadsafe sockets only supported in zmq_poller (radio, dish, etc.)