Commit 7cf0d125 authored by Simon Giesecke's avatar Simon Giesecke

Problem: failed address resolution on TCP connect is not observable

Solution: added TODO comment for now
parent e45ede49
...@@ -227,6 +227,8 @@ int zmq::socks_connecter_t::connect_to_proxy () ...@@ -227,6 +227,8 @@ int zmq::socks_connecter_t::connect_to_proxy ()
_s = tcp_open_socket (_addr->address.c_str (), options, false, false, _s = tcp_open_socket (_addr->address.c_str (), options, false, false,
_addr->resolved.tcp_addr); _addr->resolved.tcp_addr);
if (_s == retired_fd) { if (_s == retired_fd) {
// TODO we should emit some event in this case!
LIBZMQ_DELETE (_addr->resolved.tcp_addr); LIBZMQ_DELETE (_addr->resolved.tcp_addr);
return -1; return -1;
} }
......
...@@ -177,6 +177,8 @@ int zmq::tcp_connecter_t::open () ...@@ -177,6 +177,8 @@ int zmq::tcp_connecter_t::open ()
_s = tcp_open_socket (_addr->address.c_str (), options, false, true, _s = tcp_open_socket (_addr->address.c_str (), options, false, true,
_addr->resolved.tcp_addr); _addr->resolved.tcp_addr);
if (_s == retired_fd) { if (_s == retired_fd) {
// TODO we should emit some event in this case!
LIBZMQ_DELETE (_addr->resolved.tcp_addr); LIBZMQ_DELETE (_addr->resolved.tcp_addr);
return -1; return -1;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment