Commit 47dbd4aa authored by Pieter Hintjens's avatar Pieter Hintjens

Merge pull request #334 from ianbarber/master

Async connect error handling
parents f497aae8 1075005b
...@@ -187,6 +187,13 @@ int zmq::ipc_connecter_t::open () ...@@ -187,6 +187,13 @@ int zmq::ipc_connecter_t::open ()
if (rc == 0) if (rc == 0)
return 0; return 0;
// Translate other error codes indicating asynchronous connect has been
// launched to a uniform EINPROGRESS.
if (rc == -1 && errno == EINTR) {
errno = EINPROGRESS;
return -1;
}
// Forward the error. // Forward the error.
return -1; return -1;
} }
......
...@@ -140,7 +140,7 @@ void zmq::tcp_connecter_t::start_connecting () ...@@ -140,7 +140,7 @@ void zmq::tcp_connecter_t::start_connecting ()
} }
// Connection establishment may be delayed. Poll for its completion. // Connection establishment may be delayed. Poll for its completion.
else if (rc == -1 && errno == EAGAIN) { else if (rc == -1 && errno == EINPROGRESS) {
handle = add_fd (s); handle = add_fd (s);
handle_valid = true; handle_valid = true;
set_pollout (handle); set_pollout (handle);
...@@ -211,17 +211,18 @@ int zmq::tcp_connecter_t::open () ...@@ -211,17 +211,18 @@ int zmq::tcp_connecter_t::open ()
if (rc == 0) if (rc == 0)
return 0; return 0;
// Asynchronous connect was launched. // Translate other error codes indicating asynchronous connect has been
// launched to a uniform EINPROGRESS.
#ifdef ZMQ_HAVE_WINDOWS #ifdef ZMQ_HAVE_WINDOWS
if (rc == SOCKET_ERROR && (WSAGetLastError () == WSAEINPROGRESS || if (rc == SOCKET_ERROR && (WSAGetLastError () == WSAEINPROGRESS ||
WSAGetLastError () == WSAEWOULDBLOCK)) { WSAGetLastError () == WSAEWOULDBLOCK)) {
errno = EAGAIN; errno = EINPROGRESS;
return -1; return -1;
} }
wsa_error_to_errno (); wsa_error_to_errno ();
#else #else
if (rc == -1 && errno == EINPROGRESS) { if (rc == -1 && errno == EINTR) {
errno = EAGAIN; errno = EINPROGRESS;
return -1; return -1;
} }
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment