• Simon Giesecke's avatar
    Problem: Possible buffer overruns related to metadata in various mechanisms (#2683) · 4a18f620
    Simon Giesecke authored
    * Problem: no test case with CURVE encryption and large identity
    
    Solution: added test case (currently crashing)
    
    * Problem: possible buffer overflow in mechanism_t::add_property
    
    Solution: add target buffer length parameter and check the buffer is sufficiently large
    
    * Problem: test cases accidentally excluded from build
    
    Solution: remove #if/#endif
    
    * Problem: possible buffer overruns related to metadata at various locations
    
    Solution: allocate buffer large enough for actual metadata, reduce code duplication
    
    * Problem: syntax error related to pointer type conversion
    
    Solution: change argument type of make_command_with_basic_properties to const char *
    
    * Problem: large metadata may cause an assertion in produce_initiate
    
    Solution: Allow metadata of arbitrary size in produce_initiate
    4a18f620
plain_client.cpp 5.48 KB