• Mirko Bonadei's avatar
    Using all_dependent_configs to pass libyuv_config around. · d94a4867
    Mirko Bonadei authored
    Using public_configs, client projects must rely on public_deps to
    propagate configurations up in the build graph. This is bad because
    public_deps allows the exposition of headers that live in another
    target. This can lead to a really unhealthy build.
    
    On the other side, all_dependent_configs is automatically propagated
    up in the build graph but if a target includes a libyuv header it is
    forced by GN to declare the dependency (and this will propagate
    libyuv_config).
    
    Bug: webrtc:8605, webrtc:8603
    Change-Id: I4d71bb5de0b5b62a4ec110349223614f0b98e655
    No-Try: True
    Reviewed-on: https://chromium-review.googlesource.com/822112
    Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
    Reviewed-by: 's avatarPatrik Höglund <phoglund@chromium.org>
    d94a4867
Name
Last commit
Last update
build_overrides Loading commit data...
docs Loading commit data...
include Loading commit data...
infra/config Loading commit data...
source Loading commit data...
tools_libyuv Loading commit data...
unit_test Loading commit data...
util Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
AUTHORS Loading commit data...
Android.bp Loading commit data...
Android.mk Loading commit data...
BUILD.gn Loading commit data...
CM_linux_packages.cmake Loading commit data...
CMakeLists.txt Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE_THIRD_PARTY Loading commit data...
OWNERS Loading commit data...
PATENTS Loading commit data...
PRESUBMIT.py Loading commit data...
README.chromium Loading commit data...
README.md Loading commit data...
all.gyp Loading commit data...
cleanup_links.py Loading commit data...
codereview.settings Loading commit data...
download_vs_toolchain.py Loading commit data...
gyp_libyuv Loading commit data...
gyp_libyuv.py Loading commit data...
libyuv.gni Loading commit data...
libyuv.gyp Loading commit data...
libyuv.gypi Loading commit data...
libyuv_nacl.gyp Loading commit data...
libyuv_test.gyp Loading commit data...
linux.mk Loading commit data...
public.mk Loading commit data...
pylintrc Loading commit data...
winarm.mk Loading commit data...