Commits · c2bff1a1af3933c866673c8184e635495d648739 · submodule / libyuv

04 Nov, 2015 7 commits

Frank Barchard authored Nov 04, 2015

using a stripped down gn file from webrtc.

BUG=libyuv:411,libyuv:519
R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/1417613007 .

c2bff1a1

Neon versions of I420AlphaToARGB · 860cc035

Frank Barchard authored Nov 04, 2015

Add alpha version of YUV to RGB to neon code for ARMv7 and aarch64.
For other YUV to RGB conversions, hoist alpha set to 255 out of loop.

TBR=harryjin@google.com
BUG=libyuv:516

Review URL: https://codereview.chromium.org/1413763017 .

860cc035

unittest fix for cpu flags. · 82d74a37

Frank Barchard authored Nov 04, 2015

cpu flags of 1 disables SIMD and uses C.  This used to be 0, but the change
in auto init behavior means that 0 now means uninitialized, and will cause
auto detect to reinit the cpu info.  A value of 1 disables the auto init.

TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1408753004 .

82d74a37

cpuid tool fix - remove mipsdsp and add avx3 · ab9a42d9
Frank Barchard authored Nov 04, 2015
```
TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1412373006 .
```
ab9a42d9
rename yuv matrix constants to be more clear about what they are · d95d2169
Frank Barchard authored Nov 04, 2015
```
R=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1429693006 .
```
d95d2169

add command line cpu info to allow android neon test · c629cb3a

Frank Barchard authored Nov 04, 2015

in order to compare C and Neon code, a new command line flag is added.
historically environment variables controlled cpu features, but on
android apk it is easier to pass a command line option to disable cpu
optimizations.

R=harryjin@google.com
BUG=libyuv:516

Review URL: https://codereview.chromium.org/1407193009 .

c629cb3a

remove mips dsp detect · 1f1d140b

Frank Barchard authored Nov 04, 2015

DSP code is not actually used, only DSPR2.  Remove the detect.

TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1405043008 .

1f1d140b

03 Nov, 2015 1 commit

Raw 24 bit RGB to RGB24 (bgr) · ce4c2fad

Frank Barchard authored Nov 03, 2015

Add unittests that do 1 step conversion vs 2 step conversion.

Tests end swapping versions match direct conversions.

R=harryjin@google.com
BUG=libyuv:518

Review URL: https://codereview.chromium.org/1419103007 .

ce4c2fad

02 Nov, 2015 2 commits

remove store bgra, abgr, raw unused macros · 87926cec

Frank Barchard authored Nov 02, 2015

TBR=harryjin@google.com
BUG=libyuv:518

Review URL: https://codereview.chromium.org/1420033004 .

87926cec

remove I422ToBGRA and use I422ToRGBA internally · 2c7aa007

Frank Barchard authored Nov 02, 2015

Removes low levels for I420ToBGRA and I420ToRAW and reimplements them as I420ToRGBA and I420ToRGB24 with transposed color matrix.

Adds unittests that do 1 step conversion vs 2 steps to test end swapping versions match direct conversions.

R=harryjin@google.com
BUG=libyuv:518

Review URL: https://codereview.chromium.org/1427993004 .

2c7aa007

30 Oct, 2015 1 commit

refactor I420ToABGR to use I420ToARGBRow · 5d97b933

Frank Barchard authored Oct 30, 2015

Using a transposed conversion matrix, I420ToARGB can output ABGR.

R=harryjin@google.com, xhwang@chromium.org
BUG=libyuv:473

Review URL: https://codereview.chromium.org/1413573010 .

5d97b933

29 Oct, 2015 1 commit
- disable I420AlphaToARGB for 32 bit intel debug build · 254ef015
  Frank Barchard authored Oct 29, 2015
```
R=harryjin@google.com
BUG=libyuv:517

Review URL: https://codereview.chromium.org/1428843003 .
```
  254ef015
28 Oct, 2015 2 commits

Fix debug compilation problems for gcc and 32 bit x86. · cdbdf5b7

Frank Barchard authored Oct 28, 2015

In some methods with 7 arguments gcc fails to find enough registers
to compile the assembler code when compiling debug. Simplest solution
is to skip the assembler version in debug of those particular functions

(I422Alpha -> ARBG/ABGR)

R=harryjin@google.com,bratell@opera.com
BUG=libyuv:517

Review URL: https://codereview.chromium.org/1423283002 .

cdbdf5b7

pass clangcl compile options to ignore warnings in gflags.cc · 811a5ec4

Frank Barchard authored Oct 28, 2015

R=ajm@chromium.org, ajm@google.com
BUG=libyuv:513,webrtc:760

Review URL: https://codereview.chromium.org/1427643003 .

811a5ec4

27 Oct, 2015 3 commits

refactor I420AlphaToABGR to use I420AlphaToARGB internally · b86dbf24

Frank Barchard authored Oct 27, 2015

swap U and V and transpose conversion matrix, so I420AlphaToARGB and
I420AlphaToABGR share low level code.

Having less code with same performance allows more focused
optimization for future ARM versions.

R=harryjin@google.com
TBR=harryjin@chromium.org
BUG=libyuv:473,libyuv:516

Review URL: https://codereview.chromium.org/1422263002 .

b86dbf24

implement I444ToABGR by swapping uv and transpose matrix · cf160cdb

Frank Barchard authored Oct 27, 2015

U contributes to B and G. V contributes to R and G.
By swapping U and V, they contribute to the opposite channels. Adjust the matrix so the U contribution is in the matrix location such that it till contribute to the
new B channel and vice versa.
This allows ABGR versions of YUV conversion to use the same low level code as ARGB, just using a different matrix and swapping U and V pointers.

As a result the existing I444ToABGRRow functions are no longer needed and are removed.

Previously this function was only Intel AVX2 optimized for Windwos. Now it is also optimized for Arm and GCC.

ARMv7 Neon
Was LibYUVConvertTest.I444ToABGR_Opt (75971 ms)
Now LibYUVConvertTest.I444ToABGR_Opt (3672 ms)
20.6 times faster.

R=xhwang@chromium.org
BUG=libyuv:515

Review URL: https://codereview.chromium.org/1414133006 .

cf160cdb

add unittest that compares ABGR to ARGB · e8ee1755

Frank Barchard authored Oct 27, 2015

TBR=harryjin@google.com
BUG=libyuv:515

Review URL: https://codereview.chromium.org/1423663007 .

e8ee1755

26 Oct, 2015 1 commit

Add avx512bw detection code · 2844662e

Frank Barchard authored Oct 26, 2015

R=harryjin@google.com
BUG=libyuv:514

Review URL: https://codereview.chromium.org/1413463004 .

2844662e

23 Oct, 2015 1 commit
- switch cpu flags to 0 for unitialized to avoid compare · 1502832a
  Frank Barchard authored Oct 23, 2015
```
R=harryjin@google.com
BUG=libyuv:512

Review URL: https://codereview.chromium.org/1418253002 .
```
  1502832a
22 Oct, 2015 4 commits

initialize cpu flags to fix compile error on windows · ad36ba5c
Frank Barchard authored Oct 22, 2015
```
R=harryjin@google.com
BUG=libyuv:512

Review URL: https://codereview.chromium.org/1422733003 .
```
ad36ba5c
color unittest allow j420 error of 5 for arm · 00f15e3c
Frank Barchard authored Oct 22, 2015
```
R=harryjin@google.com
BUG=libyuv:511

Review URL: https://codereview.chromium.org/1412683005 .
```
00f15e3c

odd width 444 fix · 430bb0a0

Frank Barchard authored Oct 22, 2015

TBR=harryjin@google.com
BUG=libyuv:510

Review URL: https://codereview.chromium.org/1415583003 .

430bb0a0

bug fix for odd width 16/24 bit to i420 · 90335f60

Frank Barchard authored Oct 22, 2015

A bug was introduced on arm when the code for 'any' width switch to
a temporary stack buffer and simd.
The C version handles odd width by doing 1 pixel, instead of averaging 2.
But the SIMD any version is supposed to replicate the last pixel, then
the subsampling in Neon will average the pixel with itself, producing
the same result.
The previous version did this, but only for ARGB 32 bit, which was to
avoid introducing issues with subsampled YUY2 source.  This CL adds
replication for RGB 16 bit values.

TBR=harryjin@google.com
BUG=libyuv:510

Review URL: https://codereview.chromium.org/1418983003 .

90335f60

21 Oct, 2015 2 commits

width and 3 bug fix in odd width support of ARGBToI411 · 5bf4de08
Frank Barchard authored Oct 21, 2015
```
TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1415213002 .
```
5bf4de08

Fix ARGBToI411 odd width bug. · ba4b409d

Frank Barchard authored Oct 21, 2015

The any function for handling ARGBToI411 was not handling the pixel
replication correctly.  On 422 and odd width was handled by duplicating
a pixel of source.  411 needs replication for remainders of 1, 2 or 3
pixels.

The C version was handling odd width but with an average of the remainder
pixels, which does not match the SIMD 'any' handling off remainder.
This changes the odd width handling to mimic the any version.

TBR=harryjin@google.com
BUG=libyuv:491

Review URL: https://codereview.chromium.org/1411733004 .

ba4b409d

20 Oct, 2015 4 commits

Move cpu_info variable outside ifdef · 9daa550a

Frank Barchard authored Oct 20, 2015

Fix compile error on arm, mips etc due to undefined variable.

TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1403373008 .

9daa550a

write to cpu_flags once · 9be6d21a

Frank Barchard authored Oct 20, 2015

To make init cpu flags thread safe, there can only be one write to the variable.

R=richard.winterton@intel.com, harryjin@google.com
BUG=libyuv:508

Review URL: https://codereview.chromium.org/1412793006 .

9be6d21a

DEPS roll of chromium to head · d99324dd

Frank Barchard authored Oct 20, 2015

A fix for android -a was checked in, allowing libyuv gtest flags to be pass.
This CL rolls to the head version of chromium to pull in the change,
allowing better testing and benchmarking of libyuv on android.

TBR=harryjin@google.com
BUG=libyuv:507

Review URL: https://codereview.chromium.org/1416663006 .

d99324dd

Roll chromium_revision bb79186..5d149df (353481:354955) · 97ec206e

Henrik Kjellander authored Oct 20, 2015

Changelog: https://chromium.googlesource.com/chromium/src/+log/bb79186..5d149df

TBR=fbarchard@chromium.org

Review URL: https://codereview.chromium.org/1416823002 .

97ec206e

19 Oct, 2015 1 commit

Call AllowCommandLineReparsing in unit tests · e6a54f22

Frank Barchard authored Oct 19, 2015

Allows us to ignore flags passed on to us by Chromium build bots
without having to explicitly disable them. (Thanks pbos!)

TESTED=webrtc ran modules_unittests with a bogus flag did not result in an
error.

R=kjellander@chromium.org
BUG=libyuv:507

Review URL: https://codereview.chromium.org/1417573002 .

e6a54f22

18 Oct, 2015 1 commit

Sync gflags into the right location. · 7e936044

Henrik Kjellander authored Oct 18, 2015

The DEPS entry for gflags added in https://codereview.chromium.org/1413723002/
assumed the Chromium/WebRTC checkout layout with 'src' as the
top-directory name. That doesn't work for libyuv, since the top-directory
is named 'libyuv'.

BUG=libyuv:507

Review URL: https://codereview.chromium.org/1410673004 .

7e936044

17 Oct, 2015 1 commit

add gflags support files from webrtc · 94312b69

Frank Barchard authored Oct 17, 2015

files needed for command line support with gtest.
These files are copied directly from webrtc.

TBR=kjellander@chromium.org
BUG=libyuv:507

Review URL: https://codereview.chromium.org/1414483002 .

94312b69

16 Oct, 2015 4 commits

Add gflags dependency · 8dcec019

Henrik Kjellander authored Oct 16, 2015

Unit tests currently use environment variables to change behavior.
Using gflags this can be done via command line.

BUG=libyuv:507
TBR=fbarchard@chromium.org

Review URL: https://codereview.chromium.org/1413723002 .

8dcec019

Revert "add gflags to deps to allow command line parameters." · f80cc26d

Henrik Kjellander authored Oct 16, 2015

This reverts commit 2dd3d923.

Reason: chromium_git is a missing variable, and to properly
add gflags, we need to check in GYP files in third_party/gflags
first, then add the DEPS entry.

BUG=libyuv:507
TBR=fbarchard@chromium.org

Review URL: https://codereview.chromium.org/1406323002 .

f80cc26d

add gflags to deps to allow command line parameters. · 2dd3d923

Frank Barchard authored Oct 16, 2015

unittests currently use environment variables to change behavior.
using gflags this can be done via command line.

R=kjellander@chromium.org
BUG=libyuv:507

Review URL: https://codereview.chromium.org/1402313002 .

2dd3d923

remove have jpeg test · 5d0a871d

Frank Barchard authored Oct 16, 2015

This test is just a printf, not a real test, but somehow
fails on arm.

TBR=harryjin@google.com
BUG=libyuv:506

Review URL: https://codereview.chromium.org/1409913002 .

5d0a871d

15 Oct, 2015 3 commits

nv21 any fix · cf19a0c9

Frank Barchard authored Oct 15, 2015

R=harryjin@google.com
BUG=libyuv:507

Review URL: https://codereview.chromium.org/1410643002 .

cf19a0c9

fix for C version of YUV to RGB for Arm · 52a55049

Frank Barchard authored Oct 15, 2015

YuvPixel for arm was miscomputing YG.

TBR=harryjin@google.com
BUG=libyuv:506

Review URL: https://codereview.chromium.org/1402333002 .

52a55049

disable color test that hangs on C version for Arm. · d5c2a115
Frank Barchard authored Oct 15, 2015
```
TBR=harryjin@google.com
BUG=libyuv:506

Review URL: https://codereview.chromium.org/1403183002 .
```
d5c2a115

14 Oct, 2015 1 commit

create color test category of unittests to narrow down arm bug · e2417df4

Frank Barchard authored Oct 14, 2015

A hang in color conversion on arm occurs somewhere in yuv to rgb.
Breaking the color test into its own category of test will help
run selective tests to narrow down the issue.

R=harryjin@google.com
BUG=libyuv:506

Review URL: https://codereview.chromium.org/1405543003 .

e2417df4