Commits · b0426365c92c840fb980b2b6f5c47326045db8f1 · submodule / libyuv

03 Feb, 2016 1 commit
- Add UBSan trybots to the default set. · b0426365
  Henrik Kjellander authored Feb 03, 2016
```
TBR=fbarchard@chromium.org

Review URL: https://codereview.chromium.org/1656423002 .
```
  b0426365
02 Feb, 2016 3 commits

fix for ubsan on unittest.h fastrand() · 903c91cc

Frank Barchard authored Feb 02, 2016

internal math of the fastrand function uses a multiply
and add that overflows a signed int.  This triggers a
ubsan failure:

../../unit_test/../unit_test/unit_test.h:60:33: runtime error: signed integer overflow: 56248274 * 214013 cannot be represented in type 'int'

This change casts the intermediate math to unsigned
int to avoid the overflow.

For more info on ubsan, see
http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer

TESTED=Passing compilation using:
GYP_DEFINES="ubsan=1"
GYP_DEFINES="ubsan_vptr=1"

R=harryjin@google.com, pbos@webrtc.org
BUG=libyuv:563

Review URL: https://codereview.chromium.org/1662453003 .

903c91cc

rework scale code for ubsan · 05ed0c53

Frank Barchard authored Feb 02, 2016

For more info on ubsan, see
http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer

TESTED=Passing compilation using:
GYP_DEFINES="ubsan=1"
GYP_DEFINES="ubsan_vptr=1"

R=harryjin@google.com, pbos@webrtc.org
BUG=libyuv:563

Review URL: https://codereview.chromium.org/1654253004 .

05ed0c53

UBSan: Add blacklist files for libyuvC standalone. · 0e7d2926

Frank Barchard authored Feb 02, 2016

For more info, see
http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer

TESTED=Passing compilation using:
GYP_DEFINES="ubsan=1"
GYP_DEFINES="ubsan_vptr=1"

R=harryjin@google.com, pbos@webrtc.org
BUG=libyuv:563,webrtc:5124

Review URL: https://codereview.chromium.org/1659713002 .

0e7d2926

01 Feb, 2016 1 commit

ubsan overflow fix for multiply by 0x01010101 · 9e39c1f2

Frank Barchard authored Feb 01, 2016

This is an UBSan error reported by libjingle

[ RUN      ] WebRtcVideoFrameTest.ConvertToYUY2BufferStride
[000:000] (videoframe.cc:375): Validate frame passed. format: I420 bpp: 12 size: 1280x720 bytes: 1382400 expected: 1382400 sample[0..3]: 73, 73, 73, 73
../../chromium/src/third_party/libyuv/source/row_gcc.cc:2903:25: runtime error: signed integer overflow: 128 * 16843009 cannot be represented in type 'int'
[8/614] WebRtcVideoFrameTest.ConvertToYUY2BufferStride returned/aborted with exit code 1 (32 ms)
[9/614] WebRtcVideoFrameTest.ConvertToYUY2BufferInverted (29 ms)
Note: Google Test filter = WebRtcVideoFrameTest.ConvertToYUY2BufferInverted

The source is uint8 and the multiply is by 0x01010101 to replicate the byte to 4 bytes.
Changing the constant to 0x01010101u should avoid overflow.

R=harryjin@google.com
TBR=harryjin@google.com
BUG=libyuv:563

Review URL: https://codereview.chromium.org/1657533005 .

9e39c1f2

27 Jan, 2016 1 commit

Remove duplicate prototype for MJPGToARGB · 1cc01776

Frank Barchard authored Jan 27, 2016

MJPGToARGB prototype is in both convert_argb.h and planar_functions.h
Remove the duplicate prototype from planar_functions.h

R=harryjin@google.com
TBR=harryjin@google.com
BUG=libyuv:561

Review URL: https://codereview.chromium.org/1638133002 .

1cc01776

21 Jan, 2016 3 commits

Remove svn version build and unittest. · ad71738f

Frank Barchard authored Jan 21, 2016

R=harryjin@google.com
TBR=harryjin@google.com, kjellander@google.com
BUG=libyuv:551

Review URL: https://codereview.chromium.org/1612123002 .

ad71738f

Disable sometimes-uninitialized Clang warning for iOS · a4288dd6

Henrik Kjellander authored Jan 21, 2016

This works around a compile problem with iossim.mm.

BUG=libyuv:548
TBR=fbarchard@chromium.org

Review URL: https://codereview.chromium.org/1611123004 .

a4288dd6

Remove mac_x64_rel from trybot defaults. · 484692b6

Henrik Kjellander authored Jan 21, 2016

As this bot was removed in https://codereview.chromium.org/1613013003/

TBR=fbarchard@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1615793002 .

484692b6

20 Jan, 2016 2 commits

Rename test from CropNV12 to NV12Crop · 085bfc1d

Frank Barchard authored Jan 20, 2016

When scanning profiles for unexpected _C functions
this test function contained the substring.
Changing the name will simplify the search.

TBR=harryjin@google.com
BUG=libyuv:543

Review URL: https://codereview.chromium.org/1602363002 .

085bfc1d

Fix testi420 unittest for odd height · 8c196f4d

Frank Barchard authored Jan 20, 2016

When the image height for unittests was set to an
odd height, the TestI420 unittest would not fill
the complete source buffer.  This change handles
the odd height test case.
No change to library code.

TBR=harryjin@google.com
BUG=libyuv:549

Review URL: https://codereview.chromium.org/1609103002 .

8c196f4d

19 Jan, 2016 1 commit

Fix memory overwrite in YUY2ToNV12 odd wdiths · 58cb5349

Frank Barchard authored Jan 19, 2016

When width was odd Y channel wrote an extra pixel.
This change splits the Y from UV into a temporary
buffer and memcpy's to the destination.  Performance
is slower.

Was
YUY2ToNV12_Any (307 ms)
YUY2ToNV12_Unaligned (213 ms)
TestYUY2ToNV12 (181 ms)
YUY2ToNV12_Opt (177 ms)
YUY2ToNV12_Invert (177 ms)

Npw
YUY2ToNV12_Any (300 ms)
YUY2ToNV12_Unaligned (226 ms)
YUY2ToNV12_Invert (206 ms)
TestYUY2ToNV12 (184 ms)
YUY2ToNV12_Opt (181 ms)
TBR=harryjin@google.com
BUG=libyuv:545

Review URL: https://codereview.chromium.org/1593833002 .

58cb5349

15 Jan, 2016 1 commit

Fix I420ToNV21 for wrong dst_stride_y parameter. · 8377c798

Frank Barchard authored Jan 15, 2016

I420ToNV21 passes the wrong dst_stride_y when it calls I420ToNV12; parameter 8 (convert_from.cc:448) is src_stride_y but should be dst_stride_y. This causes image corruption when converting I420 -> NV21 with mismatched luminance strides.

R=dhrosa@google.com, harryjin@google.com
BUG=libyuv:547

Review URL: https://codereview.chromium.org/1582793008 .

8377c798

14 Jan, 2016 2 commits

Roll chromium to fix java_cpp_enum.py · d1c6eb08

Frank Barchard authored Jan 14, 2016

Remove assumption on absolute paths in java_cpp_enum.py.

In java_cpp_enum.py there were assumptions on 'build' being
a component of the absolute path of the script invoking the
script. This leads to problems when other projects are using
the Chromium build toolchain (in this case libyuv), where
the script invoking GYP is located in the root of the project
dir (https://chromium.googlesource.com/libyuv/libyuv/+/master/gyp_libyuv).

TBR=harryjin@google.com, jkellander@chromium.org
BUG=libyuv:536

Review URL: https://codereview.chromium.org/1581773003 .

d1c6eb08

pull gflags.gyp changes from webrtc · f7c6b1a1

Frank Barchard authored Jan 14, 2016

gflags has a build warning in the chromium version.

../../third_party/gflags/src/gflags.cc:281:53: error: unused typedef 'true_false_equal' [-Werror,-Wunused-local-typedef]
    COMPILE_ASSERT(sizeof(kTrue) == sizeof(kFalse), true_false_equal);
                                                    ^
1 error generated.
[8/231] CXX obj/chromium/src/testing/gtest/src/gtest.gtest.o

Its been reported and fixed upstream
https://github.com/gflags/gflags/issues/125

But not pulled into chromium.  Last update to flags was in 2013.
This change disables the warning.

R=harryjin@google.com, kjellander@chromium.org, jkellander@chromium.org
BUG=libyuv:536, webrtc:5397, webrtc:5398, webrtc:5399

Review URL: https://codereview.chromium.org/1581123002 .

f7c6b1a1

13 Jan, 2016 1 commit
- refactor ARGBToI422 using ARGBToI420 internally · 081475b3
  Frank Barchard authored Jan 13, 2016
```
R=harryjin@google.com
BUG=libyuv:546

Review URL: https://codereview.chromium.org/1574253004 .
```
  081475b3
12 Jan, 2016 3 commits

Disable I420Blend_Any test that uses C · 54bbea17

Frank Barchard authored Jan 12, 2016

Also renames Inverted to Invert in test name for consistency.

TBR=harryjin@google.com
BUG=libyuv:543

Review URL: https://codereview.chromium.org/1577973004 .

54bbea17

Rename rotate tests to include _Opt and disable _Odd tests · 8030a711
Frank Barchard authored Jan 12, 2016
```
TBR=harryjin@google.com
BUG=libyuv:543

Review URL: https://codereview.chromium.org/1577723003 .
```
8030a711

Fix ifdef mismatch for mirroruv · 23c6a835

Frank Barchard authored Jan 12, 2016

Macro define and macro ifdef didnt match, leading to C code
being used.  Make macro match function name.

TBR=harryjin@google.com
BUG=libyuv:543

Review URL: https://codereview.chromium.org/1579023002 .

23c6a835

11 Jan, 2016 1 commit

Remove use_sysroot=0 · 0e462e6f

Frank Barchard authored Jan 11, 2016

use_sysroot=0 is required for webrtc on linux intel builds, but
libyuv doesnt use the affected libraries, so removing this.

R=harryjin@google.com, sbc@chromium.org
BUG=libyuv:534,libyuv:542

Review URL: https://codereview.chromium.org/1566303002 .

0e462e6f

06 Jan, 2016 1 commit

Odd width variation of scale down by 2 for subsampling · fc52d8de

Frank Barchard authored Jan 06, 2016

R=dhrosa@google.com, harryjin@google.com
BUG=libyuv:538

Review URL: https://codereview.chromium.org/1558093003 .

fc52d8de

05 Jan, 2016 1 commit

add clang variable for other apps to use · 2560df95

Frank Barchard authored Jan 05, 2016

R=dhrosa@google.com
BUG=libyuv:539

Review URL: https://codereview.chromium.org/1557923005 .

2560df95

22 Dec, 2015 3 commits

fix for InterpolateRow_AVX2 · 36615d62

Frank Barchard authored Dec 22, 2015

port scaledownby4_avx2 to gcc

TBR=harryjin@google.com
BUG=libyuv:492

Review URL: https://codereview.chromium.org/1546763002 .

36615d62

bug fix - remove shift from InterpolateRow_AVX2 · 71deb7ba
Frank Barchard authored Dec 22, 2015
```
TBR=harryjin@google.com
BUG=libyuv:537

Review URL: https://codereview.chromium.org/1547703002 .
```
71deb7ba

fix for InterpolateRow_AVX2 · 2cb2e9e1

Frank Barchard authored Dec 22, 2015

TBR=harryjin@google.com
BUG=libyuv:535

Review URL: https://codereview.chromium.org/1543773002 .

2cb2e9e1

21 Dec, 2015 2 commits

Disable sysroot for x86 and x64 only · 0f5c7660

Frank Barchard authored Dec 21, 2015

In addition to https://codereview.chromium.org/1526163002
disable sysroot only for x86 and x64.

Keep using sysroot for other archs
due to crosscompiling.

BUG=none
R=fbarchard@chromium.org

Review URL: https://codereview.chromium.org/1536403002 .

0f5c7660

avx2 interpolate use 8 bit · 3f4d8605

Frank Barchard authored Dec 21, 2015

BUG=libyuv:535
R=dhrosa@google.com

Review URL: https://codereview.chromium.org/1535833003 .

3f4d8605

17 Dec, 2015 3 commits

Add rounding to InterpolateRow for improved quality and consistency. · f4447745

Frank Barchard authored Dec 17, 2015

Remove inaccurate specializations for 1/4 and 3/4, since they round
incorrectly.  Specialize for 100% and 50% are kept due to performance.
Make C and ARM code match SSSE3.
Make unittests expect zero difference.

BUG=libyuv:535
R=harryjin@google.com

Review URL: https://codereview.chromium.org/1533643005 .

f4447745

use memory for loop counter to work around nearly out of registers · 1ccbf8fb
Frank Barchard authored Dec 17, 2015
```
TBR=harryjin@google.com
BUG=libyuv:533

Review URL: https://codereview.chromium.org/1535433003 .
```
1ccbf8fb

add NDEBUG for release chromium buids · 029f926a

Frank Barchard authored Dec 17, 2015

BUG=libyuv:533

TBR=harryjin@google.com

Review URL: https://codereview.chromium.org/1531143002 .

029f926a

16 Dec, 2015 3 commits

roll to same version of chromium as head webrtc · 40fd801a

Frank Barchard authored Dec 16, 2015

BUG=libyuv:534
R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/1535493002 .

40fd801a

Fix MIPS DSPR2 build failure. · 216e93b4

Frank Barchard authored Dec 16, 2015

Fixing the failure:
 'TransposeWx8_Fast_MIPS_DSPR2' was not declared in this scope

BUG=none
R=fbarchard@chromium.org

Review URL: https://codereview.chromium.org/1527243002 .

216e93b4

change scale down by 4 to use rounding. · 80ca4514

Frank Barchard authored Dec 16, 2015

TBR=harryjin@google.com
BUG=libyuv:447

Review URL: https://codereview.chromium.org/1525033005 .

80ca4514

15 Dec, 2015 4 commits

Bump chromium version and disable use_sysroot=0 · be984a8b
Frank Barchard authored Dec 15, 2015
```
TBR=harryjin@google.com
BUG=libyuv:534

Review URL: https://codereview.chromium.org/1526163002 .
```
be984a8b

avx2 scale down by 2 for gcc · 70445ef2

Frank Barchard authored Dec 15, 2015

R=dhrosa@google.com, harryjin@google.com
BUG=libyuv:527

Review URL: https://codereview.chromium.org/1520423003 .

70445ef2

disable I411ToARGB assembly if _DEBUG for chromium, as well as DEBUG for other builds. · 77346fcb
Frank Barchard authored Dec 15, 2015
```
TBR=harryjin@google.com
BUG=libyuv:533

Review URL: https://codereview.chromium.org/1527903002 .
```
77346fcb

use rounding in scaledown by 2 · ae55e418

Frank Barchard authored Dec 15, 2015

When scaling down by 2 the formula should round consistently.
(a+b+c+d+2)/4
The C version did but the SSE2 version was doing 2 averages.
avg(avg(a,b),avg(c,d))
This change uses a sum, then rounds.

R=dhrosa@google.com, harryjin@google.com
BUG=libyuv:447,libyuv:527

Review URL: https://codereview.chromium.org/1513183004 .

ae55e418

14 Dec, 2015 1 commit
- GN: Fix neon files not being included for arm64 · 71b60123
  Frank Barchard authored Dec 14, 2015
```
BUG=568883
R=fbarchard@chromium.org

Review URL: https://codereview.chromium.org/1516653004 .
```
  71b60123
11 Dec, 2015 2 commits

remove unused var in a test · 8bca9fc1

Frank Barchard authored Dec 11, 2015

remove include from unittest.cc that is already done by unittest.h

TBR=harryjin@google.com
BUG=libyuv:530

Review URL: https://codereview.chromium.org/1513263004 .

8bca9fc1

rollback to old chromium dependencies · 5c5cecb4

Frank Barchard authored Dec 11, 2015

include paths break for gtest

TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1517123002 .

5c5cecb4