- 15 Aug, 2017 1 commit
-
-
Henrik Kjellander authored
This change broke libyuv's presubmit: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e79ddeaabf246769937282f952897bcec3e9de05%5E%21/ GClientKeywords has been removed and replaced with a more direct substitution. This is similar to https://codereview.webrtc.org/2989603002 BUG=None NOTRY=True TBR=fbarchard@google.com Change-Id: I5cb1c18bc72ac1354d5d69f3c9f93cc61841c409 Reviewed-on: https://chromium-review.googlesource.com/615161Reviewed-by: Henrik Kjellander <kjellander@chromium.org> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
-
- 14 Aug, 2017 2 commits
-
-
Frank Barchard authored
add ScaleMaxSamples_NEON function with max done on original values. TBR=kjellander@chromium.org BUG=libyuv:717 TEST=LibYUVPlanarTest.TestScaleMaxSamples_Opt Change-Id: Id99338860782b10ffd24f66242eb42014c2e229e Reviewed-on: https://chromium-review.googlesource.com/614685Reviewed-by: Frank Barchard <fbarchard@google.com> Reviewed-by: Cheng Wang <wangcheng@google.com>
-
Manojkumar Bhosale authored
TBR=kjellander@chromium.org R=fbarchard@google.com Bug:libyuv:634 Change-Id: I17bd3f87336f613ad363af7d7b9d7af49d725e56 Reviewed-on: https://chromium-review.googlesource.com/613100Reviewed-by: Frank Barchard <fbarchard@google.com>
-
- 09 Aug, 2017 1 commit
-
-
Frank Barchard authored
TBR=kjellander@chromium.org BUG=libyuv:717 TEST=LibYUVPlanarTest.TestScaleSumSamples_Opt Change-Id: I5208666f3968c5c4b0f1b0c951f24216d78ee3fe Reviewed-on: https://chromium-review.googlesource.com/607184Reviewed-by: Cheng Wang <wangcheng@google.com>
-
- 04 Aug, 2017 1 commit
-
-
Frank Barchard authored
BUG=libyuv:717 TEST=ScaleSum unittest to compare C vs Arm implementation TBR=kjellander@chromium.org Change-Id: Iaa7af5547d979aad4722f868d31b405340115748 Reviewed-on: https://chromium-review.googlesource.com/600534Reviewed-by: Cheng Wang <wangcheng@google.com>
-
- 03 Aug, 2017 2 commits
-
-
Frank Barchard authored
This reverts commit 1dda4cb0. Reason for revert: build error on jpeg FILE Original change's description: > include <new> header for benefit of new clang builds > > TBR=kjellander@chromium.org > BUG=libyuv:712 > TEST=local builds still work > > Change-Id: I040e8edc40aafd820d2a29629fe7aec5c049bc6b > Reviewed-on: https://chromium-review.googlesource.com/576971 > Reviewed-by: Frank Barchard <fbarchard@google.com> > Commit-Queue: Frank Barchard <fbarchard@google.com> TBR=kjellander@chromium.org,fbarchard@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: libyuv:712 Change-Id: I4cf4e26eadb476017dc95e6c9578092204f088a3 Reviewed-on: https://chromium-review.googlesource.com/601211 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by: Frank Barchard <fbarchard@google.com>
-
Frank Barchard authored
R=kjellander@chromium.org Bug: libyuv:715 Test: gn gen out/Release "--args=is_debug=false target_os=\"android\" target_cpu=\"mips64el\" mips_arch_variant=\"r6\" mips_use_msa=true is_component_build=true is_clang=true" Change-Id: Ia3943b0afc02e05a8bc32350719b296b0b9d5479 Reviewed-on: https://chromium-review.googlesource.com/592720Reviewed-by: Cheng Wang <wangcheng@google.com>
-
- 02 Aug, 2017 1 commit
-
-
Frank Barchard authored
Take change from webrtc into libyuv autoroll BUG=libyuv:716 TEST=tools_libyuv/autoroller/roll_deps.py TBR=kjellander@chromium.org Change-Id: I81b1eed114b982e336f2e209d7d825094e584295 Reviewed-on: https://chromium-review.googlesource.com/596472Reviewed-by: Frank Barchard <fbarchard@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
- 26 Jul, 2017 1 commit
-
-
Henrik Kjellander authored
BUG=libyuv:710 NOTRY=True Change-Id: I47c80980a6ed8bcfc247e75f3936f028576a6c5a Reviewed-on: https://chromium-review.googlesource.com/584846Reviewed-by: Frank Barchard <fbarchard@google.com> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
-
- 25 Jul, 2017 2 commits
-
-
Nico Weber authored
In cross builds of chrome/win, the host and target toolchains currently have the same name. To fix this, rename clang_x64 to win_clang_x64. Because the toolchain name is also referenced in libyuv, this requires a five-sided change: 1. Introduce variable containing the toolchain name in src.git 2. Change libyuv to refer to the variable 3. Rename toolchain in src.git (including in the newly introduced var) 4* Let libyuv refer to the new name directly 5. Remove variable again (See also https://codereview.chromium.org/2463143002) Bug: 748501 Change-Id: I89fdf1503f1a57992a8336026d4c8d767685d53f Reviewed-on: https://chromium-review.googlesource.com/585306 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org>
-
Nico Weber authored
In cross builds of chrome/win, the host and target toolchains currently have the same name. To fix this, rename clang_x64 to win_clang_x64. Because the toolchain name is also referenced in libyuv, this requires a five-sided change: 1. Introduce variable containing the toolchain name in src.git 2* Change libyuv to refer to the variable 3. Rename toolchain in src.git (including in the newly introduced var) 4. Let libyuv refer to the new name directly 5. Remove variable again (See also https://codereview.chromium.org/2463143002) TBR=fbarchard Bug: 748501 Change-Id: Id8398ab5c4615c7c33dfa5ec793fdc8c0a717e57 Reviewed-on: https://chromium-review.googlesource.com/585307Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Frank Barchard <fbarchard@google.com>
-
- 21 Jul, 2017 2 commits
-
-
Frank Barchard authored
Change log: https://chromium.googlesource.com/chromium/src/+log/c138801d02..da6245e7c4 Full diff: https://chromium.googlesource.com/chromium/src/+/c138801d02..da6245e7c4 Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/5b2c419308..8c06e7a9f6 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/1808a907ce..e3c0667f11 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/bff0ead181..e5a58b0b43 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/aac324832e..ebf1c4622e * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/1b11b0e214..d58cf433a5 * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b0acf6c12b..9629af7533 * src/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu.git/+log/dfa798fe69..1fec0c83e9 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/ec8ceaef71..1397f0ed8b * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/eb296f67da..d61a9397e6 DEPS diff: https://chromium.googlesource.com/chromium/src/+/c138801d02..da6245e7c4/DEPS No update to Clang. TBR=kjellander@chromium.org BUG=libyuv:710 TEST=linux and android builds work locally Change-Id: I6ea35abb7c85c08dec1648dd12041d6ed994b04c Reviewed-on: https://chromium-review.googlesource.com/582307Reviewed-by: Frank Barchard <fbarchard@google.com>
-
Frank Barchard authored
TBR=kjellander@chromium.org BUG=None TEST=make -f linux.mk Change-Id: I747c2eb6ed03cacddf3265e65088472507f3436c Reviewed-on: https://chromium-review.googlesource.com/581874 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by: Frank Barchard <fbarchard@google.com>
-
- 20 Jul, 2017 2 commits
-
-
Frank Barchard authored
The same overrides now live in .gn. TBR=kjellander@chromium.org Bug:chromium:669240 Change-Id: Ifaeb3b612571c3594f1e2279b4f871b7fd3e8d69 Reviewed-on: https://chromium-review.googlesource.com/572080Reviewed-by: Frank Barchard <fbarchard@google.com>
-
Frank Barchard authored
TBR=kjellander@chromium.org BUG=libyuv:712 TEST=libyuv try bots build Change-Id: Ibe2ff9ac557d5086566941d93f71d1b8048dfb58 Reviewed-on: https://chromium-review.googlesource.com/579663Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Frank Barchard <fbarchard@google.com>
-
- 19 Jul, 2017 2 commits
-
-
Frank Barchard authored
Change log: https://chromium.googlesource.com/chromium/src/+log/964fc7fe50..c138801d02 Full diff: https://chromium.googlesource.com/chromium/src/+/964fc7fe50..c138801d02 Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/7830ef61f5..5b2c419308 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/b887a61b49..1808a907ce * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/b53a03df32..5ad14542a6 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/4243f190b3..bff0ead181 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/4d1ed658b7..aac324832e * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/d09084e5dd..1b11b0e214 * src/third_party/android_tools: https://chromium.googlesource.com/android_tools.git/+log/023e2f6540..e9d4018e14 * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7ba431f75d..b0acf6c12b * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/b8af3bf606..ec8ceaef71 * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/af6b06ca68..a56c2b39ca DEPS diff: https://chromium.googlesource.com/chromium/src/+/964fc7fe50..c138801d02/DEPS Clang version changed 303910:307486 Details: https://chromium.googlesource.com/chromium/src/+/964fc7fe50..c138801d02/tools/clang/scripts/update.py TBR=kjellander@chromium.org BUG=libyuv:710, chromium:669240 Change-Id: I117311a0fe61c3bdbf3a966ec2eb55100added51 Reviewed-on: https://chromium-review.googlesource.com/574772Reviewed-by: Frank Barchard <fbarchard@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
Frank Barchard authored
TBR=kjellander@chromium.org BUG=libyuv:712 TEST=local builds still work Change-Id: I040e8edc40aafd820d2a29629fe7aec5c049bc6b Reviewed-on: https://chromium-review.googlesource.com/576971Reviewed-by: Frank Barchard <fbarchard@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
- 13 Jul, 2017 1 commit
-
-
Frank Barchard authored
Currently, libyuv is setting this config via mac_sdk_min_build_override. The old meechanism is deprecated, but cannot be removed until chromium is updated to no longer require mac_sdk_min_build_override. TBR=kjellander@chromium.org Bug:chromium:740693 Change-Id: I71533c9ef20ac8d7584d50751ac5437da54e2cb5 Reviewed-on: https://chromium-review.googlesource.com/565636Reviewed-by: Frank Barchard <fbarchard@google.com>
-
- 19 Jun, 2017 1 commit
-
-
Frank Barchard authored
BUG=None TEST=LibYUVCompareTest.* R=jkellander@chromium.org Change-Id: I3131ca73020f855ead08255d09aa7a846bf0d556 Reviewed-on: https://chromium-review.googlesource.com/540064 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
-
- 13 Jun, 2017 1 commit
-
-
Henrik Kjellander authored
Manual changes: * Add new third_party/googletest (replaces testing/gtest and testing/gmock). * Add Android deps third_party/ub-uiautomator and xstream. * Remove the no longer existing clang_format_merge_driver * Java 8 had to be installed on the Android builder machines (crbug.com/732529). Change log: https://chromium.googlesource.com/chromium/src/+log/ce95e5d83f..964fc7fe50 Full diff: https://chromium.googlesource.com/chromium/src/+/ce95e5d83f..964fc7fe50 Changed dependencies: * src/base: https://chromium.googlesource.com/chromium/src/base/+log/f6489f4fd2..7830ef61f5 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/bca1cbe2aa..b887a61b49 * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/88811f48a6..b53a03df32 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/9595ed7ed6..4243f190b3 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/7b3e681f96..4d1ed658b7 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/b28b3325f9..d09084e5dd * src/third_party/android_tools: https://chromium.googlesource.com/android_tools.git/+log/b65c4776da..023e2f6540 * src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e8775f0f64..7ba431f75d * src/third_party/ced/src: https://chromium.googlesource.com/external/github.com/google/compact_enc_det.git/+log/e21eb6aed1..910cca22d8 * src/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu.git/+log/b34251f8b7..dfa798fe69 * src/third_party/libjpeg_turbo: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/7260e4d8b8..a1750dbc79 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/5c327d115e..b8af3bf606 * src/tools/swarming_client: https://chromium.googlesource.com/external/swarming.client.git/+log/11e31afa5d..af6b06ca68 DEPS diff: https://chromium.googlesource.com/chromium/src/+/ce95e5d83f..964fc7fe50/DEPS Clang version changed 299960:303910 Details: https://chromium.googlesource.com/chromium/src/+/ce95e5d83f..964fc7fe50/tools/clang/scripts/update.py TBR= BUG=None Change-Id: I84a5108a48d7cddb71df886cd9cb7e7ed21648ef Reviewed-on: https://chromium-review.googlesource.com/532013 Commit-Queue: Henrik Kjellander <kjellander@chromium.org> Reviewed-by: Frank Barchard <fbarchard@google.com>
-
- 09 Jun, 2017 2 commits
-
-
Frank Barchard authored
NaCL has been disabled for awhile, so the code will still build, but only with C versions. This change removes the MEMACCESS() macros from Neon and Neon64 source. BUG=libyuv:702 TEST=try bots build for arm. R=kjellander@chromium.org Change-Id: Id581a5c8ff71e18cc69595e7fee9337f97c44a19 Reviewed-on: https://chromium-review.googlesource.com/528332Reviewed-by: Cheng Wang <wangcheng@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
Frank Barchard authored
instead of casting int to int64, pass the int and use %w modifier to use the word version of the register. TBR=kjellander@chromium.org BUG=libyuv:706 TEST=git cl lint R=wangcheng@google.com Change-Id: Iee5a70f04d928903ca8efac00066b8821a465e36 Reviewed-on: https://chromium-review.googlesource.com/528381Reviewed-by: Cheng Wang <wangcheng@google.com> Reviewed-by: Frank Barchard <fbarchard@google.com>
-
- 07 Jun, 2017 3 commits
-
-
Frank Barchard authored
Summing 16 bit hamming codes restricts the maximum length, but saves an inner loop instruction. The outer loop can sum the values. 32 bit Neon Now BenchmarkHammingDistance_Opt (78 ms) Was BenchmarkHammingDistance_Opt (92 ms) 64 bit Neon Now BenchmarkHammingDistance_Opt (85 ms) Was BenchmarkHammingDistance_Opt (92 ms) R=wangcheng@google.com TBR=kjellander@chromium.org BUG=libyuv:701 TEST=BenchmarkHammingDistance Change-Id: Ie40f0eac2f3339c33b833b42af5d394b122066ae Reviewed-on: https://chromium-review.googlesource.com/526932Reviewed-by: Frank Barchard <fbarchard@google.com> Reviewed-by: Cheng Wang <wangcheng@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
Frank Barchard authored
The 32 bit version of HammingDistance_NEON accumulates using vertical add and paired adds, which takes 3 instructions instead of 4. The instructions are also portable between 32 and 64 bit. Was BenchmarkHammingDistance_Opt (105 ms) Now BenchmarkHammingDistance_Opt (90 ms) TBR=kjellander@chromium.org BUG=libyuv:701 TEST=BenchmarkHammingDistance BenchmarkHammingDistance_Opt (90 ms) Change-Id: If9e621e0bd2fe2492a1532056f8a1b451ba53d7e Reviewed-on: https://chromium-review.googlesource.com/526365Reviewed-by: Frank Barchard <fbarchard@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
Frank Barchard authored
BenchmarkHammingDistance_Opt (93 ms) BenchmarkHammingDistance_C (389 ms) TBR=kjellander@chromium.org BUG=libyuv:701 TEST=BenchmarkHammingDistance Change-Id: I4ba920751eb130cac6a276e441a7c309c495554a Reviewed-on: https://chromium-review.googlesource.com/526401Reviewed-by: Frank Barchard <fbarchard@google.com> Reviewed-by: Cheng Wang <wangcheng@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
- 06 Jun, 2017 2 commits
-
-
Frank Barchard authored
TBR=kjellander@chromium.org BUG=libyuv:701 TEST=BenchmarkHammingDistance Change-Id: I252efd8a27aa11a0fe7d8030d7c8b57f20f04760 Reviewed-on: https://chromium-review.googlesource.com/525232Reviewed-by: Frank Barchard <fbarchard@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
Frank Barchard authored
existing test passes out/Release/libyuv_unittest --gtest_filter=*Blend* --libyuv_width=33 --libyuv_height=16 new test added BUG=libyuv:705 TEST=LibYUVScaleTest.TestScaleOdd Change-Id: Ica91812aee2e4ed9bcc18df4962b089c2e4ae704 Reviewed-on: https://chromium-review.googlesource.com/524932Reviewed-by: Cheng Wang <wangcheng@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
- 01 Jun, 2017 1 commit
-
-
Henrik Kjellander authored
BUG=None TBR=fbarchard@chromium.org Change-Id: Id665a052c0f164ca58ee317ff2cb065c6a67da77 Reviewed-on: https://chromium-review.googlesource.com/521523Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
-
- 25 May, 2017 2 commits
-
-
Frank Barchard authored
The CpuId function is a wrapper for the intrinsic, or implemented with inline if unavailable. It had been using uint32, but the intrinsics use int, so it was causing casting and lint warnings. This change makes the internal implementation use int. Casting was also done for xgetbv, and the cast is simply removed, and is not causing a build error. MipCpuCaps was doing strlen to check for white space after the instruction set. Arm also does this but with a hard coded offset. This was causing a cast from size_t to int, which produced a lint warning. The change removes the white space detect. In theory the code could be used to detect SSE vs SSE2, and it would need to check SSE is followed by a space or end of line. But this code is only used on Arm and Mips, where there there is one form of SIMD detected. e.g. MSA for mips. If a new instruction set is added with a similar name, the write space check could be reintroduced. But its more likely the code can be rewritten to use a better form of detection by then. Or remove detection and require the instructions BUG=libyuv:641 TEST=try bots build on all platforms without error and lint is clean Change-Id: I9f55f8e57bba0f78571bdddbe63b945dea3e8809 Reviewed-on: https://chromium-review.googlesource.com/514524 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by: Cheng Wang <wangcheng@google.com> Reviewed-by: Wan-Teh Chang <wtc@chromium.org>
-
Henrik Kjellander authored
In https://chromium-review.googlesource.com/c/509693/ the From keyword was removed. This update the script to match that (we also were no longer using it). BUG=libyuv:704 NOTRY=True Change-Id: Iccbbfb426a3acd986fbc036672fb51abc2c5d346 Reviewed-on: https://chromium-review.googlesource.com/513908Reviewed-by: Frank Barchard <fbarchard@google.com> Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
-
- 24 May, 2017 2 commits
-
-
Frank Barchard authored
Reduce number of atomic references to cpu_info by making InitCpuFlags call MaskCpuFlags and return the same value. BUG=libyuv:641 TEST=libyuv_unittests pass Change-Id: I5dfff8f7a10671bc8ef3ec0ed6f302791e752faa Reviewed-on: https://chromium-review.googlesource.com/514145 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by: Cheng Wang <wangcheng@google.com>
-
Frank Barchard authored
Detect the compiler's support of C11 atomics, and use C11 atomics when available. Note that libyuv::MaskCpuFlags() is still not thread-safe. BUG=libyuv:641 TEST= cpu_thread_test.cc adds a pthread based test R=wangcheng@google.com Change-Id: If05b1e16da833105a0159ed67ef20f4e61bc7abd Reviewed-on: https://chromium-review.googlesource.com/510079 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by: Cheng Wang <wangcheng@google.com>
-
- 12 May, 2017 2 commits
-
-
Frank Barchard authored
BUG=libyuv:701 TEST=HammingDistance unittest performance is comparable to x64 R=wangcheng@google.com Change-Id: I8abe861e086e0162ba4c7ba6f1ef7d1c006cd9d4 Reviewed-on: https://chromium-review.googlesource.com/505454Reviewed-by: Frank Barchard <fbarchard@google.com> Commit-Queue: Frank Barchard <fbarchard@google.com>
-
Frank Barchard authored
BUG=libyuv:701 TEST=LibYUVBaseTest.BenchmarkHammingDistance_C R=wangcheng@google.com Change-Id: I243003b098bea8ef3809298bbec349ed52a43d8c Reviewed-on: https://chromium-review.googlesource.com/499487Reviewed-by: Cheng Wang <wangcheng@google.com>
-
- 09 May, 2017 1 commit
-
-
Frank Barchard authored
BUG=libyuv:703 TEST=compile and disassemble. see registers used not stack. R=wangcheng@google.com Change-Id: Iaa07ee5d0c35252994491bb2868276e161149efd Reviewed-on: https://chromium-review.googlesource.com/500427 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by: Cheng Wang <wangcheng@google.com>
-
- 08 May, 2017 1 commit
-
-
Frank Barchard authored
BUG=libyuv:701 TEST=built and disassembled for aarch64 R=kjellander@chromium.org Change-Id: I7712b1c7934e5dfb55fda1fa7c8405c32d6964ce Reviewed-on: https://chromium-review.googlesource.com/495327Reviewed-by: Henrik Kjellander <kjellander@chromium.org> Reviewed-by: Cheng Wang <wangcheng@google.com>
-
- 02 May, 2017 1 commit
-
-
Frank Barchard authored
The verion of clang in ndk r14 (3.9) has a built in llvm assembler that does not have the sgtu pseudo instruction. sltu is the actual instruction, so switch the 2 operands and use the instruction instead of the pseudo op. BUG=libyuv:700 TEST=try bots build mips without error. Change-Id: I2d5f94f81acbd56cdedea011e7d9308979e19079 Reviewed-on: https://chromium-review.googlesource.com/494026Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
-
- 26 Apr, 2017 1 commit
-
-
Vignesh Venkatasubramanian authored
Revert the workaround and fix it properly by passing the additional necessary flag to the compiler. BUG=libyuv:700 Change-Id: I1c893a8acb5079decbee6963b689424bf2f99f4f Reviewed-on: https://chromium-review.googlesource.com/487881Reviewed-by: Frank Barchard <fbarchard@google.com>
-
- 25 Apr, 2017 1 commit
-
-
Frank Barchard authored
CopyRow_MIPS produces a compile error on some compilers. TBR=kjellander@chromium.org BUG=libyuv:700 TEST=try bots Change-Id: Ie88f2006ef5cf14bffaf80fd4c0dd1caa409c569 Reviewed-on: https://chromium-review.googlesource.com/486127Reviewed-by: Frank Barchard <fbarchard@google.com>
-
- 20 Apr, 2017 1 commit
-
-
Bruce Dawson authored
When libyuv was changed to compile with clang-cl this also cause libjpeg to be compiled with clang-cl, which means that it was being compiled twice. This is generally a bad practice, it was causing duplicate symbol warnings in some builds, and it slows builds slightly. This change reduces the number of build steps with the default gn settings on Win64 builds by 71 (currently from 47,200 to 47,129). See this change that change libyuv's compilation: https://chromium-review.googlesource.com/c/446667/ BUG=706627 Change-Id: I13e2d4ff8511350901af10f7443f3f4b89cc2499 Reviewed-on: https://chromium-review.googlesource.com/456651Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Henrik Kjellander <kjellander@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-