- 12 Jul, 2016 1 commit
-
-
Frank Barchard authored
to Y,U,V and a pixel stride for U and V. The pixel stride is expected to be 1 or 2. TEST=LibYUVConvertTest.Android420ToI420_Opt BUG=libyuv:604 R=braveyao@chromium.org Review URL: https://codereview.chromium.org/2114843002 .
-
- 11 Jul, 2016 1 commit
-
-
Frank Barchard authored
webrtc doesnt include the headers that the functions are prototyped in. This CL makes the convert.h include those headers to allow webrtc to update to the head libyuv. TBR=harryjin@google.com BUG=libyuv:620,webrtc:6091,webrtc:6094 TESTED=local build and try bots Review URL: https://codereview.chromium.org/2141683002 .
-
- 08 Jul, 2016 1 commit
-
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:618 Review URL: https://codereview.chromium.org/2132993003 .
-
- 07 Jul, 2016 1 commit
-
-
Frank Barchard authored
previously gyp enabled 'chromium_code': 1, for stricter warnings, but GN disabled warnings: configs -= [ "//build/config/compiler:chromium_code" ] configs += [ "//build/config/compiler:no_chromium_code" ] This CL enables strict warnings for GN as well as GYP. R=rsesek@chromium.org BUG=libyuv:617 Review URL: https://codereview.chromium.org/2130583003 .
-
- 06 Jul, 2016 2 commits
-
-
Frank Barchard authored
-lc++ can cause link error on some systems and is not necessary on gcc 4.6+ so remove the link option and document how to build for gcc 4.4 TEST=CC=gcc-4.4 CXXFLAGS=-fno-exceptions CXX=g++-4.4 make -f linux.mk clean all BUG=libyuv:616 Review URL: https://codereview.chromium.org/2126703003 .
-
Frank Barchard authored
Mking color conversion use simple arrays within structure, which will be referenced via register pointer. R=harryjin@google.com BUG=libyuv:616 TEST=CC=gcc-4.4 CXX=g++-4.4 LD=ld-4.4 make -f linux.mk Review URL: https://codereview.chromium.org/2127863003 .
-
- 28 Jun, 2016 1 commit
-
-
Frank Barchard authored
The old guard only checked for defined(_M_X64) which is defined by mingw64. Add a test for defined(_MSC_VER) which is defined for clangcl and visual c but not mingw. mingw should use row_gcc.cc for both 32 and 64 bit. R=harryjin@google.com BUG=webm:1252,libyuv:613 TEST=local gcc/clang builds on linux tested and try bots for others. Review URL: https://codereview.chromium.org/2105603002 .
-
- 24 Jun, 2016 4 commits
-
-
Frank Barchard authored
R=wangcheng@google.com, harryjin@google.com BUG=libyuv:607 Review URL: https://codereview.chromium.org/2093913004 .
-
Frank Barchard authored
32 bit clang runs out of registers and compiler does core dump. force 32 bit build to use memory variable for counter. BUG=libyuv:612 TBR=harryjin@google.com Review URL: https://codereview.chromium.org/2091913003 .
-
Frank Barchard authored
upscale a YUV image. observe change in hue.. green especially. disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C observe hue.. green especially, is better. was ScaleFrom1280x720_Bilinear (1620 ms) now ScaleFrom1280x720_Bilinear (1907 ms) BUG=libyuv:605 TEST=try bots R=harryjin@google.com, wangcheng@google.com Review URL: https://codereview.chromium.org/2084533006 .
-
Frank Barchard authored
the ScaleFilterCols_SSSE3 function fails at runtime if vectorsize is not used. BUG=libyuv:610,libyuv:605 R=wangcheng@google.com Review URL: https://codereview.chromium.org/2080223007 .
-
- 20 Jun, 2016 1 commit
-
-
Frank Barchard authored
upscale a YUV image. observe change in hue.. green especially. disable ScaleFilterCols_SSSE3, falling back on ScaleFilterCols_C observe hue.. green especially, is better. disable HAS_SCALEFILTERCOLS_SSSE3 R=harryjin@google.com BUG=libyuv:605 Review URL: https://codereview.chromium.org/2080663003 .
-
- 17 Jun, 2016 1 commit
-
-
Henrik Kjellander authored
All these seem to be green but doesn't run by default. TBR=fbarchard@chromium.org Review URL: https://codereview.chromium.org/2064343002 .
-
- 16 Jun, 2016 1 commit
-
-
Niels Möller authored
BUG= R=fbarchard@google.com Review URL: https://codereview.chromium.org/2020193002 .
-
- 14 Jun, 2016 1 commit
-
-
Frank Barchard authored
Work around for android full debug build runnign out of registers. 5 functions were running out of registers causing the compiler error error: 'asm' operand has impossible constraints These functions mostly have 4 pointers, a counter (width) and a tempory eax register. With fpic and debug using stackframes, 2 registers are unavailable. So a total of 8 registers are used. Although fpic and stack frame dont apply to assembly, the compiler reserves 2 registers. The optimized version builds, so its likely freeing up the registers once it knows they are not used. These functions used to build, so compile options and/or compiler may have updated.. likely fpic was turned on. An attribute can be done to disable each, and will avoid using the 2 GPR registers, but they are still reserved and unavailable in debug builds on current compilers (gcc 4.9 and clang 3.8). R=dhrosa@google.com BUG=libyuv:602 Review URL: https://codereview.chromium.org/2066933002 .
-
- 08 Jun, 2016 2 commits
-
-
Frank Barchard authored
cpu_info_ is zero for uninitialized state and all bits are off, disabling all cpu optimizations. the 1 bit indicates cpu_info_ is initialized avoiding calling the detection code again for performance. MaskCpuFlags initializes the cpu ignoring existing flags, then masks with the supplied flags and stores to cpu_info_. As a mask, -1 has no effect, enabling all cpu features that were detected, but nothing that wasnt detected. Setting to 0 will cause the next call to re-initialize the cpu, which is same as enabling all features. Setting mask to 1 will turn off all cpu features but keep the initialized bit on, so the next detection call wont reinitialize and the cpu features are all disabled. So normal behavior for command line and programatic masking is: 1 = C -1 = SIMD TBR=harryjin@google.com BUG=libyuv:600 TESTED=out64/Release/bin/run_libyuv_unittest -s libyuv_unittest --verbose --release --gtest_filter=*ARGBExtractAlpha* -a "--libyuv_width=1280 --libyuv_height=720 --libyuv_repeat=9999 --libyuv_flags=1 --libyuv_cpu_info=1" Review URL: https://codereview.chromium.org/2042933002 .
-
Frank Barchard authored
width %w size modifier the int width can be passed directly to arm assembly. For functions that take input constants, the outputs are declared as early write using &, meaning the outputs use used before all inputs are consumed. R=harryjin@google.com BUG=libyuv:598 Review URL: https://codereview.chromium.org/2043073003 .
-
- 07 Jun, 2016 2 commits
-
-
Frank Barchard authored
ifdefs on a function level are not needed for neon functions, unless they are conditionally enabled in row.h. No functions are conditionally enabled at this time, so all ifdefs can be removed from row_neon.cc and row_neon64.cc TBR=kjellander@chromium.org BUG=libyuv:599 Review URL: https://codereview.chromium.org/2044223002 .
-
Frank Barchard authored
arm64 8 TestARGBExtractAlpha (10019 ms) <-original 64 bit code arm64 8 x2 TestARGBExtractAlpha (7639 ms) arm64 16 TestARGBExtractAlpha (7369 ms) <- new 64 bit code thumb32 8 TestARGBExtractAlpha (9505 ms) <- original 32 bit code thumb32 8 x2 TestARGBExtractAlpha (7400 ms) thumb32 8 x2i TestARGBExtractAlpha (7266 ms) <- new 32 bit code arm32 8 TestARGBExtractAlpha (10002 ms) BUG=libyuv:572 TESTED=local test on nexus 9 R=harryjin@google.com, wangcheng@google.com Review URL: https://codereview.chromium.org/2035573002 .
-
- 01 Jun, 2016 1 commit
-
-
Frank Barchard authored
R=harryjin@google.com BUG=libyuv:597 Review URL: https://codereview.chromium.org/2024213003 .
-
- 28 May, 2016 1 commit
-
-
Frank Barchard authored
blur requires memory be aligned. change the unittest allocator to guarantee 64 byte alignment. re-enable blur any test that fails if memory is unaligned. TBR=harryjin@google.com BUG=libyuv:596,libyuv:594 TESTED=local build passes with row.h removed from tests. Review URL: https://codereview.chromium.org/2019753002 .
-
- 27 May, 2016 1 commit
-
-
Frank Barchard authored
add SIMD_ALIGNED to unittest header. BUG=libyuv:594 TESTED=local build passes with row.h removed from tests. R=harryjin@google.com Review URL: https://codereview.chromium.org/2001373002 .
-
- 26 May, 2016 1 commit
-
-
Magnus Jedvert authored
BUG=libyuv:572 R=fbarchard@google.com Review URL: https://codereview.chromium.org/1995293002 .
-
- 24 May, 2016 5 commits
-
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:595 TESTED=local unittest passes on try bots Review URL: https://codereview.chromium.org/2012603002 .
-
Frank Barchard authored
TBR=kjellander@chromium.org BUG=None Review URL: https://codereview.chromium.org/2005053004 .
-
Frank Barchard authored
avoids need for row.h for some unittests; R=harryjin@google.com BUG=libyuv:594 TESTED=try bots tested. Review URL: https://codereview.chromium.org/2004313004 .
-
Henrik Kjellander authored
* Update gflags to newer repository location (plain copy from the files in WebRTC). * Add workarounds for mojo dependency (see http://bugs.webrtc.org/5629 for more details). * Update libyuv_unittest to generate user friendly run-scripts for Android in out/{Debug,Release}/bin * Fix Android test execution by adding explicit dependency on Chromium's base/base.gyp:base_build_config_gen This roll also solves the compile problem for Mac ASan bots. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca7f86..2a818f5413 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca7f86..2a818f5413 R=magjed@chromium.org TBR=fbarchard@chromium.org Review URL: https://codereview.chromium.org/2001173003 .
-
Frank Barchard authored
R=harryjin@google.com BUG=libyuv:592 TESTED=local builds work with fewer headers Review URL: https://codereview.chromium.org/2006943002 .
-
- 23 May, 2016 1 commit
-
-
Frank Barchard authored
TBR=kjellander@chromium.org BUG=libyuv:593 TESTED=try bots pass. Review URL: https://codereview.chromium.org/2000393002 .
-
- 17 May, 2016 1 commit
-
-
Niels Möller authored
BUG=webrtc:5006 R=kjellander@chromium.org, magjed@chromium.org Review URL: https://codereview.chromium.org/1981883002 .
-
- 06 May, 2016 1 commit
-
-
Frank Barchard authored
If image sizes are greater than 32768, fixed point stepping will overflow an int. This CL changes the max size to 32768 and disables the test if larger. BUG=libyuv:590 TESTED=LIBYUV_FLAGS=-1 LIBYUV_WIDTH=8192 LIBYUV_HEIGHT=16 out/Release/libyuv_unittest --gtest_filter=* R=harryjin@google.com Review URL: https://codereview.chromium.org/1947783002 .
-
- 20 Apr, 2016 1 commit
-
-
Frank Barchard authored
Allows arm and mips linux builds. Add psnr and cpuid utility targets. BUG=libyuv:586 TESTED=make -f linux.mk TBR=kjellander@chromium.org Review URL: https://codereview.chromium.org/1906653003 .
-
- 18 Apr, 2016 1 commit
-
-
Frank Barchard authored
Inline that uses temporary variables is currently initializing them to 0 and passing in as output "+r". This CL replaces the output constraint to "=&r" for most meaning an output with early write (before inputs). This allows the initialize to zero step to be removed, saving 1 instruction. BUG=libyuv:580 TESTED=local libyuv build on gcc/linux and try bots R=harryjin@google.com Review URL: https://codereview.chromium.org/1895743008 .
-
- 13 Apr, 2016 1 commit
-
-
Frank Barchard authored
roll chromium_revision for libyuv to pick up jpeg gyp change for NaCL. new jpeg allows nacl generate without Duse_system_yasm=0 BUG=libyuv:581 TESTED=local nacl build. R=kjellander@chromium.org Review URL: https://codereview.chromium.org/1882303002 .
-
- 12 Apr, 2016 1 commit
-
-
Henrik Kjellander authored
This requires you don't have target_os=["ios"] set in your libyuv root .gclient file, since that will make native_client not being downloaded due to https://code.google.com/p/chromium/codesearch#chromium/src/DEPS&l=357 BUG=libyuv:573 TESTED= rm chromium/.last_sync_chromium rm chromium/.gclient.tmp_entries gclient sync native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0 -Duse_system_yasm=0 ninja -C out/Debug Review URL: https://codereview.chromium.org/1845003004 .
-
- 11 Apr, 2016 3 commits
-
-
Frank Barchard authored
BUG=libyuv:578 TESTED=local unittests pass R=harryjin@google.com Review URL: https://codereview.chromium.org/1879783002 .
-
Henrik Kjellander authored
BUG=601140 TBR=fbarchard@chromium.org Review URL: https://codereview.chromium.org/1878763002 .
-
Frank Barchard authored
normally this warning is disabled but for nacl builds that use clang its not. this CL makes the option universally disabled for all clang based builds. BUG=libyuv:581 TESTED=native_client/build/gyp_nacl all.gyp -Dgtest_target_type=executable -Dmsan=0 & ninja -C out/Debug libyuv R=kjellander@chromium.org Review URL: https://codereview.chromium.org/1865183002 .
-
- 08 Apr, 2016 2 commits
-
-
Frank Barchard authored
When using C version of I420Interpolate for msan, a 50% interpolation would cause stride to be cast to int, which could cause erroneous memory reads on 64 bit build. This CL makes the stride use ptrdiff_t for HalfRow_C BUG=libyuv:582 TESTED=try bots tests R=dhrosa@google.com Review URL: https://codereview.chromium.org/1872953002 .
-
Henrik Kjellander authored
This is how GYP is skipped on the GN bots. If GYP runs, it will currently produce files in out/{Debug,Releaese} that makes GN fail. BUG=601140 TBR=fbarchard@chromium.org Review URL: https://codereview.chromium.org/1874653003 .
-