Commits · 528356a1284c546b2a3e56d6ec2eb5c5e77959c7 · submodule / libyuv

18 Nov, 2015 3 commits

Frank Barchard authored Nov 18, 2015

TBR=harryjin@google.com
BUG=libtyv:525

Review URL: https://codereview.chromium.org/1460723003 .

528356a1

port I411 movzx 2 byte reader to gcc · 50f8cb2d

Frank Barchard authored Nov 18, 2015

previously the I411 format used movd to read U, V pixels.
But this reads 4 bytes, and can cause a memory exception.
pinsrw can be used, but fails on drmemory 1.5, and is slow.
So in this change a movzxw is used to read 2 bytes into EBX,
then copy to xmm0 with movd.
Slightly slower, but no memory exception
Was LibYUVConvertTest.I411ToARGB_Opt (577 ms)
Now LibYUVConvertTest.I411ToARGB_Opt (608 ms)

TBR=harryjin@google.com
BUG=libyuv:525

Review URL: https://codereview.chromium.org/1457783004 .

50f8cb2d

Fix for drmemory failure on I411ToARGB · 5eefbe23

Frank Barchard authored Nov 18, 2015

Before
I420ToARGB_Opt (594 ms)
I422ToARGB_Opt (483 ms)
I411ToARGB_Opt (748 ms) ***
I444ToARGB_Opt (452 ms)
I400ToARGB_Opt (218 ms)

After
I420ToARGB_Opt (591 ms)
I422ToARGB_Opt (454 ms)
I411ToARGB_Opt (502 ms)  ***
I444ToARGB_Opt (441 ms)
I400ToARGB_Opt (216 ms)

TBR=harryjin@google.com
BUG=libyuv:525

Review URL: https://codereview.chromium.org/1459513002 .

5eefbe23

17 Nov, 2015 2 commits

free src_a in unittest to fix leak · ec4b258d

Frank Barchard authored Nov 17, 2015

TBR=harryjin@google.com
BUG=libyuv:524

Review URL: https://codereview.chromium.org/1452083002 .

ec4b258d

test for unaligned vs aligned for CopyRow_SSE2 · 0815568a

Frank Barchard authored Nov 17, 2015

improves performance on older CPUs where movdqa is faster.
TBR=harryjin@google.com
BUG=libyuv:492

Review URL: https://codereview.chromium.org/1455463002 .

0815568a

14 Nov, 2015 1 commit

port I444ToARGB avx2 code from Visual C to GCC. · 1019e453

Frank Barchard authored Nov 14, 2015

SSSE3
Note: Google Test filter = *I444ToARGB*
[==========] Running 8 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 8 tests from LibYUVConvertTest
[ RUN      ] LibYUVConvertTest.I444ToARGB_Any
[       OK ] LibYUVConvertTest.I444ToARGB_Any (435 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_Unaligned
[       OK ] LibYUVConvertTest.I444ToARGB_Unaligned (418 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_Invert
[       OK ] LibYUVConvertTest.I444ToARGB_Invert (417 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_Opt
[       OK ] LibYUVConvertTest.I444ToARGB_Opt (411 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_ARGB_Any
[       OK ] LibYUVConvertTest.I444ToARGB_ARGB_Any (419 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_ARGB_Unaligned
[       OK ] LibYUVConvertTest.I444ToARGB_ARGB_Unaligned (432 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_ARGB_Invert
[       OK ] LibYUVConvertTest.I444ToARGB_ARGB_Invert (435 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_ARGB_Opt
[       OK ] LibYUVConvertTest.I444ToARGB_ARGB_Opt (421 ms)
[----------] 8 tests from LibYUVConvertTest (3389 ms total)

AVX2
Note: Google Test filter = *I444ToARGB*
[==========] Running 8 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 8 tests from LibYUVConvertTest
[ RUN      ] LibYUVConvertTest.I444ToARGB_Any
[       OK ] LibYUVConvertTest.I444ToARGB_Any (340 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_Unaligned
[       OK ] LibYUVConvertTest.I444ToARGB_Unaligned (325 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_Invert
[       OK ] LibYUVConvertTest.I444ToARGB_Invert (316 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_Opt
[       OK ] LibYUVConvertTest.I444ToARGB_Opt (316 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_ARGB_Any
[       OK ] LibYUVConvertTest.I444ToARGB_ARGB_Any (315 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_ARGB_Unaligned
[       OK ] LibYUVConvertTest.I444ToARGB_ARGB_Unaligned (341 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_ARGB_Invert
[       OK ] LibYUVConvertTest.I444ToARGB_ARGB_Invert (331 ms)
[ RUN      ] LibYUVConvertTest.I444ToARGB_ARGB_Opt
[       OK ] LibYUVConvertTest.I444ToARGB_ARGB_Opt (329 ms)
[----------] 8 tests from LibYUVConvertTest (2615 ms total)

TBR=harryjin@google.com
BUG=libyuv:492

Review URL: https://codereview.chromium.org/1445893002 .

1019e453

13 Nov, 2015 1 commit

scale with conversion using 2 steps with unittest · 60adcbaf

Frank Barchard authored Nov 13, 2015

a prototype function to implement the yuv to rgb with conversion and scale.
replace with 1 step function in future version, using same API.

R=harryjin@google.com
BUG=libyuv:471

Review URL: https://codereview.chromium.org/1421553016 .

60adcbaf

10 Nov, 2015 2 commits

fix yvu constants for avx2 yuv to rgb · 6100f50f

Frank Barchard authored Nov 10, 2015

the yvu matrix for yuv to rgb had an incorrect entry, affecting yuv to bgra,
yuv to abgr and yuv to raw.
fix the matrix and reenable avx2 functions.

R=harryjin@google.com
BUG=libyuv:522

Review URL: https://codereview.chromium.org/1411763004 .

6100f50f

disable more avx2 functions that dont link in chrome · 72a9e282

Frank Barchard authored Nov 10, 2015

libyuv builds/runs, but when integrated into chromium, produces link errors. unclear why but this disables affected functions.
will followup with re-enabling them once the root cause in the runtime error is found.

TBR=harryjin@google.com
BUG=libyuv:522

Review URL: https://codereview.chromium.org/1427683004 .

72a9e282

09 Nov, 2015 1 commit

disable 4 AVX2 YUV to RGB conversions which fails tests. · fb5ed1f4

Frank Barchard authored Nov 09, 2015

disable I422ALPHATOARGBROW_AVX2 I422TOARGBROW_AVX2 I422TORGB24ROW_AVX2 I422TORGBAROW_AVX2 in row.h.
SSSE3 versions will be used instead.
Short term fix until issue can be resolved.

R=harryjin@google.com
BUG=libyuv:522

Review URL: https://codereview.chromium.org/1419513009 .

fb5ed1f4

06 Nov, 2015 1 commit

set d19 alpha on inner loop · 98eb102b

Frank Barchard authored Nov 06, 2015

TBR=harryjin@google.com
BUG=libyuv:521

Review URL: https://codereview.chromium.org/1429263004 .

98eb102b

05 Nov, 2015 1 commit

YUV to RGB for x64 use registers instead of memory. · 431cb366

Frank Barchard authored Nov 05, 2015

On Arm the YVU to RGB conversions move constants into registers.
This change does the same for 64 bit intel builds where additional
registers are available.
The AVX2 saves 3 instructions by because the 2nd argument needs to be a register, so a vmovdqu was avoided.

x64 builds using memory:
AVX2  I420ToARGB_Opt (3059 ms)
SSSE3 I420ToARGB_Opt (3959 ms)

Now using registers
AVX2  I420ToARGB_Opt (2906 ms)
SSSE3 I420ToARGB_Opt (3928 ms)

TBR=harryjin@google.com
BUG=libyuv:520

Review URL: https://codereview.chromium.org/1407353010 .

431cb366

04 Nov, 2015 7 commits

add .gn file for gn builds · c2bff1a1

Frank Barchard authored Nov 04, 2015

using a stripped down gn file from webrtc.

BUG=libyuv:411,libyuv:519
R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/1417613007 .

c2bff1a1

Neon versions of I420AlphaToARGB · 860cc035

Frank Barchard authored Nov 04, 2015

Add alpha version of YUV to RGB to neon code for ARMv7 and aarch64.
For other YUV to RGB conversions, hoist alpha set to 255 out of loop.

TBR=harryjin@google.com
BUG=libyuv:516

Review URL: https://codereview.chromium.org/1413763017 .

860cc035

unittest fix for cpu flags. · 82d74a37

Frank Barchard authored Nov 04, 2015

cpu flags of 1 disables SIMD and uses C.  This used to be 0, but the change
in auto init behavior means that 0 now means uninitialized, and will cause
auto detect to reinit the cpu info.  A value of 1 disables the auto init.

TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1408753004 .

82d74a37

cpuid tool fix - remove mipsdsp and add avx3 · ab9a42d9
Frank Barchard authored Nov 04, 2015
```
TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1412373006 .
```
ab9a42d9
rename yuv matrix constants to be more clear about what they are · d95d2169
Frank Barchard authored Nov 04, 2015
```
R=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1429693006 .
```
d95d2169

add command line cpu info to allow android neon test · c629cb3a

Frank Barchard authored Nov 04, 2015

in order to compare C and Neon code, a new command line flag is added.
historically environment variables controlled cpu features, but on
android apk it is easier to pass a command line option to disable cpu
optimizations.

R=harryjin@google.com
BUG=libyuv:516

Review URL: https://codereview.chromium.org/1407193009 .

c629cb3a

remove mips dsp detect · 1f1d140b

Frank Barchard authored Nov 04, 2015

DSP code is not actually used, only DSPR2.  Remove the detect.

TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1405043008 .

1f1d140b

03 Nov, 2015 1 commit

Raw 24 bit RGB to RGB24 (bgr) · ce4c2fad

Frank Barchard authored Nov 03, 2015

Add unittests that do 1 step conversion vs 2 step conversion.

Tests end swapping versions match direct conversions.

R=harryjin@google.com
BUG=libyuv:518

Review URL: https://codereview.chromium.org/1419103007 .

ce4c2fad

02 Nov, 2015 2 commits

remove store bgra, abgr, raw unused macros · 87926cec

Frank Barchard authored Nov 02, 2015

TBR=harryjin@google.com
BUG=libyuv:518

Review URL: https://codereview.chromium.org/1420033004 .

87926cec

remove I422ToBGRA and use I422ToRGBA internally · 2c7aa007

Frank Barchard authored Nov 02, 2015

Removes low levels for I420ToBGRA and I420ToRAW and reimplements them as I420ToRGBA and I420ToRGB24 with transposed color matrix.

Adds unittests that do 1 step conversion vs 2 steps to test end swapping versions match direct conversions.

R=harryjin@google.com
BUG=libyuv:518

Review URL: https://codereview.chromium.org/1427993004 .

2c7aa007

30 Oct, 2015 1 commit

refactor I420ToABGR to use I420ToARGBRow · 5d97b933

Frank Barchard authored Oct 30, 2015

Using a transposed conversion matrix, I420ToARGB can output ABGR.

R=harryjin@google.com, xhwang@chromium.org
BUG=libyuv:473

Review URL: https://codereview.chromium.org/1413573010 .

5d97b933

29 Oct, 2015 1 commit
- disable I420AlphaToARGB for 32 bit intel debug build · 254ef015
  Frank Barchard authored Oct 29, 2015
```
R=harryjin@google.com
BUG=libyuv:517

Review URL: https://codereview.chromium.org/1428843003 .
```
  254ef015
28 Oct, 2015 2 commits

Fix debug compilation problems for gcc and 32 bit x86. · cdbdf5b7

Frank Barchard authored Oct 28, 2015

In some methods with 7 arguments gcc fails to find enough registers
to compile the assembler code when compiling debug. Simplest solution
is to skip the assembler version in debug of those particular functions

(I422Alpha -> ARBG/ABGR)

R=harryjin@google.com,bratell@opera.com
BUG=libyuv:517

Review URL: https://codereview.chromium.org/1423283002 .

cdbdf5b7

pass clangcl compile options to ignore warnings in gflags.cc · 811a5ec4

Frank Barchard authored Oct 28, 2015

R=ajm@chromium.org, ajm@google.com
BUG=libyuv:513,webrtc:760

Review URL: https://codereview.chromium.org/1427643003 .

811a5ec4

27 Oct, 2015 3 commits

refactor I420AlphaToABGR to use I420AlphaToARGB internally · b86dbf24

Frank Barchard authored Oct 27, 2015

swap U and V and transpose conversion matrix, so I420AlphaToARGB and
I420AlphaToABGR share low level code.

Having less code with same performance allows more focused
optimization for future ARM versions.

R=harryjin@google.com
TBR=harryjin@chromium.org
BUG=libyuv:473,libyuv:516

Review URL: https://codereview.chromium.org/1422263002 .

b86dbf24

implement I444ToABGR by swapping uv and transpose matrix · cf160cdb

Frank Barchard authored Oct 27, 2015

U contributes to B and G. V contributes to R and G.
By swapping U and V, they contribute to the opposite channels. Adjust the matrix so the U contribution is in the matrix location such that it till contribute to the
new B channel and vice versa.
This allows ABGR versions of YUV conversion to use the same low level code as ARGB, just using a different matrix and swapping U and V pointers.

As a result the existing I444ToABGRRow functions are no longer needed and are removed.

Previously this function was only Intel AVX2 optimized for Windwos. Now it is also optimized for Arm and GCC.

ARMv7 Neon
Was LibYUVConvertTest.I444ToABGR_Opt (75971 ms)
Now LibYUVConvertTest.I444ToABGR_Opt (3672 ms)
20.6 times faster.

R=xhwang@chromium.org
BUG=libyuv:515

Review URL: https://codereview.chromium.org/1414133006 .

cf160cdb

add unittest that compares ABGR to ARGB · e8ee1755

Frank Barchard authored Oct 27, 2015

TBR=harryjin@google.com
BUG=libyuv:515

Review URL: https://codereview.chromium.org/1423663007 .

e8ee1755

26 Oct, 2015 1 commit

Add avx512bw detection code · 2844662e

Frank Barchard authored Oct 26, 2015

R=harryjin@google.com
BUG=libyuv:514

Review URL: https://codereview.chromium.org/1413463004 .

2844662e

23 Oct, 2015 1 commit
- switch cpu flags to 0 for unitialized to avoid compare · 1502832a
  Frank Barchard authored Oct 23, 2015
```
R=harryjin@google.com
BUG=libyuv:512

Review URL: https://codereview.chromium.org/1418253002 .
```
  1502832a
22 Oct, 2015 4 commits

initialize cpu flags to fix compile error on windows · ad36ba5c
Frank Barchard authored Oct 22, 2015
```
R=harryjin@google.com
BUG=libyuv:512

Review URL: https://codereview.chromium.org/1422733003 .
```
ad36ba5c
color unittest allow j420 error of 5 for arm · 00f15e3c
Frank Barchard authored Oct 22, 2015
```
R=harryjin@google.com
BUG=libyuv:511

Review URL: https://codereview.chromium.org/1412683005 .
```
00f15e3c

odd width 444 fix · 430bb0a0

Frank Barchard authored Oct 22, 2015

TBR=harryjin@google.com
BUG=libyuv:510

Review URL: https://codereview.chromium.org/1415583003 .

430bb0a0

bug fix for odd width 16/24 bit to i420 · 90335f60

Frank Barchard authored Oct 22, 2015

A bug was introduced on arm when the code for 'any' width switch to
a temporary stack buffer and simd.
The C version handles odd width by doing 1 pixel, instead of averaging 2.
But the SIMD any version is supposed to replicate the last pixel, then
the subsampling in Neon will average the pixel with itself, producing
the same result.
The previous version did this, but only for ARGB 32 bit, which was to
avoid introducing issues with subsampled YUY2 source.  This CL adds
replication for RGB 16 bit values.

TBR=harryjin@google.com
BUG=libyuv:510

Review URL: https://codereview.chromium.org/1418983003 .

90335f60

21 Oct, 2015 2 commits

width and 3 bug fix in odd width support of ARGBToI411 · 5bf4de08
Frank Barchard authored Oct 21, 2015
```
TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1415213002 .
```
5bf4de08

Fix ARGBToI411 odd width bug. · ba4b409d

Frank Barchard authored Oct 21, 2015

The any function for handling ARGBToI411 was not handling the pixel
replication correctly.  On 422 and odd width was handled by duplicating
a pixel of source.  411 needs replication for remainders of 1, 2 or 3
pixels.

The C version was handling odd width but with an average of the remainder
pixels, which does not match the SIMD 'any' handling off remainder.
This changes the odd width handling to mimic the any version.

TBR=harryjin@google.com
BUG=libyuv:491

Review URL: https://codereview.chromium.org/1411733004 .

ba4b409d

20 Oct, 2015 3 commits

Move cpu_info variable outside ifdef · 9daa550a

Frank Barchard authored Oct 20, 2015

Fix compile error on arm, mips etc due to undefined variable.

TBR=harryjin@google.com
BUG=none

Review URL: https://codereview.chromium.org/1403373008 .

9daa550a

write to cpu_flags once · 9be6d21a

Frank Barchard authored Oct 20, 2015

To make init cpu flags thread safe, there can only be one write to the variable.

R=richard.winterton@intel.com, harryjin@google.com
BUG=libyuv:508

Review URL: https://codereview.chromium.org/1412793006 .

9be6d21a

DEPS roll of chromium to head · d99324dd

Frank Barchard authored Oct 20, 2015

A fix for android -a was checked in, allowing libyuv gtest flags to be pass.
This CL rolls to the head version of chromium to pull in the change,
allowing better testing and benchmarking of libyuv on android.

TBR=harryjin@google.com
BUG=libyuv:507

Review URL: https://codereview.chromium.org/1416663006 .

d99324dd