- 08 Apr, 2016 1 commit
-
-
Frank Barchard authored
When using C version of I420Interpolate for msan, a 50% interpolation would cause stride to be cast to int, which could cause erroneous memory reads on 64 bit build. This CL makes the stride use ptrdiff_t for HalfRow_C BUG=libyuv:582 TESTED=try bots tests R=dhrosa@google.com Review URL: https://codereview.chromium.org/1872953002 .
-
- 06 Apr, 2016 1 commit
-
-
Frank Barchard authored
Affected Linux GN build, not Windows. R=kjellander@chromium.org BUG=libyuv:583 TESTED=gn gen out/Debug --args=is_debug=true Review URL: https://codereview.chromium.org/1866743002 .
-
- 01 Apr, 2016 1 commit
-
-
Frank Barchard authored
BUG=libyuv:579 TESTED=mkdir build && cd build && cmake .. && cmake --build . --config Release R=kjellander@chromium.org Review URL: https://codereview.chromium.org/1847233002 .
-
- 16 Mar, 2016 1 commit
-
-
Frank Barchard authored
GYP_DEFINES="target_arch=x64 msan=1" ./gyp_libyuv ninja -j7 -C out/Release R=impjdi@google.com BUG=libyuv:575 Review URL: https://codereview.chromium.org/1805683003 .
-
- 29 Feb, 2016 1 commit
-
-
Frank Barchard authored
The 64 bit version of ARGBToRGB565 to 32 bit. 64 bit is using sri which shifts and inserts, saving some masking. The instruction is available for neon 32 bit as well. R=magjed@chromium.org, harryjin@google.com BUG=libyuv:571 Review URL: https://codereview.chromium.org/1724393002 .
-
- 24 Feb, 2016 1 commit
-
-
Frank Barchard authored
Name of objdump tool updated. TBR=kjellander@chromium.org BUG=none Review URL: https://codereview.chromium.org/1715743003 . Review URL: https://codereview.chromium.org/1727993002 .
-
- 18 Feb, 2016 1 commit
-
-
Frank Barchard authored
document play services update R=jkellander@chromium.org BUG=none Review URL: https://codereview.chromium.org/1712463002 .
-
- 12 Feb, 2016 1 commit
-
-
Frank Barchard authored
An SSSE3 version already exists, and an AVX2 version is available for Visual C. This ports the function to AVX2 completing the AVX2 ports of all YUV to RGB functions for AVX2 on gcc. TBR=harryjin@google.com BUG=libyuv:555 Review URL: https://codereview.chromium.org/1687253002 .
-
- 10 Feb, 2016 1 commit
-
-
Frank Barchard authored
R=harryjin@google.com BUG=libyuv:557 Review URL: https://codereview.chromium.org/1687713002 .
-
- 09 Feb, 2016 2 commits
-
-
Frank Barchard authored
R=harryjin@google.com BUG=libyuv:564 Review URL: https://codereview.chromium.org/1685723002 .
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:566 Review URL: https://codereview.chromium.org/1673313003 .
-
- 05 Feb, 2016 1 commit
-
-
Frank Barchard authored
When attempting to normalize function names to end in Row_SIMD it was made harder with MIPS_DSPR2 naming convention. Other CPUs do not include the vendor. This should be named consistently. Removed the DISABLE_MIPS in favour of DISABLE_ASM for consistency with other processors. TBR=harryjin@google.com BUG=libyuv:562 Review URL: https://codereview.chromium.org/1677633002 .
-
- 02 Feb, 2016 1 commit
-
-
Frank Barchard authored
internal math of the fastrand function uses a multiply and add that overflows a signed int. This triggers a ubsan failure: ../../unit_test/../unit_test/unit_test.h:60:33: runtime error: signed integer overflow: 56248274 * 214013 cannot be represented in type 'int' This change casts the intermediate math to unsigned int to avoid the overflow. For more info on ubsan, see http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer TESTED=Passing compilation using: GYP_DEFINES="ubsan=1" GYP_DEFINES="ubsan_vptr=1" R=harryjin@google.com, pbos@webrtc.org BUG=libyuv:563 Review URL: https://codereview.chromium.org/1662453003 .
-
- 01 Feb, 2016 1 commit
-
-
Frank Barchard authored
This is an UBSan error reported by libjingle [ RUN ] WebRtcVideoFrameTest.ConvertToYUY2BufferStride [000:000] (videoframe.cc:375): Validate frame passed. format: I420 bpp: 12 size: 1280x720 bytes: 1382400 expected: 1382400 sample[0..3]: 73, 73, 73, 73 ../../chromium/src/third_party/libyuv/source/row_gcc.cc:2903:25: runtime error: signed integer overflow: 128 * 16843009 cannot be represented in type 'int' [8/614] WebRtcVideoFrameTest.ConvertToYUY2BufferStride returned/aborted with exit code 1 (32 ms) [9/614] WebRtcVideoFrameTest.ConvertToYUY2BufferInverted (29 ms) Note: Google Test filter = WebRtcVideoFrameTest.ConvertToYUY2BufferInverted The source is uint8 and the multiply is by 0x01010101 to replicate the byte to 4 bytes. Changing the constant to 0x01010101u should avoid overflow. R=harryjin@google.com TBR=harryjin@google.com BUG=libyuv:563 Review URL: https://codereview.chromium.org/1657533005 .
-
- 21 Jan, 2016 1 commit
-
-
Frank Barchard authored
R=harryjin@google.com TBR=harryjin@google.com, kjellander@google.com BUG=libyuv:551 Review URL: https://codereview.chromium.org/1612123002 .
-
- 20 Jan, 2016 1 commit
-
-
Frank Barchard authored
When the image height for unittests was set to an odd height, the TestI420 unittest would not fill the complete source buffer. This change handles the odd height test case. No change to library code. TBR=harryjin@google.com BUG=libyuv:549 Review URL: https://codereview.chromium.org/1609103002 .
-
- 19 Jan, 2016 1 commit
-
-
Frank Barchard authored
When width was odd Y channel wrote an extra pixel. This change splits the Y from UV into a temporary buffer and memcpy's to the destination. Performance is slower. Was YUY2ToNV12_Any (307 ms) YUY2ToNV12_Unaligned (213 ms) TestYUY2ToNV12 (181 ms) YUY2ToNV12_Opt (177 ms) YUY2ToNV12_Invert (177 ms) Npw YUY2ToNV12_Any (300 ms) YUY2ToNV12_Unaligned (226 ms) YUY2ToNV12_Invert (206 ms) TestYUY2ToNV12 (184 ms) YUY2ToNV12_Opt (181 ms) TBR=harryjin@google.com BUG=libyuv:545 Review URL: https://codereview.chromium.org/1593833002 .
-
- 15 Jan, 2016 1 commit
-
-
Frank Barchard authored
I420ToNV21 passes the wrong dst_stride_y when it calls I420ToNV12; parameter 8 (convert_from.cc:448) is src_stride_y but should be dst_stride_y. This causes image corruption when converting I420 -> NV21 with mismatched luminance strides. R=dhrosa@google.com, harryjin@google.com BUG=libyuv:547 Review URL: https://codereview.chromium.org/1582793008 .
-
- 13 Jan, 2016 1 commit
-
-
Frank Barchard authored
R=harryjin@google.com BUG=libyuv:546 Review URL: https://codereview.chromium.org/1574253004 .
-
- 12 Jan, 2016 1 commit
-
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:543 Review URL: https://codereview.chromium.org/1577723003 .
-
- 06 Jan, 2016 1 commit
-
-
Frank Barchard authored
R=dhrosa@google.com, harryjin@google.com BUG=libyuv:538 Review URL: https://codereview.chromium.org/1558093003 .
-
- 05 Jan, 2016 1 commit
-
-
Frank Barchard authored
R=dhrosa@google.com BUG=libyuv:539 Review URL: https://codereview.chromium.org/1557923005 .
-
- 22 Dec, 2015 3 commits
-
-
Frank Barchard authored
port scaledownby4_avx2 to gcc TBR=harryjin@google.com BUG=libyuv:492 Review URL: https://codereview.chromium.org/1546763002 .
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:537 Review URL: https://codereview.chromium.org/1547703002 .
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:535 Review URL: https://codereview.chromium.org/1543773002 .
-
- 21 Dec, 2015 1 commit
-
-
Frank Barchard authored
BUG=libyuv:535 R=dhrosa@google.com Review URL: https://codereview.chromium.org/1535833003 .
-
- 17 Dec, 2015 1 commit
-
-
Frank Barchard authored
BUG=libyuv:533 TBR=harryjin@google.com Review URL: https://codereview.chromium.org/1531143002 .
-
- 16 Dec, 2015 1 commit
-
-
Frank Barchard authored
Fixing the failure: 'TransposeWx8_Fast_MIPS_DSPR2' was not declared in this scope BUG=none R=fbarchard@chromium.org Review URL: https://codereview.chromium.org/1527243002 .
-
- 15 Dec, 2015 2 commits
-
-
Frank Barchard authored
R=dhrosa@google.com, harryjin@google.com BUG=libyuv:527 Review URL: https://codereview.chromium.org/1520423003 .
-
Frank Barchard authored
When scaling down by 2 the formula should round consistently. (a+b+c+d+2)/4 The C version did but the SSE2 version was doing 2 averages. avg(avg(a,b),avg(c,d)) This change uses a sum, then rounds. R=dhrosa@google.com, harryjin@google.com BUG=libyuv:447,libyuv:527 Review URL: https://codereview.chromium.org/1513183004 .
-
- 11 Dec, 2015 1 commit
-
-
Frank Barchard authored
remove include from unittest.cc that is already done by unittest.h TBR=harryjin@google.com BUG=libyuv:530 Review URL: https://codereview.chromium.org/1513263004 .
-
- 10 Dec, 2015 1 commit
-
-
Frank Barchard authored
Some functions run out of registers when compiled for debug, fpic, with stack frames on 32 bit x86 with clang. Previously they were enabled based on _DEBUG but that macro is not set in some build systems. This CL adds DEBUG macro as well to cover those environments. R=harryjin@google.com BUG=libyuv:532 Review URL: https://codereview.chromium.org/1517693005 .
-
- 09 Dec, 2015 2 commits
-
-
Frank Barchard authored
Benchmark out\release\libyuv_unittest --libyuv_width=1279 --libyuv_height=719 --libyuv_repeat=999 --libyuv_flags=-1 --gtest_filter=*Blend* | sortms Was I420Blend_Any (2321 ms) I420Blend_Unaligned (1684 ms) I420Blend_Opt (1675 ms) I420Blend_Invert (1653 ms) BlendPlane_Invert (1556 ms) BlendPlane_Any (1552 ms) BlendPlane_Unaligned (1548 ms) BlendPlane_Opt (1535 ms) ARGBBlend_Unaligned (659 ms) ARGBBlend_Any (596 ms) ARGBBlend_Invert (591 ms) ARGBBlend_Opt (508 ms) BlendPlaneRow_Unaligned (186 ms) BlendPlaneRow_Opt (171 ms) Now ARGBBlend_Any (621 ms) ARGBBlend_Unaligned (585 ms) ARGBBlend_Invert (564 ms) ARGBBlend_Opt (512 ms) I420Blend_Unaligned (347 ms) I420Blend_Invert (345 ms) I420Blend_Any (337 ms) I420Blend_Opt (327 ms) BlendPlane_Unaligned (187 ms) BlendPlaneRow_Unaligned (187 ms) BlendPlane_Invert (186 ms) BlendPlane_Any (186 ms) BlendPlaneRow_Opt (173 ms) BlendPlane_Opt (171 ms) which is comparable to aligned case out\release\libyuv_unittest --libyuv_width=1280 --libyuv_height=720 --libyuv_repeat=999 --libyuv_flags=-1 --gtest_filter=*Blend* | sortms ARGBBlend_Any (625 ms) ARGBBlend_Unaligned (602 ms) ARGBBlend_Invert (508 ms) ARGBBlend_Opt (506 ms) I420Blend_Any (353 ms) I420Blend_Unaligned (322 ms) I420Blend_Invert (304 ms) I420Blend_Opt (301 ms) BlendPlaneRow_Unaligned (188 ms) BlendPlane_Unaligned (186 ms) BlendPlane_Invert (185 ms) BlendPlane_Any (184 ms) BlendPlaneRow_Opt (173 ms) BlendPlane_Opt (169 ms) R=dhrosa@google.com, harryjin@google.com BUG=libyuv:527 Review URL: https://codereview.chromium.org/1513443002 .
-
Frank Barchard authored
xgetbv is generating bad code, falsely disabling AVX2 and AVX512. disable optimization for the function affected on older versions of Visual C 32 bit. R=brucedawson@chromium.org, dhrosa@google.com, harryjin@google.com BUG=libyuv:529 Review URL: https://codereview.chromium.org/1503393004 .
-
- 07 Dec, 2015 1 commit
-
-
Frank Barchard authored
R=dhrosa@google.com, harryjin@google.com BUG=libyuv:527 Review URL: https://codereview.chromium.org/1507683003 .
-
- 06 Dec, 2015 1 commit
-
-
Frank Barchard authored
AVX2 version can process 16 pixels at a time for improved memory bandwidth and fewer instructions. unittests improved to test unaligned memory, and test exactness when alpha is 0 or 255. R=dhrosa@google.com, harryjin@google.com BUG=libyuv:527 Review URL: https://codereview.chromium.org/1505433002 .
-
- 02 Dec, 2015 1 commit
-
-
Frank Barchard authored
R=dhrosa@google.com, harryjin@google.com, jzern@chromium.org BUG=libyuv:527 Review URL: https://codereview.chromium.org/1491533002 .
-
- 26 Nov, 2015 1 commit
-
-
Frank Barchard authored
YUV version of interpolation between two images. R=dhrosa@google.com, harryjin@google.com BUG=libyuv:526 Review URL: https://codereview.chromium.org/1479593002 .
-
- 20 Nov, 2015 1 commit
-
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:524 Review URL: https://codereview.chromium.org/1468523002 .
-
- 19 Nov, 2015 1 commit
-
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:524 Review URL: https://codereview.chromium.org/1461013002 .
-