- 12 Feb, 2016 2 commits
-
-
Frank Barchard authored
The gflags library was missing from the CMake build and the gtest includes were not being set correctly. R=fbarchard@google.com Review URL: https://codereview.chromium.org/1692083002 .
-
Frank Barchard authored
An SSSE3 version already exists, and an AVX2 version is available for Visual C. This ports the function to AVX2 completing the AVX2 ports of all YUV to RGB functions for AVX2 on gcc. TBR=harryjin@google.com BUG=libyuv:555 Review URL: https://codereview.chromium.org/1687253002 .
-
- 10 Feb, 2016 2 commits
-
-
Frank Barchard authored
NV12ToRGB565Row for Intel is implemented as a 2 step conversion: NV12ToARGBRow_SSSE3 and ARGBToRGB565Row_SSE2 NV12ToARGBRow has an AVX2 version, so this CL implements NV12ToRGB565Row_AVX2 with call to NV12ToARGBRow_AVX2 and ARGBToRGB565Row_SSE2. R=harryjin@google.com BUG=libyuv:554 Review URL: https://codereview.chromium.org/1687953002 .
-
Frank Barchard authored
R=harryjin@google.com BUG=libyuv:557 Review URL: https://codereview.chromium.org/1687713002 .
-
- 09 Feb, 2016 3 commits
-
-
Henrik Kjellander authored
TBR=fbarchard@chromium.org Review URL: https://codereview.chromium.org/1679123006 .
-
Frank Barchard authored
R=harryjin@google.com BUG=libyuv:564 Review URL: https://codereview.chromium.org/1685723002 .
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:566 Review URL: https://codereview.chromium.org/1673313003 .
-
- 08 Feb, 2016 1 commit
-
-
Frank Barchard authored
R=harryjin@google.com BUG=none Review URL: https://codereview.chromium.org/1676383002 .
-
- 05 Feb, 2016 1 commit
-
-
Frank Barchard authored
When attempting to normalize function names to end in Row_SIMD it was made harder with MIPS_DSPR2 naming convention. Other CPUs do not include the vendor. This should be named consistently. Removed the DISABLE_MIPS in favour of DISABLE_ASM for consistency with other processors. TBR=harryjin@google.com BUG=libyuv:562 Review URL: https://codereview.chromium.org/1677633002 .
-
- 03 Feb, 2016 2 commits
-
-
Henrik Kjellander authored
TBR=fbarchard@chromium.org BUG=libyuv:564 Review URL: https://codereview.chromium.org/1665573003 .
-
Henrik Kjellander authored
TBR=fbarchard@chromium.org Review URL: https://codereview.chromium.org/1656423002 .
-
- 02 Feb, 2016 3 commits
-
-
Frank Barchard authored
internal math of the fastrand function uses a multiply and add that overflows a signed int. This triggers a ubsan failure: ../../unit_test/../unit_test/unit_test.h:60:33: runtime error: signed integer overflow: 56248274 * 214013 cannot be represented in type 'int' This change casts the intermediate math to unsigned int to avoid the overflow. For more info on ubsan, see http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer TESTED=Passing compilation using: GYP_DEFINES="ubsan=1" GYP_DEFINES="ubsan_vptr=1" R=harryjin@google.com, pbos@webrtc.org BUG=libyuv:563 Review URL: https://codereview.chromium.org/1662453003 .
-
Frank Barchard authored
For more info on ubsan, see http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer TESTED=Passing compilation using: GYP_DEFINES="ubsan=1" GYP_DEFINES="ubsan_vptr=1" R=harryjin@google.com, pbos@webrtc.org BUG=libyuv:563 Review URL: https://codereview.chromium.org/1654253004 .
-
Frank Barchard authored
For more info, see http://dev.chromium.org/developers/testing/undefinedbehaviorsanitizer TESTED=Passing compilation using: GYP_DEFINES="ubsan=1" GYP_DEFINES="ubsan_vptr=1" R=harryjin@google.com, pbos@webrtc.org BUG=libyuv:563,webrtc:5124 Review URL: https://codereview.chromium.org/1659713002 .
-
- 01 Feb, 2016 1 commit
-
-
Frank Barchard authored
This is an UBSan error reported by libjingle [ RUN ] WebRtcVideoFrameTest.ConvertToYUY2BufferStride [000:000] (videoframe.cc:375): Validate frame passed. format: I420 bpp: 12 size: 1280x720 bytes: 1382400 expected: 1382400 sample[0..3]: 73, 73, 73, 73 ../../chromium/src/third_party/libyuv/source/row_gcc.cc:2903:25: runtime error: signed integer overflow: 128 * 16843009 cannot be represented in type 'int' [8/614] WebRtcVideoFrameTest.ConvertToYUY2BufferStride returned/aborted with exit code 1 (32 ms) [9/614] WebRtcVideoFrameTest.ConvertToYUY2BufferInverted (29 ms) Note: Google Test filter = WebRtcVideoFrameTest.ConvertToYUY2BufferInverted The source is uint8 and the multiply is by 0x01010101 to replicate the byte to 4 bytes. Changing the constant to 0x01010101u should avoid overflow. R=harryjin@google.com TBR=harryjin@google.com BUG=libyuv:563 Review URL: https://codereview.chromium.org/1657533005 .
-
- 27 Jan, 2016 1 commit
-
-
Frank Barchard authored
MJPGToARGB prototype is in both convert_argb.h and planar_functions.h Remove the duplicate prototype from planar_functions.h R=harryjin@google.com TBR=harryjin@google.com BUG=libyuv:561 Review URL: https://codereview.chromium.org/1638133002 .
-
- 21 Jan, 2016 3 commits
-
-
Frank Barchard authored
R=harryjin@google.com TBR=harryjin@google.com, kjellander@google.com BUG=libyuv:551 Review URL: https://codereview.chromium.org/1612123002 .
-
Henrik Kjellander authored
This works around a compile problem with iossim.mm. BUG=libyuv:548 TBR=fbarchard@chromium.org Review URL: https://codereview.chromium.org/1611123004 .
-
Henrik Kjellander authored
As this bot was removed in https://codereview.chromium.org/1613013003/ TBR=fbarchard@chromium.org BUG= Review URL: https://codereview.chromium.org/1615793002 .
-
- 20 Jan, 2016 2 commits
-
-
Frank Barchard authored
When scanning profiles for unexpected _C functions this test function contained the substring. Changing the name will simplify the search. TBR=harryjin@google.com BUG=libyuv:543 Review URL: https://codereview.chromium.org/1602363002 .
-
Frank Barchard authored
When the image height for unittests was set to an odd height, the TestI420 unittest would not fill the complete source buffer. This change handles the odd height test case. No change to library code. TBR=harryjin@google.com BUG=libyuv:549 Review URL: https://codereview.chromium.org/1609103002 .
-
- 19 Jan, 2016 1 commit
-
-
Frank Barchard authored
When width was odd Y channel wrote an extra pixel. This change splits the Y from UV into a temporary buffer and memcpy's to the destination. Performance is slower. Was YUY2ToNV12_Any (307 ms) YUY2ToNV12_Unaligned (213 ms) TestYUY2ToNV12 (181 ms) YUY2ToNV12_Opt (177 ms) YUY2ToNV12_Invert (177 ms) Npw YUY2ToNV12_Any (300 ms) YUY2ToNV12_Unaligned (226 ms) YUY2ToNV12_Invert (206 ms) TestYUY2ToNV12 (184 ms) YUY2ToNV12_Opt (181 ms) TBR=harryjin@google.com BUG=libyuv:545 Review URL: https://codereview.chromium.org/1593833002 .
-
- 15 Jan, 2016 1 commit
-
-
Frank Barchard authored
I420ToNV21 passes the wrong dst_stride_y when it calls I420ToNV12; parameter 8 (convert_from.cc:448) is src_stride_y but should be dst_stride_y. This causes image corruption when converting I420 -> NV21 with mismatched luminance strides. R=dhrosa@google.com, harryjin@google.com BUG=libyuv:547 Review URL: https://codereview.chromium.org/1582793008 .
-
- 14 Jan, 2016 2 commits
-
-
Frank Barchard authored
Remove assumption on absolute paths in java_cpp_enum.py. In java_cpp_enum.py there were assumptions on 'build' being a component of the absolute path of the script invoking the script. This leads to problems when other projects are using the Chromium build toolchain (in this case libyuv), where the script invoking GYP is located in the root of the project dir (https://chromium.googlesource.com/libyuv/libyuv/+/master/gyp_libyuv). TBR=harryjin@google.com, jkellander@chromium.org BUG=libyuv:536 Review URL: https://codereview.chromium.org/1581773003 .
-
Frank Barchard authored
gflags has a build warning in the chromium version. ../../third_party/gflags/src/gflags.cc:281:53: error: unused typedef 'true_false_equal' [-Werror,-Wunused-local-typedef] COMPILE_ASSERT(sizeof(kTrue) == sizeof(kFalse), true_false_equal); ^ 1 error generated. [8/231] CXX obj/chromium/src/testing/gtest/src/gtest.gtest.o Its been reported and fixed upstream https://github.com/gflags/gflags/issues/125 But not pulled into chromium. Last update to flags was in 2013. This change disables the warning. R=harryjin@google.com, kjellander@chromium.org, jkellander@chromium.org BUG=libyuv:536, webrtc:5397, webrtc:5398, webrtc:5399 Review URL: https://codereview.chromium.org/1581123002 .
-
- 13 Jan, 2016 1 commit
-
-
Frank Barchard authored
R=harryjin@google.com BUG=libyuv:546 Review URL: https://codereview.chromium.org/1574253004 .
-
- 12 Jan, 2016 3 commits
-
-
Frank Barchard authored
Also renames Inverted to Invert in test name for consistency. TBR=harryjin@google.com BUG=libyuv:543 Review URL: https://codereview.chromium.org/1577973004 .
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:543 Review URL: https://codereview.chromium.org/1577723003 .
-
Frank Barchard authored
Macro define and macro ifdef didnt match, leading to C code being used. Make macro match function name. TBR=harryjin@google.com BUG=libyuv:543 Review URL: https://codereview.chromium.org/1579023002 .
-
- 11 Jan, 2016 1 commit
-
-
Frank Barchard authored
use_sysroot=0 is required for webrtc on linux intel builds, but libyuv doesnt use the affected libraries, so removing this. R=harryjin@google.com, sbc@chromium.org BUG=libyuv:534,libyuv:542 Review URL: https://codereview.chromium.org/1566303002 .
-
- 06 Jan, 2016 1 commit
-
-
Frank Barchard authored
R=dhrosa@google.com, harryjin@google.com BUG=libyuv:538 Review URL: https://codereview.chromium.org/1558093003 .
-
- 05 Jan, 2016 1 commit
-
-
Frank Barchard authored
R=dhrosa@google.com BUG=libyuv:539 Review URL: https://codereview.chromium.org/1557923005 .
-
- 22 Dec, 2015 3 commits
-
-
Frank Barchard authored
port scaledownby4_avx2 to gcc TBR=harryjin@google.com BUG=libyuv:492 Review URL: https://codereview.chromium.org/1546763002 .
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:537 Review URL: https://codereview.chromium.org/1547703002 .
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:535 Review URL: https://codereview.chromium.org/1543773002 .
-
- 21 Dec, 2015 2 commits
-
-
Frank Barchard authored
In addition to https://codereview.chromium.org/1526163002 disable sysroot only for x86 and x64. Keep using sysroot for other archs due to crosscompiling. BUG=none R=fbarchard@chromium.org Review URL: https://codereview.chromium.org/1536403002 .
-
Frank Barchard authored
BUG=libyuv:535 R=dhrosa@google.com Review URL: https://codereview.chromium.org/1535833003 .
-
- 17 Dec, 2015 3 commits
-
-
Frank Barchard authored
Remove inaccurate specializations for 1/4 and 3/4, since they round incorrectly. Specialize for 100% and 50% are kept due to performance. Make C and ARM code match SSSE3. Make unittests expect zero difference. BUG=libyuv:535 R=harryjin@google.com Review URL: https://codereview.chromium.org/1533643005 .
-
Frank Barchard authored
TBR=harryjin@google.com BUG=libyuv:533 Review URL: https://codereview.chromium.org/1535433003 .
-
Frank Barchard authored
BUG=libyuv:533 TBR=harryjin@google.com Review URL: https://codereview.chromium.org/1531143002 .
-