Bug: libyuv:755
Test: ~/intelsde/sde -p4p -- out/Release/libyuv_unittest --gtest_filter=LibYUVScaleTest*
Change-Id: Ibb0c908c38efc49dc56e86fa54ae7bd48ced02b5
Reviewed-on: https://chromium-review.googlesource.com/756363Reviewed-by: Cheng Wang <wangcheng@google.com>

Key instruction sets added for each microarchitecture:

AVX512BW, AVX512VL, AVX512DQ - skylake server or later
AVX512_VBMI, AVX512_IFMA - cannon lake or later
AVX512_BITALG, AVX512_VBMI2, AVX512_VPOPCNTDQ, AVX512_VNNI, GFNI, VAES, VPCLMULQDQ - ice lake or later

Bug: libyuv:752
Test: ~/intelsde/sde -icl -- out/Release/libyuv_unittest --gtest_filter=*Cpu*
Change-Id: I9ee28904c90009d66721b9f805a440c5fc2da122
Reviewed-on: https://chromium-review.googlesource.com/755617Reviewed-by: Frank Barchard <fbarchard@google.com>
Reviewed-by: richard winterton <rrwinterton@gmail.com>

vmovd is an AVX instruction.  This will crash on an older CPU with
only SSSE3 but not AVX.  Use movd instead.

Bug: libyuv:753
Test: ~/intelsde/sde -mrm -- out/Release/libyuv_unittest --gtest_filter=LibYUVCompareTest.BenchmarkHammingDistance_Opt
Change-Id: I1fb0026039d5f83d124f5d03fed7dc0d2d723e49
Reviewed-on: https://chromium-review.googlesource.com/756200Reviewed-by: Cheng Wang <wangcheng@google.com>
Reviewed-by: richard winterton <rrwinterton@gmail.com>

H010 is 10 bit planar format with 10 bits in lower bits.
P010 is 10 bit biplanar format with 10 bits in upper bits.
This function weaves the U and V channels and shifts the bits
into the upper bits.

Bug: libyuv:751
Test: LibYUVPlanarTest.MergeUV10Row_Opt
Change-Id: I4a0bac0ef1ff95aa1b8d68261ec8e8e86f2d1fbf
Reviewed-on: https://chromium-review.googlesource.com/752692Reviewed-by: Cheng Wang <wangcheng@google.com>
Reviewed-by: Frank Barchard <fbarchard@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

Bug: None
Test: None
Change-Id: Ie7cab948b7e879b08e5e5efaae008977513a0a80
Reviewed-on: https://chromium-review.googlesource.com/749895
Commit-Queue: Frank Barchard <fbarchard@google.com>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>

Bug: libyuv:750
Test: build with WITH_TIDY=1
Change-Id: I09b7c24f52d0daa72fe7d1928d11a56208526bd1
Reviewed-on: https://chromium-review.googlesource.com/748307Reviewed-by: Patrik Höglund <phoglund@chromium.org>

Bug: libyuv:701
Test: objdump to confirm code gen
Change-Id: Ibdcb2cc6bc9bf14b4ccb874c49fc9ff664650e1a
Reviewed-on: https://chromium-review.googlesource.com/745390Reviewed-by: Frank Barchard <fbarchard@google.com>
Reviewed-by: richard winterton <rrwinterton@gmail.com>

Bug: None
Test: lint passes
Change-Id: I1fd40d3506bab1f4f9100902f633a9c9e7b96337
Reviewed-on: https://chromium-review.googlesource.com/745038Reviewed-by: Frank Barchard <fbarchard@google.com>

popcnt has a fake dependency on the destination.
This assembly avoids the dependency by using a different
register for each popcnt.

Bug: libyuv:701
Test: LIBYUV_DISABLE_SSSE3=1 out/Release/libyuv_unittest --gtest_filter=*Ham*Opt --libyuv_width=1280 --libyuv_height=720 --libyuv_repeat=9999 --libyuv_flags=-1 --libyuv_cpu_info=-1
Change-Id: Ie1d202e2613b7fa8a3c02acd433940e92c80eafa
Reviewed-on: https://chromium-review.googlesource.com/731826Reviewed-by: Cheng Wang <wangcheng@google.com>
Reviewed-by: Frank Barchard <fbarchard@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

Bug: libyuv:746
Test: mm cpuid yuvconvert compare psnr libyuv_unittest
Change-Id: I08f6d5b519151f274e6baee993eb74950161ef53
Reviewed-on: https://chromium-review.googlesource.com/726749Reviewed-by: Frank Barchard <fbarchard@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

Bug: libyuv:747
Test: mm cpuid under android builds
Change-Id: I7fff13006b47a59873f29f8992bb3faf9bdb85f1
Reviewed-on: https://chromium-review.googlesource.com/727263
Commit-Queue: Frank Barchard <fbarchard@google.com>
Reviewed-by: Frank Barchard <fbarchard@google.com>

Bug: libyuv:746
Test: mm from android repo
Change-Id: I7c124acfacc87cc263b19483cea79a63084f3f96
Reviewed-on: https://chromium-review.googlesource.com/724237Reviewed-by: Frank Barchard <fbarchard@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

mingw gcc sets the macro _M_IX86 which is normally only set
by Visual C and clangcl which are Visual C style source code
style for assembly, but gcc is not Visual C compatible.
Add _MSC_VER to most ifdefs to detect that its really Visual C
or clangcl and not mingw gcc so the gcc source code will be used.

Bug: libyuv:744
Test: CXXFLAGS=-m32 CXX=~/prebuilts/gcc/linux-x86/host/x86_64-w64-mingw32-4.8/bin/x86_64-w64-mingw32-g++ make -f linux.mk
Change-Id: I3431aa486eb769b145faa8d5eb75ed639f9d6f5e
Reviewed-on: https://chromium-review.googlesource.com/722319Reviewed-by: Cheng Wang <wangcheng@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

Rietveld CQ has already been disabled and is no longer supoorted.

TBR=phoglund@chromium.org

No-Try: True
Bug: chromium:770592
Change-Id: I2679e9193dfb5ec751bdc76d35fe5d835b44bd0a
Reviewed-on: https://chromium-review.googlesource.com/714302Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

The low level hamming distance functions have size limitations
based on counter sizes.  The higher level calls the low level
in blocks that avoid overflow and then accumulators in int64.
This test compares the results of the low levels to the high
level and against a known value (all ones) to ensure the
count is correct for any specified size.
The the size is very large, the result is expected to be
different.

Bug: libyuv:701
Test: TestHammingDistance_Opt
Change-Id: I6716af7cd09ac4d88a8afa25bc845a1b62af7c93
Reviewed-on: https://chromium-review.googlesource.com/710800Reviewed-by: Frank Barchard <fbarchard@google.com>
Reviewed-by: richard winterton <rrwinterton@gmail.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

Bug: libyuv:701
Test: HammingDistance unittest with large size
Change-Id: Id41a2c27eb8922d03b3a21dab32fa2e7b015ba38
Reviewed-on: https://chromium-review.googlesource.com/708335Reviewed-by: Cheng Wang <wangcheng@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

This reverts commit ec75df58.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> ComputeHammingDistance reduce SIMD loop to 1 call when possible.
> 
> 32 bit x86 has high overhead due to -fpic.  So this reduces the
> number of calls by 1.
> 
> TBR=kjellander@chromium.org
> Bug: libyuv:701
> Test: BenchmarkHammingDistance
> Change-Id: I7f557ef047920db65eab362a5f93abbd274ca051
> Reviewed-on: https://chromium-review.googlesource.com/701755
> Reviewed-by: Frank Barchard <fbarchard@google.com>
> Reviewed-by: Cheng Wang <wangcheng@google.com>

TBR=rrwinterton@gmail.com,fbarchard@google.com,wangcheng@google.com

Change-Id: Ia61e8558a8f083c14be5f51e0e141550b6f2b5c1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: libyuv:701
Reviewed-on: https://chromium-review.googlesource.com/707823Reviewed-by: Frank Barchard <fbarchard@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

32 bit x86 has high overhead due to -fpic.  So this reduces the
number of calls by 1.

TBR=kjellander@chromium.org
Bug: libyuv:701
Test: BenchmarkHammingDistance
Change-Id: I7f557ef047920db65eab362a5f93abbd274ca051
Reviewed-on: https://chromium-review.googlesource.com/701755Reviewed-by: Frank Barchard <fbarchard@google.com>
Reviewed-by: Cheng Wang <wangcheng@google.com>

R=kjellander@chromium.org

Bug:libyuv:741
Change-Id: I6bc18e94ec82e00518f34695cf3b97deed82c76d
Reviewed-on: https://chromium-review.googlesource.com/699996Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

If length of HammingDistance was not a multiple of 4,
the result was incorrect.  The old tests did not catch this
so a new test is done to count 1s.

Bug: libyuv:740
Test: LibYUVCompareTest.TestHammingDistance
Change-Id: I93db5437821c597f1f162ac263d4a594bb83231f
Reviewed-on: https://chromium-review.googlesource.com/699614Reviewed-by: richard winterton <rrwinterton@gmail.com>
Reviewed-by: Cheng Wang <wangcheng@google.com>
Reviewed-by: Frank Barchard <fbarchard@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

Bug: libyuv:701
Test: BenchmarkHammingDistance_Opt
Change-Id: Ibdd5d382677ebef4f82a62e0d5c3b88614a3b6e4
Reviewed-on: https://chromium-review.googlesource.com/696290
Commit-Queue: Frank Barchard <fbarchard@google.com>
Reviewed-by: Cheng Wang <wangcheng@google.com>

Bug: None
Test: None
Change-Id: Id52663f9c957aac3172fba92d888ad1b041d5cf0
Reviewed-on: https://chromium-review.googlesource.com/692981Reviewed-by: Cheng Wang <wangcheng@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

Under cache thrashing circumstances, ldp/stp perform better than
ld1/st1 on QC820/QC821 CPUs.  Same performance when hitting cache.

Bug: libyuv:738
Test: LibYUVPlanarTest.TestCopySamples_Opt (445 ms)
Change-Id: Ib6a0a5d5e6a1b7ef667b9bb2edb39d681cf3614c
Reviewed-on: https://chromium-review.googlesource.com/691281
Commit-Queue: Frank Barchard <fbarchard@google.com>
Reviewed-by: Cheng Wang <wangcheng@google.com>

TestScaleSamples_Opt can be slow on ARM if the size of the buffer is 1 MB.
This test does a memcpy and behaves the same.

Bug: libyuv:738
Test: LibYUVPlanarTest.TestCopySamples_Opt
Change-Id: Ia9f30190ed76ea350ebe054c9b899d5268e7e135
Reviewed-on: https://chromium-review.googlesource.com/685751Reviewed-by: Cheng Wang <wangcheng@google.com>
Commit-Queue: Frank Barchard <fbarchard@google.com>

torbjorng@ has left Google and kjellander@ will in a month.
Replacing remaining ownership (after some cleanup) with
phoglund@.

BUG=libyuv:739
NOTRY=True

Change-Id: I228f2d87008f5f9cbce1ac88dc51c7f2ad6192c0
Reviewed-on: https://chromium-review.googlesource.com/680934Reviewed-by: Frank Barchard <fbarchard@google.com>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

Change log: https://chromium.googlesource.com/chromium/src/+log/9e319197e5..ff3b31782d
Full diff: https://chromium.googlesource.com/chromium/src/+/9e319197e5..ff3b31782d

Changed dependencies:
* src/base: https://chromium.googlesource.com/chromium/src/base/+log/6afcd86a32..9b543d487c
* src/build: https://chromium.googlesource.com/chromium/src/build/+log/f3edcd4990..156ba982d7
* src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/cbc33b9c0a..f6d165d9d8
* src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/86201d6b56..39c4b2fcf7
* src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/d7f8718a82..cc96d3d66b
* src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/c1de82c542..72c52c224c
* src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/441164c72d..aa736cc76e
* src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/7653ce02e1..eceb2c420b
DEPS diff: https://chromium.googlesource.com/chromium/src/+/9e319197e5..ff3b31782d/DEPS

Clang version changed 313222:313786
Details: https://chromium.googlesource.com/chromium/src/+/9e319197e5..ff3b31782d/tools/clang/scripts/update.py

TBR=kjellander@chromium.org
BUG=libyuv:737
TEST=gn gen out/Release "--args=is_debug=false target_os=\"android\" target_cpu=\"mips64el\" mips_arch_variant=\"r6\" mips_use_msa=true is_component_build=true is_clang=true"
ninja -v -C out/Release libyuv_unittest

Change-Id: I44c37d2ac6b2d853cf4005beec87f81b888c7999
Reviewed-on: https://chromium-review.googlesource.com/679554
Commit-Queue: Frank Barchard <fbarchard@google.com>
Reviewed-by: Frank Barchard <fbarchard@google.com>

The sum of floats can optimize differently with vectorization, producing
a different result between NEON and C.
Adjust the unittest to allow for some difference in the sum.

The NEON version is 8 samples at a time, so the test now rounds up
the number of values to multiple of 8.

TBR=kjellander@chromium.org
Bug: libyuv:717
Test: LibYUVPlanarTest.TestScaleSumSamples_Opt


Change-Id: I2a0783780c7e0f240f7a8e4700b2a4d3e6b52d87
Reviewed-on: https://chromium-review.googlesource.com/673708Reviewed-by: Cheng Wang <wangcheng@google.com>

Full color test is the slowest of the unittests, and not catching any
additional bugs at the moment.  Step thru range of 0 to 255 in steps of
5 to speed up the test.  255 is 3 * 5 * 17, so any of those primes would
hit 0 and 255 exactly.

Was LibYUVColorTest.TestFullYUV (896 ms)
Now LibYUVColorTest.TestFullYUV (212 ms)

TBR=kjellander@chromium.org
Bug: libyuv:736
Test: LibYUVColorTest.TestFullYUV
Change-Id: I5b55fb07ada0dc7bdc3c3c20569d36bf09bb3804
Reviewed-on: https://chromium-review.googlesource.com/672064
Commit-Queue: Frank Barchard <fbarchard@google.com>
Reviewed-by: Frank Barchard <fbarchard@google.com>

Change log: https://chromium.googlesource.com/chromium/src/+log/3a3410e0eb..9e319197e5
Full diff: https://chromium.googlesource.com/chromium/src/+/3a3410e0eb..9e319197e5

Changed dependencies:
* src/base: https://chromium.googlesource.com/chromium/src/base/+log/b120cdc8d8..6afcd86a32
* src/build: https://chromium.googlesource.com/chromium/src/build/+log/800cde0e9e..f3edcd4990
* src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/a4c7e58966..86201d6b56
* src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/8ca56a609f..d7f8718a82
* src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/5d202b9b7d..c1de82c542
* src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1a2a373481..441164c72d
* src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/9069575d37..7653ce02e1
DEPS diff: https://chromium.googlesource.com/chromium/src/+/3a3410e0eb..9e319197e5/DEPS

Clang version changed 312679:313222
Details: https://chromium.googlesource.com/chromium/src/+/3a3410e0eb..9e319197e5/tools/clang/scripts/update.py

TBR=kjellander@chromium.org
BUG=libyuv:721, chromium:766322

Change-Id: I38430171fa76ade415fafe20edb2055181e12818
Reviewed-on: https://chromium-review.googlesource.com/672043
Commit-Queue: Frank Barchard <fbarchard@google.com>
Reviewed-by: Frank Barchard <fbarchard@google.com>

UBsan goes into an infinite recursion when __dynamic_cast instrumented with
"vptr". See crbug.com/609786.

Similar WebRTC change: https://codereview.webrtc.org/2983583002

BUG=None
TBR=fbarchard@chromium.org

Change-Id: Ia37635e639550d60f9a79df927447c7cfaacdc93
Reviewed-on: https://chromium-review.googlesource.com/671367
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>

TBR=kjellander@chromium.org
Bug: libyuv:735
Test: try bots
Change-Id: I00dc06689cd0a23847865c0c8edeb538b0cc81ac
Reviewed-on: https://chromium-review.googlesource.com/669142Reviewed-by: Frank Barchard <fbarchard@google.com>

gcc 4.8 does not support c++14 so override the default
c++14 that chromium is now set to.

TBR=kjellander@chromium.org
Bug: libyuv:734
Test: gn gen out/Release "--args=is_debug=false is_clang=false use_sysroot=false target_cpu=\"x64\""
Change-Id: Ic414c79fee90e89ee3539fd1a373da260aecdc2b
Reviewed-on: https://chromium-review.googlesource.com/668031Reviewed-by: Frank Barchard <fbarchard@google.com>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>

BUG=libyuv:729
TBR=fbarchard@chromium.org
NOTRY=True

Change-Id: Ica6bbdd5ff3112813fde61f9b335fd68fa61c731
Reviewed-on: https://chromium-review.googlesource.com/667105Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

Change log: https://chromium.googlesource.com/chromium/src/+log/e0c00467d6..3a3410e0eb
Full diff: https://chromium.googlesource.com/chromium/src/+/e0c00467d6..3a3410e0eb

Changed dependencies:
* src/base: https://chromium.googlesource.com/chromium/src/base/+log/7b6dbc8d1f..b120cdc8d8
* src/build: https://chromium.googlesource.com/chromium/src/build/+log/d78169a36f..800cde0e9e
* src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/32847e75d6..a4c7e58966
* src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/52eccfe830..8ca56a609f
* src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/726415ed49..5d202b9b7d
* src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/99ec818780..1a2a373481
* src/third_party/ced/src: https://chromium.googlesource.com/external/github.com/google/compact_enc_det.git/+log/910cca22d8..94c367a1fe
* src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/f3bc46f72e..9069575d37
DEPS diff: https://chromium.googlesource.com/chromium/src/+/e0c00467d6..3a3410e0eb/DEPS

No update to Clang.

purpose of the roll is to fix a gcc build error with g++14 option.

TBR=kjellander@chromium.org
BUG=libyuv:734
TEST=try bots pass.
Change-Id: Ifad9fecf0b62ca4f06f918e96fc9734173aefd02
Reviewed-on: https://chromium-review.googlesource.com/667970Reviewed-by: Frank Barchard <fbarchard@google.com>

TBR=kjellander@chromium.org
BUG=None
TEST=git cl lint

Change-Id: I45ecd7f8279981ba037dc051f521f6b6d5506f64
Reviewed-on: https://chromium-review.googlesource.com/664345
Commit-Queue: Frank Barchard <fbarchard@google.com>
Reviewed-by: Frank Barchard <fbarchard@google.com>

TBR=kjellander@chromium.org
BUG=libyuv:732
TEST=LibYUVPlanarTest.TestScaleSumSamples_Opt

Change-Id: If80e9510ad5668b080b9384e656c0bd73cf5b4a6
Reviewed-on: https://chromium-review.googlesource.com/663764
Commit-Queue: Frank Barchard <fbarchard@google.com>
Reviewed-by: Frank Barchard <fbarchard@google.com>
Reviewed-by: Cheng Wang <wangcheng@google.com>

The current documentation shows a debug build.
When you attempt that an assert is triggered suggesting
a release build.  Update the documentation to reflect that.

TBR=kjellander@chromium.org
BUG=libyuv:731
TEST=gn gen out/Deb^C "--args=is_debug=true is_msan=true"

Change-Id: Ib78e3a7859aa391ac359fa38234aaef0554d0df4
Reviewed-on: https://chromium-review.googlesource.com/663882Reviewed-by: Cheng Wang <wangcheng@google.com>

When command line --libyuv_cpu_info is used the individual tests
used to need to set the cpumask.  This CL moves that to the init
for each test class so the individual tests dont need to set it.

TBR=kjellander@chromium.org
BUG=libyuv:720
TEST=LibYUVBaseTest.TestCpuHas

Change-Id: I6ae180388debf6cf76be6df5b81cfffeb35ee2eb
Reviewed-on: https://chromium-review.googlesource.com/662367Reviewed-by: Cheng Wang <wangcheng@google.com>

Change log: https://chromium.googlesource.com/chromium/src/+log/21e78fbe27..e0c00467d6
Full diff: https://chromium.googlesource.com/chromium/src/+/21e78fbe27..e0c00467d6

Changed dependencies:
* src/base: https://chromium.googlesource.com/chromium/src/base/+log/bdaf4d9893..7b6dbc8d1f
* src/build: https://chromium.googlesource.com/chromium/src/build/+log/92ccaf1432..d78169a36f
* src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/436ef979f7..32847e75d6
* src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/dcfc1809e9..52eccfe830
* src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/36421e57a8..726415ed49
* src/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c9667ecd29..99ec818780
* src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/5d14bcccf1..f3bc46f72e
* src/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py.git/+log/72b6a2dc60..5e8001d9a7
DEPS diff: https://chromium.googlesource.com/chromium/src/+/21e78fbe27..e0c00467d6/DEPS

Clang version changed 310694:312679
Details: https://chromium.googlesource.com/chromium/src/+/21e78fbe27..e0c00467d6/tools/clang/scripts/update.py

TBR=kjellander@chromium.org
BUG=libyuv:727, chromium:763354

Change-Id: I3d2974de13d5a2c680f324790501661933eedcbe
Reviewed-on: https://chromium-review.googlesource.com/661497Reviewed-by: Frank Barchard <fbarchard@google.com>

Reduce buffers for test to 640 from 1280 to avoid
bit stack warning.

TBR=kjellander@chromium.org
BUG=libyuv:730
TEST=LibYUVPlanarTest.TestGaussRow_Opt and LibYUVPlanarTest.TestGaussCol_Opt

Change-Id: I710af3e952f9a4d1c0c0c8f73922c1d98ad9aa29
Reviewed-on: https://chromium-review.googlesource.com/660662Reviewed-by: Frank Barchard <fbarchard@google.com>