Commit 95a36557 authored by Rodrigo Queiro's avatar Rodrigo Queiro Committed by Rodrigo Queiro

Remove unnecessary `defines`

The only macro referenced by the public headers is GOOGLE_GLOG_DLL_DECL.
This means fewer defines are propagated to rules that depend on glog.
parent c0d2cead
...@@ -118,15 +118,9 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs): ...@@ -118,15 +118,9 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs):
name = "windows_glog_headers", name = "windows_glog_headers",
hdrs = native.glob(["src/windows/glog/*.h"]), hdrs = native.glob(["src/windows/glog/*.h"]),
strip_include_prefix = "src/windows", strip_include_prefix = "src/windows",
# TODO(rodrigoq): are these necessary? # We need to override the default GOOGLE_GLOG_DLL_DECL from
# config.h for windows seem hardcoded that way, # src/windows/glog/*.h to match src/windows/config.h.
# and we need to propagate those defines to binaries/libraries linking defines = ["GOOGLE_GLOG_DLL_DECL=__declspec(dllexport)"],
# against glog.
defines = [
"GOOGLE_GLOG_IS_A_DLL=1",
"GOOGLE_GLOG_DLL_DECL=__declspec(dllexport)",
"GOOGLE_GLOG_DLL_DECL_FOR_UNITTEST=__declspec(dllimport)",
],
deps = [":strip_include_prefix_hack"], deps = [":strip_include_prefix_hack"],
) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment