Skip to content

G
gflags
Switch branch/tag
  1. 03 Nov, 2011 1 commit
    • Craig Silverstein's avatar
      NOTE: I'm checking this in just to have a record in source control of the idea. … · 874aed5d
      Craig Silverstein authored 
      NOTE: I'm checking this in just to have a record in source control of the idea.  We've decided for now it doesn't make sense to go forward with flag categories -- and the __VA_ARGS__ for macros has caused lots of problems with uncaught accidental commas, already -- so a future commit will back this out.  (Actually, it's all a series of commits, for annoying technical reasons.)

Add support for flag categories.

In this CL, all you can do is set categories in the DEFINE_*
macros and then retrieve them via GetCommandLineFlagInfo and
similar.

In future CLs, we will start to give some semantic meaning to
particular flag values, as described in the designdoc.  In
particular, we will start to use flag categories to revamp
--help output.

Implementation-wise: to keep categories an optional macro
argument, I had to use __VA_ARGS__, which means future gflags
releases will no longer work with MSVC 7.1.  We're at MSVC 10
now, so I'm pretty much ok with that.

The downside of __VA_ARGS__ is there is no error if you
specify more args after the ones we expect.  To get around
that, I only use __VA_ARGS_ in this idiom:
static const OptionalDefineArgs var = { __VA_ARGS__ };
The new OptionalDefineArgs struct defines all the args that
may be optionally specified in the DEFINE_* macros.  For now,
that's only the 'categories' arg, though in theory more could be
added later.

R=titus,ncalvin
DELTA=92  (54 added, 3 deleted, 35 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=3057


git-svn-id: https://gflags.googlecode.com/svn/trunk@61 6586e3c6-dcc4-952a-343f-ff74eb82781d
      874aed5d
  3. 18 Aug, 2011 1 commit
  5. 04 Aug, 2011 2 commits
  7. 30 Jul, 2011 2 commits
    • Craig Silverstein's avatar
      Ready to release gflags 1.6! · 404970d6
      Craig Silverstein authored 
      * google-gflags: version 1.6
* BUGFIX: Fix a bug where we were leaving out a required $(top_srcdir)
* Fix definition of clstring (jyrki)
* Split up flag declares into its own file (jyrki)
* Add --version support (csilvers)
* Update teh README for gflags with static libs
* Update acx_pthread.m4 for nostdlib
* Change REparseCommandLineFlags to return void (csilvers)
* Some doc typofixes and example augmentation (various)

R=jperkins
DELTA=44  (41 added, 0 deleted, 3 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=2838


git-svn-id: https://gflags.googlecode.com/svn/trunk@56 6586e3c6-dcc4-952a-343f-ff74eb82781d
      404970d6
    • Craig Silverstein's avatar
      It turns out we don't want all this dll-decl stuff for mingw. · a923d333
      Craig Silverstein authored 
      So make the #ifdef correct for mscv-but-not-mingw.

I think the right fix would be to take all this logic out and
insert it via a MOE directive, just for the windows versions
of these files.  This is what ctemplate does.  But it's a
more-major change, and I'm looking to get this release out
today, so I'm submitting this (TBR), since it's a much more
minor change.


Revision created by MOE tool push_codebase.
MOE_MIGRATION=2837


git-svn-id: https://gflags.googlecode.com/svn/trunk@55 6586e3c6-dcc4-952a-343f-ff74eb82781d
      a923d333
  9. 29 Jul, 2011 4 commits
    • Craig Silverstein's avatar
      mingw fixes: · 357b3d9d
      Craig Silverstein authored 
      1) mingw needs an #include to have access to mkdir.

2) It needs to always #include port.h (this is an identical
bit of code, in configure.ac, that I have in other opensource
projects for mingw support.)

3) I moved some code from port.cc to port.h, so I didn't have
to add logic to link in port.cc for mingw.

Last change before new release!  (*knock on wood*)  Submitting
TBR so I can get the release out today.  This isn't exactly a
trivial change, so I'm chary to submit TBR, but it's pretty
isolated to windows and mingw, and I've tested on those
platforms to make sure they compile and all tests pass.

DELTA=70  (37 added, 30 deleted, 3 changed)


Revision created by MOE tool push_codebase.
MOE_MIGRATION=2823


git-svn-id: https://gflags.googlecode.com/svn/trunk@54 6586e3c6-dcc4-952a-343f-ff74eb82781d
      357b3d9d
    • Craig Silverstein's avatar
      A few autotools files that it loosk like aren't needed by the latest · b5cdac99
      Craig Silverstein authored 
      version of autotools (taht we're using now).  Get rid of them to clean
up the svn tree.  Also get rid of the 'python' file -- I don't know
what that is, but it's been a long time since the python version of
gflags has moved to its own project.


git-svn-id: https://gflags.googlecode.com/svn/trunk@53 6586e3c6-dcc4-952a-343f-ff74eb82781d
      b5cdac99
    • Craig Silverstein's avatar
      Some reorganization that results from a new method I'm moving to to · 917f4e7b
      Craig Silverstein authored 
      maintaining this opensource tree.  Some of this reorganization is
entirely a result of reorganization: blank lines in a few different
places, etc.  Here are the others:

1) I've added a new file, util.h, with lots of new, helpful routines,
most notably StringPrintf (printf returning a string).  I've also
moved some routines from the .cc and unittest.cc file here, such as
the CHECK macros, testing framework, and #ifdefs for 16-bit ints.
Quite a bit of code was rewritten to use these new routines.

2) I noticed that the special-case setenv() code was only needed for
windows systems, so I moved it to port.h/cc.

3) I also had to add a new vsnprintf wrapper in port.h/cc, to support
StringPrintf.

4) A few places I used an old name, commandlineflags, instead of
gflags.  Most or all of these should be fixed now.

5) Some of my copyright dates weren't quite right.  Fixed them up.

6) In some .cc files, I added using directives to not have to use
std:: so much.

7) I've added a minor new test, adding 10000 or so flags to see how
the system scales.

8) Some compile-warning fixes, such as int -> size_t when appropriate,
and better protected #defines in mutex.h

9) The .h files gained some logic defining GFLAGS_DLL_DECL.  This is
true even for .h files outside the windows directory, which will never
have these dll issues.  But one big advantage of my new organization
is auto-generating the windows versions of these files from the unix
versions, so there's some unnecessary (but harmless) duplication as a
result.

10) Fixed a bug in rpm.sh which would cause an unnecessary crash when
dpkg was missing.


git-svn-id: https://gflags.googlecode.com/svn/trunk@52 6586e3c6-dcc4-952a-343f-ff74eb82781d
      917f4e7b
    • Craig Silverstein's avatar
      Update to automake 1.10.1 (from 1.9), and downdate to autoconf 2.62 · b7ea0659
      Craig Silverstein authored 
      (from 2.65).  I'm moving to a new system for maintaining the
opensource version, which involves using a 'hermetic' version of
autotools, and those are the versions installed in the hermetic
system.  There shouldn't be a user-noticeable change here.


git-svn-id: https://gflags.googlecode.com/svn/trunk@51 6586e3c6-dcc4-952a-343f-ff74eb82781d
      b7ea0659
  11. 28 Jul, 2011 1 commit
  13. 19 May, 2011 1 commit
  15. 21 Apr, 2011 1 commit
  17. 03 Mar, 2011 1 commit
  19. 02 Mar, 2011 1 commit
  21. 25 Jan, 2011 1 commit
  23. 14 Jan, 2011 1 commit
  25. 16 Nov, 2010 1 commit
  27. 14 Oct, 2010 1 commit
    • Craig Silverstein's avatar
      Wed Oct 13 17:40:12 2010 Google Inc. <opensource@google.com> · 3c624b70
      Craig Silverstein authored 
      	* google-gflags: version 1.4
	* Add a check to prevent passing 0 to DEFINE_string (jorg)
	* Reduce compile (.o) size (jyrki)
	* Some small changes to quiet debug compiles (alexk)
	* PORTING: better support static linking on windows (csilvers)
	* DOCUMENTATION: change default values, use validators, etc.
	* Update the NEWS file to be non-empty
	* Add pkg-config (.pc) files for libgflags and libgflags_nothreads


git-svn-id: https://gflags.googlecode.com/svn/trunk@40 6586e3c6-dcc4-952a-343f-ff74eb82781d
      3c624b70
  29. 16 Sep, 2010 1 commit
  31. 07 May, 2010 1 commit
  33. 10 Mar, 2010 1 commit
  35. 05 Jan, 2010 1 commit
    • Craig Silverstein's avatar
      Mon Jan 4 18:09:30 2010 Google Inc. <opensource@google.com> · 31c8edc5
      Craig Silverstein authored 
      	* google-gflags: version 1.3
	* PORTABILITY: can now build and run tests under MSVC (csilvers)
	* Remove the python gflags code, which is now its own package (tansell)
	* Clarify that "last flag wins" in the docs (csilvers)
	* Comment danger of using GetAllFlags in validators (wojtekm)
	* PORTABILITY: Some fixes necessary for c++0x (mboerger)
	* Makefile fix: $(srcdir) -> $(top_srcdir) in one place (csilvres)
	* INSTALL: autotools to autoconf v2.64 + automake v1.11 (csilvers)


git-svn-id: https://gflags.googlecode.com/svn/trunk@35 6586e3c6-dcc4-952a-343f-ff74eb82781d
      31c8edc5
  37. 10 Nov, 2009 1 commit
  39. 11 Sep, 2009 1 commit
  41. 17 Jul, 2009 1 commit
  43. 15 Apr, 2009 1 commit
    • Craig Silverstein's avatar
      Tue Apr 14 12:35:25 2009 Google Inc. <opensource@google.com> · 5a3c7f85
      Craig Silverstein authored 
      	* google-gflags: version 1.1
	* Add both foo and nofoo for boolean flags, with --undefok (andychu)
	* Better document how validators work (wojtekm)
	* Improve binary-detection for bash-completion (mtamsky)
	* Python: Add a concept of "key flags", used with --help (salcianu)
	* Python: Robustify flag_values (salcianu)
	* Python: Add a new DEFINE_bool alias (keir, andrewliu)
	* Python: Do module introspection based on module name (dsturtevant)
	* Fix autoconf a bit better, especially on windows and solaris (ajenjo)
	* BUG FIX: gflags_nothreads was linking against the wrong lib (ajenjo)
	* BUG FIX: threads-detection failed on FreeBSD; replace it (ajenjo)
	* PORTABILITY: Quiet an internal compiler error with SUSE 10 (csilvers)
	* PORTABILITY: Update deb.sh for more recenty debuilds (csilvers)
	* PORTABILITY: #include more headers to satify new gcc's (csilvers)
	* INSTALL: Updated to autoconf 2.61 and libtool 1.5.26 (csilvers)


git-svn-id: https://gflags.googlecode.com/svn/trunk@29 6586e3c6-dcc4-952a-343f-ff74eb82781d
      5a3c7f85
  45. 19 Sep, 2008 1 commit
    • Craig Silverstein's avatar
      Thu Sep 18 12:58:05 2008 Google Inc. <opensource@google.com> · e0b71e57
      Craig Silverstein authored 
      	* google-gflags: version 1.0rc2
	* Report current flag values in --helpxml (hdn)
	* Fix compilation troubles with gcc 4.3.3 (simonb)
	* BUG FIX: I was missing a std:: in DECLARE_string (csilvers)
	* BUG FIX: Clarify in docs how to specify --bool flags (csilvers)
	* BUG FIX: Fix --helpshort for source files not in a subdir (csilvers)
	* BUG FIX: Fix python unittest for 64-bit builds (bcmills)


git-svn-id: https://gflags.googlecode.com/svn/trunk@27 6586e3c6-dcc4-952a-343f-ff74eb82781d
      e0b71e57
  47. 21 Aug, 2008 1 commit
    • Craig Silverstein's avatar
      Tue Aug 19 16:15:48 2008 Google Inc. <opensource@google.com> · 67914687
      Craig Silverstein authored 
      	* google-gflags: version 1.0rc1
	* Move #include files from google/ to gflags/ (csilvers)
	* Small optimizations to reduce binary (library) size (jyrki)
	* BUGFIX: forgot a std:: in one of the .h files (csilvers)
	* Speed up locking by making sure calls are inlined (ajenjo)
	* 64-BIT COMPATIBILITY: Use %PRId64 instead of %lld (csilvers)
	* PORTABILITY: fix Makefile to work with Cygwin (ajenjo)
	* PORTABILITY: fix code to compile under Visual Studio (ajenjo)
	* PORTABILITY: fix code to compile under Solaris 10 with CC (csilvers)


git-svn-id: https://gflags.googlecode.com/svn/trunk@25 6586e3c6-dcc4-952a-343f-ff74eb82781d
      67914687
  49. 22 Jul, 2008 1 commit
    • Craig Silverstein's avatar
      Mon Jul 21 23:01:38 2008 Google Inc. <opensource@google.com> · c79c32d9
      Craig Silverstein authored 
      	* google-gflags: version 0.9
	* Add the ability to validate a command-line flag (csilvers)
	* Add completion support for commandline flags in bash (daven)
	* Add -W compile flags to Makefile, when using gcc (csilvers)
	* Allow helpstring to be NULL (cristianoc)
	* Improved documentation of classes in the .cc file (csilvers)
	* Fix python bug with AppendFlagValues + shortnames (jjtswan)
	* Use bool instead of int for boolean flags in gflags.py (bcmills)
	* Simplify the way we declare flags, now more foolproof (csilvers)
	* Better error messages when bool flags collide (colohan)
	* Only evaluate DEFINE_foo macro args once (csilvers)


git-svn-id: https://gflags.googlecode.com/svn/trunk@23 6586e3c6-dcc4-952a-343f-ff74eb82781d
      c79c32d9
  51. 27 Mar, 2008 1 commit
  53. 18 Oct, 2007 1 commit
    • Craig Silverstein's avatar
      Thu Oct 18 11:33:20 2007 Google Inc. <opensource@google.com> · 585a44a0
      Craig Silverstein authored 
      	* google-gflags: version 0.7
	* Deal even more correctly with libpthread not linked in (csilvers)
	* Add STRIP_LOG, an improved DO_NOT_SHOW_COMMANDLINE_HELP (sioffe)
	* Be more accurate printing default flag values in --help (dsturtevant)
	* Reduce .o file size a bit by using shorter namespace names (jeff)
	* Use relative install path, so 'setup.py --home' works (csilvers)
	* Notice when a boolean flag has a non-boolean default (bnmouli)
	* Broaden --helpshort to match foo-main.cc and foo_main.cc (hendrie)
	* Fix "no modules match" message for --helpshort, etc (hendrie)


git-svn-id: https://gflags.googlecode.com/svn/trunk@19 6586e3c6-dcc4-952a-343f-ff74eb82781d
      585a44a0
  55. 15 Aug, 2007 1 commit
  57. 12 Jun, 2007 1 commit
  59. 20 Apr, 2007 1 commit
  61. 28 Mar, 2007 1 commit
  63. 22 Mar, 2007 2 commits
  65. 21 Mar, 2007 2 commits