Skip to content

G
gflags
Commit fe57e5af authored by Andreas Schuh's avatar Andreas Schuh Committed by GitHub
Browse files
Options

Merge pull request #156 from dreamer-dead/fix-flag-value-typename 

Fix incorrect flag value typename for uint32.
parents 2e4159fb fa266383
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 3 deletions
src/gflags.cc
View file @ fe57e5af
...@@ -409,7 +409,7 @@ const char* FlagValue::TypeName() const { ...@@ -409,7 +409,7 @@ const char* FlagValue::TypeName() const {
static const char types[] = static const char types[] =
"bool\0xx" "bool\0xx"
"int32\0x" "int32\0x"
"uin32\0x" "uint32\0"
"int64\0x" "int64\0x"
"uint64\0" "uint64\0"
"double\0" "double\0"
......
test/gflags_unittest.cc
View file @ fe57e5af
...@@ -601,7 +601,7 @@ TEST(SetFlagValueTest, IllegalValues) { ...@@ -601,7 +601,7 @@ TEST(SetFlagValueTest, IllegalValues) {
SetCommandLineOption("test_bool", "12")); SetCommandLineOption("test_bool", "12"));
EXPECT_EQ("", EXPECT_EQ("",
SetCommandLineOption("test_uint32", "1970")); SetCommandLineOption("test_uint32", "-1970"));
EXPECT_EQ("", EXPECT_EQ("",
SetCommandLineOption("test_int32", "7000000000000")); SetCommandLineOption("test_int32", "7000000000000"));
...@@ -862,7 +862,7 @@ TEST(FlagSaverTest, CanSaveVariousTypedFlagValues) { ...@@ -862,7 +862,7 @@ TEST(FlagSaverTest, CanSaveVariousTypedFlagValues) {
EXPECT_EQ(2, FLAGS_test_uint32); EXPECT_EQ(2, FLAGS_test_uint32);
EXPECT_EQ(-3, FLAGS_test_int64); EXPECT_EQ(-3, FLAGS_test_int64);
EXPECT_EQ(4, FLAGS_test_uint64); EXPECT_EQ(4, FLAGS_test_uint64);
EXPECT_DOUBLE_EQ(4.0, FLAGS_test_double); EXPECT_DOUBLE_EQ(5.0, FLAGS_test_double);
EXPECT_EQ("good", FLAGS_test_string); EXPECT_EQ("good", FLAGS_test_string);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment