- 23 Apr, 2016 1 commit
-
-
rw authored
-
- 22 Apr, 2016 5 commits
-
-
Wouter van Oortmerssen authored
Fix for #3849
-
-
Wouter van Oortmerssen authored
Change-Id: I1aef5fdba72de0c3bb8276c9f50fffa494f26e29 Tested: on Linux.
-
Wouter van Oortmerssen authored
Change-Id: Ie60f01d935ca6b4aa6ce0eab7598602ac0758342 Tested: on Linux.
-
pjulien authored
This avoids the following allocations over repeated use: - A ``CharsetEncoder`` - A byte array to contain the contents of the string - A wrapper, via ``ByteBuffer#wrap``, for the previously mentioned byte array This also removes a copy of the temporary byte array. This extra copy is needed because ``String#getBytes`` returns a byte array and its length must match the exact size of the contents. This implementation requires that the builder retain a ``ByteBuffer`` and ``CharEncoder``. This is considered slower only for users that will only allocate a single string in their buffers or none at all. The improvement is especially potent if the builder is constantly reused by its caller. This also eliminates the penalty for users that do not use strings at all since the cost of allocating these fields is now amortized. The only allocation left in this code is a ``CharBuffer`` wrapper. It's possible to eliminate this allocation using an additional copy but need further profiling to see which is the bigger problem.
-
- 20 Apr, 2016 1 commit
-
-
Wouter van Oortmerssen authored
Change-Id: I8dcbb5e93836356511d411ef86452babd3dd3c0b Tested: on Linux.
-
- 18 Apr, 2016 2 commits
-
-
Wouter van Oortmerssen authored
Fix for 3847
-
Wouter van Oortmerssen authored
A previous commit that added "f" for C++/Java/C# would break on gcc of constants like 3f, which are now output as 3.0f Tested: on Linux Change-Id: If9cabbe3c6d6948a5050b8b123bda9c06e181f52
-
- 17 Apr, 2016 1 commit
-
-
pjulien authored
-
- 14 Apr, 2016 2 commits
-
-
-
Wouter van Oortmerssen authored
Bug: 28145201 Change-Id: I5a1818c40c2f4fbd00cfec3362040407976f7a39 Tested: on Linux.
-
- 13 Apr, 2016 3 commits
-
-
Wouter van Oortmerssen authored
Stop CreateUninitializedVector returning a pointer to invalid memory.
-
Nnamdi authored
CreateUninitializedVector was performing the following actions: 1. call StartVector. 2. call make_space, and set buf to point to the reserved space. 3. call EndVector. The problem is that a call to EndVector can ultimately call make_space, which if the buffer is full, will cause a reallocation, invalidating the value stored in buf. So setting buf needs to be delayed until after EndVector. The following code, when run under valgrind shows a write to free'd memory before the change, but no such error after: int main() { flatbuffers::FlatBufferBuilder fbb(128); char *buf = nullptr; fbb.CreateUninitializedVector(128, &buf); *buf = 0; }
-
Wouter van Oortmerssen authored
Change-Id: I3730a6823d603982c4250d514e827e3f93d1f81e Tested: on Linux.
-
- 12 Apr, 2016 1 commit
-
-
Wouter van Oortmerssen authored
Tested: on Linux. Bug: 27923233 Change-Id: Ic16675650e4a8e138c163f1e2131a3aad7008ada
-
- 11 Apr, 2016 3 commits
-
-
-
Wouter van Oortmerssen authored
Change-Id: If34aef46ef619e06de799cff14948b02e98da86d Tested: on Linux.
-
Wouter van Oortmerssen authored
This was harmless, but unnecessary. Change-Id: I1365a725e254d4ebbda081110a50277cb5118323 Tested: on Linux.
-
- 08 Apr, 2016 4 commits
-
-
Wouter van Oortmerssen authored
Allow builds on platforms with unsigned chars by default
-
Wouter van Oortmerssen authored
Remove unnecessary condition in AssertOffsetAndLength.
-
Wojciech Jaszczak authored
Condition is already checked and covered in the following condition, the second one was excess. Signed-off-by:
Wojciech Jaszczak <jaszczakw@gmail.com>
-
Wouter van Oortmerssen authored
Documentation for C bindings
-
- 07 Apr, 2016 1 commit
-
-
Mikkel Fahnøe Jørgensen authored
-
- 05 Apr, 2016 2 commits
-
-
Wouter van Oortmerssen authored
-
Wouter van Oortmerssen authored
-
- 04 Apr, 2016 8 commits
-
-
-
Wouter van Oortmerssen authored
Fix build on Cygwin
-
Wouter van Oortmerssen authored
to allow for custom file loaders. The targeted use case is android runtime. (from CL 116980408) Change-Id: I8785c0acf714fab41d8f6fc9f1c52875423b8f5b
-
Wouter van Oortmerssen authored
(from CL 116785833) Change-Id: I0fb0e1318fd70cba51e229a93f535c6639bbb331
-
Wouter van Oortmerssen authored
(from CL 117010760) Change-Id: I0ee77cf87d0cb00b94887356745b85423b1375a6
-
Wouter van Oortmerssen authored
This overflow could allow malformed FlatBuffers to pass the verifier. Change-Id: Ia993299a761b00b93e53e8aff2689b631755763c Tested: on Linux. Bug: 27903580
-
Wouter van Oortmerssen authored
-
Mikkel Fahnøe Jørgensen authored
-
- 03 Apr, 2016 1 commit
-
-
Mikkel Fahnøe Jørgensen authored
-
- 02 Apr, 2016 1 commit
-
-
Tony Kelman authored
use -std=gnu++11 instead of c++0x on cygwin to avoid error: realpath was not declared in this scope ref http://www.cygwin.com/ml/cygwin/2016-03/msg00005.html
-
- 30 Mar, 2016 2 commits
-
-
Wouter van Oortmerssen authored
Implement __vector_as_bytes and methods to get [ubyte] efficiently
-
Wouter van Oortmerssen authored
Added --gen-name-strings command line option.
-
- 29 Mar, 2016 2 commits
-
-
Nnamdi authored
To support the use case described in issue google/flatbuffers#3826, a new command line option --gen-name-strings has been added, which will cause a static GetFullyQualifiedName function to be added to the C++ output for tables/structs.
-
Armen Baghumian authored
Currently in order to get a value type of [ubyte] in PHP, iteration is necessary which is not efficient. Helper __vector_as_bytes has been implemented in order to return the byte arrays in PHP efficiently. Appropriate methods also been added to use aforementioned method to return the byte array. (e.g. get*Bytes()). The reason the methods are named get*Bytes() and not for instance get*ByteArray() is the fact that PHP doesn't support byte arrays and the binary safe string implementation in PHP is used to simulate byte arrays and since there is chance for PHP users to confuse this with PHP arrays the name get*Bytes() has been chosen. In the future __vector_as_bytebuffer() method can also be implemented to return PHP implementation of ByteBuffer.
-