1. 19 Jan, 2020 1 commit
    • Max Burke's avatar
      [rust] Add use declarations to Rust-generated bindings for imported FB definitions (#5645) · 6da1cf79
      Max Burke authored
      * Bugfix for Rust generation of union fields named with language keywords
      
      Looking at ParseField, it appears that in the case of unions, an extra field with a `UnionTypeFieldSuffix` is added to the type definition, however, if the name of this field is a keyword in the target language, it isn't escaped.
      
      For example, if generating code for rust for a union field named `type`, flatc will generate a (non-keyword escaped) field named `type_type` for this hidden union field, and one (keyword escaped) called `type_` for the actual union contents.
      
      When the union accessors are generated, they refer to this `type_type` field, but they will escape it mistakenly, generating code like this:
      
      ```
        #[inline]
        #[allow(non_snake_case)]
        pub fn type__as_int(&self) -> Option<Int<'a>> {
          if self.type__type() == Type::Int {
            self.type_().map(|u| Int::init_from_table(u))
          } else {
            None
          }
        }
      ```
      
      Which will fail to build because the field is called `self.type_type()`, not `self.type__type()`.
      
      * [Rust] Add crate-relative use statements for FBS includes.
      
      At present if a flatbuffer description includes a reference to a type in
      another file, the generated Rust code needs to be hand-modified to add
      the appropriate `use` statements.
      
      This assumes that the dependencies are built into the same crate, which
      I think is a reasonable assumption?
      
      * Revert "[Rust] Add crate-relative use statements for FBS includes."
      
      This reverts commit d554d79fecf5afd6da6fb993b30b4cd523a5889a.
      
      * Add updated generated test files.
      
      * Fixing Rust test harness to handle new includes.
      
      Test binaries need to add references to generated code that's
      transitively included.
      
      This also has the knock-on in that this code (which is referenced by
      include directives directly in the flatbuffer schema files) also needs
      to be generated, hence the changes to generate_code.sh.
      
      * Test harnesses expect test data to be checked in.
      
      Put include_test2 files into the same directory as the include_test2
      schema definition.
      
      Update all code generation scripts (forgot the batch file from last
      time).
      
      Path updates in Rust test.
      
      * Include updated generated code
      
      * Address comments raised in PR
      
      * Fix failing Rust tests.
      
      * Previous merge clobbered this branch change.
      
      * Add updated imports to benchmarks.
      
      * Clarifying comment per PR request
      
      * Update documentation comments per feedback
      
      * Remove non-Rust generated files for include tests, per feedback from @rw/@aardappel
      
      * Broken code generation batch file
      
      * Fix typo
      
      * Add TODO for tidying up use declaration traversal sometime in the future
      
      * Update test files.
      6da1cf79
  2. 17 Jan, 2020 1 commit
  3. 16 Jan, 2020 2 commits
  4. 13 Jan, 2020 1 commit
  5. 09 Jan, 2020 3 commits
    • mustiikhalil's avatar
      [Swift] Swift implementation 🎉🎉 (#5603) · 04d80f25
      mustiikhalil authored
      * Implemented the swift version of Flatbuffers
      
      Implemented serailzing, reading, and mutating data from object monster
      
      Fixes mis-aligned pointer issue
      
      Fixes issue when shared strings are removed from table
      
      Adds swift enum, structs code gen
      
      Fixed namespace issues + started implementing the table gen
      
      Added Mutate function to the code generator
      
      Generated linux test cases
      
      Fixed an issue with bools, and structs readers in table writer
      
      Swift docker image added
      
      Updated the test cases, and removed a method parameters in swift
      
      Fixed createVector api when called with scalars
      
      Fixed issues with scalar arrays, and fixed the code gen namespaces, added sample_binary.swift
      
      Cleaned up project
      
      Added enum vectors, and their readers
      
      Refactored code
      
      Added swift into the support document
      
      Added documentation in docs, and fixed a small issue with Data() not being returned correctly
      
      Fixes Lowercase issue, and prevents generating lookups for deprecated keys
      
      * Made all the required funcs to have const + removed unneeded code + fix lowercase func
      
      * Removed transform from lowercased and moved it to function
      
      * Fixes an issue with iOS allocation from read
      
      * Refactored cpp code to be more readable
      
      * casts position into int for position
      
      * Fix enums issue, moves scalar writer code to use memcpy
      
      * Removed c_str from struct function
      
      * Fixed script to generate new objects when ran on travis ci: fix
      
      * Handles deallocating space allocated for structs
      
      * Updated the test cases to adhere to the fileprivate lookup, no mutation for unions, and updated the names of the vector functions
      04d80f25
    • Wouter van Oortmerssen's avatar
      Changed direct calls to strtod to use StringToNumber · 55686100
      Wouter van Oortmerssen authored
      StringToNumber will correctly use locale-insensitive functions
      when available.
      
      Change-Id: I6bde11039a541634186f8f791012af2eb0d86b8d
      55686100
    • emkornfield's avatar
  6. 06 Jan, 2020 3 commits
  7. 02 Jan, 2020 3 commits
    • Robert Winslow's avatar
      Rust: Temporarily disable 2 endianness unit tests (#5695) · 3b458f7a
      Robert Winslow authored
      Rare failures occur on AppVeyor in these functions; the failures appear
      spurious.
      3b458f7a
    • David P. Sicilia's avatar
      [C++17] Add Traits class for Tables and Factory function within it. (#5678) · a5d9d0f7
      David P. Sicilia authored
      * Include flattests_cpp17 in unit tests when C++17 build is enabled.
      
      * [C++17] Generate generic table factory function.
      
      1. For each table, generate a convenient free-standing factory
         function that allows creating the table in a generic way by
         specifying only the type.  This is the first change in a series
         of changes to make Flatbuffers generated C++ code more friendly
         to code bases that make use of C++ template metaprogramming
         techniques to manage the serialization process.  Example:
      
           Before :(
      
             // The name of the Flatbuffers type (and namespace) must
             // be hard-coded when writing the factory function.
             auto monster = MyGame::Example::CreateMonster(fbb, ...);
      
           After  :)
      
             using type_to_create = MyGame::Example::Monster;
             // No namespace needed on CreateByTagType.
             auto monster = CreateByTagType((type_to_create*)nullptr,
                                            fbb, ...);
      
         This feature requires building with C++14 or greater, and thus
         it is guarded behind --cpp-std >= c++17 in the flatbuffers C++
         generator.
      
      2. Fix a CMake bug to include C++17 unit tests in test suite.
      
      * [C++17] Replace standalone variadic factory function with type_traits.
      
      Add a `type_traits` to each table class.  This `type_traits` can be
      populated with various compile-time info about the table.  Initially,
      we have the Create* function and type, but is extensible in the future.
      
      * Remove empty line and fix stale comments.
      
      * Rename type_traits to Traits and move fwd declaration.
      
      * Fix parameter evaluation order issue and use lambda for scope.
      a5d9d0f7
    • Wouter van Oortmerssen's avatar
      Removed code_generators.cpp from library targets · 3cd9b643
      Wouter van Oortmerssen authored
      Change-Id: Ia6e032a77983bf1838b8675f51d1c910acc991d8
      3cd9b643
  8. 31 Dec, 2019 1 commit
    • Max Burke's avatar
      [rust] Make enum names public (#5690) · 355dfd48
      Max Burke authored
      * Bugfix for Rust generation of union fields named with language keywords
      
      Looking at ParseField, it appears that in the case of unions, an extra field with a `UnionTypeFieldSuffix` is added to the type definition, however, if the name of this field is a keyword in the target language, it isn't escaped.
      
      For example, if generating code for rust for a union field named `type`, flatc will generate a (non-keyword escaped) field named `type_type` for this hidden union field, and one (keyword escaped) called `type_` for the actual union contents.
      
      When the union accessors are generated, they refer to this `type_type` field, but they will escape it mistakenly, generating code like this:
      
      ```
        #[inline]
        #[allow(non_snake_case)]
        pub fn type__as_int(&self) -> Option<Int<'a>> {
          if self.type__type() == Type::Int {
            self.type_().map(|u| Int::init_from_table(u))
          } else {
            None
          }
        }
      ```
      
      Which will fail to build because the field is called `self.type_type()`, not `self.type__type()`.
      
      * [Rust] Add crate-relative use statements for FBS includes.
      
      At present if a flatbuffer description includes a reference to a type in
      another file, the generated Rust code needs to be hand-modified to add
      the appropriate `use` statements.
      
      This assumes that the dependencies are built into the same crate, which
      I think is a reasonable assumption?
      
      * Revert "[Rust] Add crate-relative use statements for FBS includes."
      
      This reverts commit d554d79fecf5afd6da6fb993b30b4cd523a5889a.
      
      * Address comments raised in PR
      
      * Update documentation comments per feedback
      
      * Fix typo
      
      * [rust] Make enum variant names public.
      
      * Update generated test files
      
      * Add test for public enum names
      355dfd48
  9. 30 Dec, 2019 1 commit
  10. 27 Dec, 2019 1 commit
  11. 26 Dec, 2019 6 commits
  12. 24 Dec, 2019 3 commits
  13. 23 Dec, 2019 6 commits
  14. 18 Dec, 2019 1 commit
  15. 17 Dec, 2019 2 commits
  16. 15 Dec, 2019 1 commit
    • Max Burke's avatar
      Bugfix for Rust generation of union fields named with language keywords (#5592) · eddebec1
      Max Burke authored
      * Bugfix for Rust generation of union fields named with language keywords
      
      Looking at ParseField, it appears that in the case of unions, an extra field with a `UnionTypeFieldSuffix` is added to the type definition, however, if the name of this field is a keyword in the target language, it isn't escaped.
      
      For example, if generating code for rust for a union field named `type`, flatc will generate a (non-keyword escaped) field named `type_type` for this hidden union field, and one (keyword escaped) called `type_` for the actual union contents.
      
      When the union accessors are generated, they refer to this `type_type` field, but they will escape it mistakenly, generating code like this:
      
      ```
        #[inline]
        #[allow(non_snake_case)]
        pub fn type__as_int(&self) -> Option<Int<'a>> {
          if self.type__type() == Type::Int {
            self.type_().map(|u| Int::init_from_table(u))
          } else {
            None
          }
        }
      ```
      
      Which will fail to build because the field is called `self.type_type()`, not `self.type__type()`.
      
      * [Rust] Add crate-relative use statements for FBS includes.
      
      At present if a flatbuffer description includes a reference to a type in
      another file, the generated Rust code needs to be hand-modified to add
      the appropriate `use` statements.
      
      This assumes that the dependencies are built into the same crate, which
      I think is a reasonable assumption?
      
      * Revert "[Rust] Add crate-relative use statements for FBS includes."
      
      This reverts commit d554d79fecf5afd6da6fb993b30b4cd523a5889a.
      
      * Address comments raised in PR
      
      * Update documentation comments per feedback
      
      * Fix typo
      eddebec1
  17. 13 Dec, 2019 1 commit
  18. 09 Dec, 2019 2 commits
  19. 06 Dec, 2019 1 commit
    • cryptocode's avatar
      Add --force-empty-vectors option (#5653) · a8e800bd
      cryptocode authored
      The rationale for this option is that JSON clients typically want empty arrays (i.e [] in the JSON) instead of missing properties, but not empty strings when the value isn't set.
      --force-empty is kept as-is, i.e. it will force both empty strings and vectors.
      
      Closes #5652
      a8e800bd