Commit aaa89429 authored by Matias Cudich's avatar Matias Cudich Committed by Wouter van Oortmerssen

Update JavaScript IDL generator to remove invalid Closure JSDoc comments (#4873)

* Update JavaScript IDL generator to remove invalid Closure JSDoc comments

* Revert erroneous changes

* A few more tweaks

* Updated generated code
parent 12e5cf0b
This diff is collapsed.
No preview for this file type
This diff is collapsed.
......@@ -6,8 +6,8 @@ library my_game.example2;
import 'dart:typed_data' show Uint8List;
import 'package:flat_buffers/flat_buffers.dart' as fb;
import './monster_test_my_game.example_generated.dart' as my_game_example;
import './monster_test_my_game_generated.dart' as my_game;
import './monster_test_my_game.example_generated.dart' as my_game_example;
class Monster {
Monster._(this._bc, this._bcOffset);
......
......@@ -6,8 +6,8 @@ library my_game;
import 'dart:typed_data' show Uint8List;
import 'package:flat_buffers/flat_buffers.dart' as fb;
import './monster_test_my_game.example_generated.dart' as my_game_example;
import './monster_test_my_game.example2_generated.dart' as my_game_example2;
import './monster_test_my_game.example_generated.dart' as my_game_example;
class InParentNamespace {
InParentNamespace._(this._bc, this._bcOffset);
......
......@@ -2,13 +2,14 @@
package NamespaceB
type EnumInNestedNS = int8
const (
EnumInNestedNSA = 0
EnumInNestedNSB = 1
EnumInNestedNSC = 2
EnumInNestedNSA EnumInNestedNS = 0
EnumInNestedNSB EnumInNestedNS = 1
EnumInNestedNSC EnumInNestedNS = 2
)
var EnumNamesEnumInNestedNS = map[int]string{
var EnumNamesEnumInNestedNS = map[EnumInNestedNS]string{
EnumInNestedNSA:"A",
EnumInNestedNSB:"B",
EnumInNestedNSC:"C",
......
......@@ -15,19 +15,13 @@ export enum EnumInNestedNS{
*/
export namespace NamespaceA.NamespaceB{
export class TableInNestedNS {
/**
* @type {flatbuffers.ByteBuffer}
*/
bb: flatbuffers.ByteBuffer|null = null;
/**
* @type {number}
*/
bb_pos:number = 0;
/**
* @param {number} i
* @param {flatbuffers.ByteBuffer} bb
* @returns {TableInNestedNS}
* @param number i
* @param flatbuffers.ByteBuffer bb
* @returns TableInNestedNS
*/
__init(i:number, bb:flatbuffers.ByteBuffer):TableInNestedNS {
this.bb_pos = i;
......@@ -36,16 +30,16 @@ __init(i:number, bb:flatbuffers.ByteBuffer):TableInNestedNS {
};
/**
* @param {flatbuffers.ByteBuffer} bb
* @param {TableInNestedNS=} obj
* @returns {TableInNestedNS}
* @param flatbuffers.ByteBuffer bb
* @param TableInNestedNS= obj
* @returns TableInNestedNS
*/
static getRootAsTableInNestedNS(bb:flatbuffers.ByteBuffer, obj?:TableInNestedNS):TableInNestedNS {
return (obj || new TableInNestedNS).__init(bb.readInt32(bb.position()) + bb.position(), bb);
};
/**
* @returns {number}
* @returns number
*/
foo():number {
var offset = this.bb!.__offset(this.bb_pos, 4);
......@@ -53,8 +47,8 @@ foo():number {
};
/**
* @param {number} value
* @returns {boolean}
* @param number value
* @returns boolean
*/
mutate_foo(value:number):boolean {
var offset = this.bb!.__offset(this.bb_pos, 4);
......@@ -68,23 +62,23 @@ mutate_foo(value:number):boolean {
};
/**
* @param {flatbuffers.Builder} builder
* @param flatbuffers.Builder builder
*/
static startTableInNestedNS(builder:flatbuffers.Builder) {
builder.startObject(1);
};
/**
* @param {flatbuffers.Builder} builder
* @param {number} foo
* @param flatbuffers.Builder builder
* @param number foo
*/
static addFoo(builder:flatbuffers.Builder, foo:number) {
builder.addFieldInt32(0, foo, 0);
};
/**
* @param {flatbuffers.Builder} builder
* @returns {flatbuffers.Offset}
* @param flatbuffers.Builder builder
* @returns flatbuffers.Offset
*/
static endTableInNestedNS(builder:flatbuffers.Builder):flatbuffers.Offset {
var offset = builder.endObject();
......@@ -98,19 +92,13 @@ static endTableInNestedNS(builder:flatbuffers.Builder):flatbuffers.Offset {
*/
export namespace NamespaceA.NamespaceB{
export class StructInNestedNS {
/**
* @type {flatbuffers.ByteBuffer}
*/
bb: flatbuffers.ByteBuffer|null = null;
/**
* @type {number}
*/
bb_pos:number = 0;
/**
* @param {number} i
* @param {flatbuffers.ByteBuffer} bb
* @returns {StructInNestedNS}
* @param number i
* @param flatbuffers.ByteBuffer bb
* @returns StructInNestedNS
*/
__init(i:number, bb:flatbuffers.ByteBuffer):StructInNestedNS {
this.bb_pos = i;
......@@ -119,15 +107,15 @@ __init(i:number, bb:flatbuffers.ByteBuffer):StructInNestedNS {
};
/**
* @returns {number}
* @returns number
*/
a():number {
return this.bb!.readInt32(this.bb_pos);
};
/**
* @param {number} value
* @returns {boolean}
* @param number value
* @returns boolean
*/
mutate_a(value:number):boolean {
var offset = this.bb!.__offset(this.bb_pos, 0);
......@@ -141,15 +129,15 @@ mutate_a(value:number):boolean {
};
/**
* @returns {number}
* @returns number
*/
b():number {
return this.bb!.readInt32(this.bb_pos + 4);
};
/**
* @param {number} value
* @returns {boolean}
* @param number value
* @returns boolean
*/
mutate_b(value:number):boolean {
var offset = this.bb!.__offset(this.bb_pos, 4);
......@@ -163,10 +151,10 @@ mutate_b(value:number):boolean {
};
/**
* @param {flatbuffers.Builder} builder
* @param {number} a
* @param {number} b
* @returns {flatbuffers.Offset}
* @param flatbuffers.Builder builder
* @param number a
* @param number b
* @returns flatbuffers.Offset
*/
static createStructInNestedNS(builder:flatbuffers.Builder, a: number, b: number):flatbuffers.Offset {
builder.prep(4, 8);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment