Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
F
flatbuffers
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
flatbuffers
Commits
36fe9d53
Commit
36fe9d53
authored
Feb 09, 2015
by
Wouter van Oortmerssen
Committed by
Android (Google) Code Review
Feb 09, 2015
Browse files
Options
Browse Files
Download
Plain Diff
Merge "Clarified how to create a good pull request." into ub-games-master
parents
6180b5ac
1fb0f1ef
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
0 deletions
+14
-0
CONTRIBUTING.md
CONTRIBUTING.md
+14
-0
No files found.
CONTRIBUTING.md
View file @
36fe9d53
...
...
@@ -23,6 +23,20 @@ frustration later on.
All submissions, including submissions by project members, require review. We
use Github pull requests for this purpose.
Some tips for good pull requests:
*
Use our code
[
style guide
](
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html
)
.
When in doubt, try to stay true to the existing code of the project.
*
Write a descriptive commit message. What problem are you solving and what
are the consequences? Where and what did you test? Some good tips:
[
here
](
http://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message
)
and
[
here
](
https://www.kernel.org/doc/Documentation/SubmittingPatches
)
.
*
If your PR consists of multiple commits which are successive improvements /
fixes to your first commit, consider squashing them into a single commit
(
`git rebase -i`
) such that your PR is a single commit on top of the current
HEAD. This make reviewing the code so much easier, and our history more
readable.
# The small print
Contributions made by corporations are covered by a different agreement than
the one above, the Software Grant and Corporate Contributor License Agreement.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment