Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
F
ffmpeg
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
ffmpeg
Commits
d97ca425
Commit
d97ca425
authored
Sep 27, 2011
by
Laurent Aimar
Committed by
Janne Grunau
Oct 18, 2011
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
sunrast: Check for out of bounds reads
Signed-off-by:
Janne Grunau
<
janne-libav@jannau.net
>
parent
6b1f93fa
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
1 deletion
+13
-1
sunrast.c
libavcodec/sunrast.c
+13
-1
No files found.
libavcodec/sunrast.c
View file @
d97ca425
...
@@ -46,6 +46,7 @@ static av_cold int sunrast_init(AVCodecContext *avctx) {
...
@@ -46,6 +46,7 @@ static av_cold int sunrast_init(AVCodecContext *avctx) {
static
int
sunrast_decode_frame
(
AVCodecContext
*
avctx
,
void
*
data
,
static
int
sunrast_decode_frame
(
AVCodecContext
*
avctx
,
void
*
data
,
int
*
data_size
,
AVPacket
*
avpkt
)
{
int
*
data_size
,
AVPacket
*
avpkt
)
{
const
uint8_t
*
buf
=
avpkt
->
data
;
const
uint8_t
*
buf
=
avpkt
->
data
;
const
uint8_t
*
buf_end
=
avpkt
->
data
+
avpkt
->
size
;
SUNRASTContext
*
const
s
=
avctx
->
priv_data
;
SUNRASTContext
*
const
s
=
avctx
->
priv_data
;
AVFrame
*
picture
=
data
;
AVFrame
*
picture
=
data
;
AVFrame
*
const
p
=
&
s
->
picture
;
AVFrame
*
const
p
=
&
s
->
picture
;
...
@@ -53,6 +54,9 @@ static int sunrast_decode_frame(AVCodecContext *avctx, void *data,
...
@@ -53,6 +54,9 @@ static int sunrast_decode_frame(AVCodecContext *avctx, void *data,
uint8_t
*
ptr
;
uint8_t
*
ptr
;
const
uint8_t
*
bufstart
=
buf
;
const
uint8_t
*
bufstart
=
buf
;
if
(
avpkt
->
size
<
32
)
return
AVERROR_INVALIDDATA
;
if
(
AV_RB32
(
buf
)
!=
0x59a66a95
)
{
if
(
AV_RB32
(
buf
)
!=
0x59a66a95
)
{
av_log
(
avctx
,
AV_LOG_ERROR
,
"this is not sunras encoded data
\n
"
);
av_log
(
avctx
,
AV_LOG_ERROR
,
"this is not sunras encoded data
\n
"
);
return
-
1
;
return
-
1
;
...
@@ -109,6 +113,9 @@ static int sunrast_decode_frame(AVCodecContext *avctx, void *data,
...
@@ -109,6 +113,9 @@ static int sunrast_decode_frame(AVCodecContext *avctx, void *data,
p
->
pict_type
=
AV_PICTURE_TYPE_I
;
p
->
pict_type
=
AV_PICTURE_TYPE_I
;
if
(
buf_end
-
buf
<
maplength
)
return
AVERROR_INVALIDDATA
;
if
(
depth
!=
8
&&
maplength
)
{
if
(
depth
!=
8
&&
maplength
)
{
av_log
(
avctx
,
AV_LOG_WARNING
,
"useless colormap found or file is corrupted, trying to recover
\n
"
);
av_log
(
avctx
,
AV_LOG_WARNING
,
"useless colormap found or file is corrupted, trying to recover
\n
"
);
...
@@ -143,8 +150,11 @@ static int sunrast_decode_frame(AVCodecContext *avctx, void *data,
...
@@ -143,8 +150,11 @@ static int sunrast_decode_frame(AVCodecContext *avctx, void *data,
uint8_t
*
end
=
ptr
+
h
*
stride
;
uint8_t
*
end
=
ptr
+
h
*
stride
;
x
=
0
;
x
=
0
;
while
(
ptr
!=
end
)
{
while
(
ptr
!=
end
&&
buf
<
buf_end
)
{
run
=
1
;
run
=
1
;
if
(
buf_end
-
buf
<
1
)
return
AVERROR_INVALIDDATA
;
if
((
value
=
*
buf
++
)
==
0x80
)
{
if
((
value
=
*
buf
++
)
==
0x80
)
{
run
=
*
buf
++
+
1
;
run
=
*
buf
++
+
1
;
if
(
run
!=
1
)
if
(
run
!=
1
)
...
@@ -163,6 +173,8 @@ static int sunrast_decode_frame(AVCodecContext *avctx, void *data,
...
@@ -163,6 +173,8 @@ static int sunrast_decode_frame(AVCodecContext *avctx, void *data,
}
}
}
else
{
}
else
{
for
(
y
=
0
;
y
<
h
;
y
++
)
{
for
(
y
=
0
;
y
<
h
;
y
++
)
{
if
(
buf_end
-
buf
<
len
)
break
;
memcpy
(
ptr
,
buf
,
len
);
memcpy
(
ptr
,
buf
,
len
);
ptr
+=
stride
;
ptr
+=
stride
;
buf
+=
alen
;
buf
+=
alen
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment