Skip to content

F
ffmpeg
Commit 97bf7c03 authored by Diego Biurrun's avatar Diego Biurrun
Browse files
Options

doc: git-howto: Leave reviewers time to react before pushing patches

parent a903f8f0
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 0 deletions
doc/git-howto.texi
View file @ 97bf7c03
...@@ -419,6 +419,13 @@ Also note that every single commit should pass the test suite, not just ...@@ -419,6 +419,13 @@ Also note that every single commit should pass the test suite, not just
the result of a series of patches. So if you have a series of commits the result of a series of patches. So if you have a series of commits
to push, run the test suite on every single commit. to push, run the test suite on every single commit.
Give other developers a reasonable amount of time to look at and review
patches before you push them. Not everybody is online 24/7, but may wish
to look at and comment on a patch nonetheless. The time you leave depends
on the urgency and complexity of the patch. Use your common sense to pick
a timeframe that allows everybody that you think may wish to comment
and/or should comment on the change an opportunity to see it.
Finally, after pushing, mark all patches as committed on Finally, after pushing, mark all patches as committed on
@url{http://patches.libav.org/,patchwork}. @url{http://patches.libav.org/,patchwork}.
Sometimes this is not automatically done when a patch has been Sometimes this is not automatically done when a patch has been
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment