avcodec/imgconvert: fix possible null pointer dereference

regression since 354b26a3

avcodec/imgconvert: fix possible null pointer dereference
regression since 354b26a3
8c2c9740 · Simon Thelen · Paul B Mahol · 4b736bc9 · 8c2c9740
Commit 8c2c9740 authored Apr 03, 2018 by Simon Thelen Committed by Paul B Mahol Apr 03, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

imgconvert.c libavcodec/imgconvert.c +3 -2

No files found.
--- a/libavcodec/imgconvert.c
+++ b/libavcodec/imgconvert.c
@@ -72,11 +72,12 @@ enum AVPixelFormat avcodec_find_best_pix_fmt_of_list(const enum AVPixelFormat *p
    int loss;

    for (i=0; pix_fmt_list[i] != AV_PIX_FMT_NONE; i++) {
-        loss = *loss_ptr;
+        loss = loss_ptr ? *loss_ptr : 0;
        best = avcodec_find_best_pix_fmt_of_2(best, pix_fmt_list[i], src_pix_fmt, has_alpha, &loss);
    }

-    *loss_ptr = loss;
+    if (loss_ptr)
+        *loss_ptr = loss;
    return best;
 }