Commit da5a1f4b authored by Kenton Varda's avatar Kenton Varda

Merge pull request #95 from kaos/patch-2

Close #94: obsolete comment in rpc.capnp
parents 222a77f9 1494d9ec
...@@ -420,21 +420,19 @@ struct Finish { ...@@ -420,21 +420,19 @@ struct Finish {
# Message type sent from the caller to the callee to indicate: # Message type sent from the caller to the callee to indicate:
# 1) The questionId will no longer be used in any messages sent by the callee (no further # 1) The questionId will no longer be used in any messages sent by the callee (no further
# pipelined requests). # pipelined requests).
# 2) Any capabilities in the results other than the ones listed below should be implicitly # 2) If the call has not returned yet, the caller no longer cares about the result. If nothing
# released. # else cares about the result either (e.g. there are no other outstanding calls pipelined on
# 3) If the call has not returned yet, the caller no longer cares about the result. If nothing
# else cares about the result either (e.g. there are to other outstanding calls pipelined on
# the result of this one) then the callee may wish to immediately cancel the operation and # the result of this one) then the callee may wish to immediately cancel the operation and
# send back a Return message with "canceled" set. However, implementations are not required # send back a Return message with "canceled" set. However, implementations are not required
# to support premature cancellation -- instead, the implementation may wait until the call # to support premature cancellation -- instead, the implementation may wait until the call
# actually completes and send a normal `Return` message. # actually completes and send a normal `Return` message.
# #
# TODO(someday): Should we separate (1) and (2)? It would be possible and useful to notify the # TODO(someday): Should we separate (1) and implicitly releasing result capabilities? It would be
# server that it doesn't need to keep around the response to service pipeline requests even # possible and useful to notify the server that it doesn't need to keep around the response to
# though the caller still wants to receive it / hasn't yet finished processing it. It could # service pipeline requests even though the caller still wants to receive it / hasn't yet
# also be useful to notify the server that it need not marshal the results because the caller # finished processing it. It could also be useful to notify the server that it need not marshal
# doesn't want them anyway, even if the caller is still sending pipelined calls, although this # the results because the caller doesn't want them anyway, even if the caller is still sending
# seems less useful (just saving some bytes on the wire). # pipelined calls, although this seems less useful (just saving some bytes on the wire).
questionId @0 :QuestionId; questionId @0 :QuestionId;
# ID of the call whose result is to be released. # ID of the call whose result is to be released.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment