Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
C
capnproto
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
capnproto
Commits
ab5e35e4
Commit
ab5e35e4
authored
Apr 29, 2017
by
Kenton Varda
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Punt some TODOs to next release."
This reverts commit
f836a5fc
.
parent
22e9f2a5
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
11 additions
and
11 deletions
+11
-11
json.c++
c++/src/capnp/compat/json.c++
+5
-5
http.c++
c++/src/kj/compat/http.c++
+2
-2
http.h
c++/src/kj/compat/http.h
+1
-1
debug.c++
c++/src/kj/debug.c++
+3
-3
No files found.
c++/src/capnp/compat/json.c++
View file @
ab5e35e4
...
...
@@ -223,8 +223,8 @@ kj::String JsonCodec::encodeRaw(JsonValue::Reader value) const {
}
void
JsonCodec
::
encode
(
DynamicValue
::
Reader
input
,
Type
type
,
JsonValue
::
Builder
output
)
const
{
// TODO(
0.7
): For interfaces, check for handlers on superclasses, per documentation...
// TODO(
0.7
): For branded types, should we check for handlers on the generic?
// TODO(
soon
): For interfaces, check for handlers on superclasses, per documentation...
// TODO(
soon
): For branded types, should we check for handlers on the generic?
// TODO(someday): Allow registering handlers for "all structs", "all lists", etc?
auto
iter
=
impl
->
typeHandlers
.
find
(
type
);
if
(
iter
!=
impl
->
typeHandlers
.
end
())
{
...
...
@@ -552,7 +552,7 @@ void JsonCodec::decodeObject(List<JsonValue::Field>::Reader input, DynamicStruct
}
void
JsonCodec
::
decode
(
JsonValue
::
Reader
input
,
DynamicStruct
::
Builder
output
)
const
{
// TODO(
0.7
): type and field handlers
// TODO(
soon
): type and field handlers
switch
(
input
.
which
())
{
case
JsonValue
:
:
OBJECT
:
decodeObject
(
input
.
getObject
(),
output
);
...
...
@@ -564,7 +564,7 @@ void JsonCodec::decode(JsonValue::Reader input, DynamicStruct::Builder output) c
Orphan
<
DynamicValue
>
JsonCodec
::
decode
(
JsonValue
::
Reader
input
,
Type
type
,
Orphanage
orphanage
)
const
{
// TODO(
0.7
)
// TODO(
soon
)
KJ_FAIL_ASSERT
(
"JSON decode into orphanage not implement yet. :("
);
}
...
...
@@ -885,7 +885,7 @@ private:
}
}
// TODO(
0.7
): Support at least basic multi-lingual plane, ie ignore surrogates.
// TODO(
soon
): Support at least basic multi-lingual plane, ie ignore surrogates.
KJ_REQUIRE
(
codePoint
<
128
,
"non-ASCII unicode escapes are not supported (yet!)"
);
target
.
add
(
0x7f
&
static_cast
<
char
>
(
codePoint
));
}
...
...
c++/src/kj/compat/http.c++
View file @
ab5e35e4
...
...
@@ -1225,7 +1225,7 @@ kj::Own<kj::AsyncInputStream> HttpInputStream::getEntityBody(
if
(
connectionHeaders
.
transferEncoding
!=
nullptr
)
{
// TODO(someday): Support plugable transfer encodings? Or at least gzip?
// TODO(
0.7
): Support stacked transfer encodings, e.g. "gzip, chunked".
// TODO(
soon
): Support stacked transfer encodings, e.g. "gzip, chunked".
if
(
fastCaseCmp
<
'c'
,
'h'
,
'u'
,
'n'
,
'k'
,
'e'
,
'd'
>
(
connectionHeaders
.
transferEncoding
.
cStr
()))
{
return
kj
::
heap
<
HttpChunkedEntityReader
>
(
*
this
);
}
else
{
...
...
@@ -1244,7 +1244,7 @@ kj::Own<kj::AsyncInputStream> HttpInputStream::getEntityBody(
}
if
(
connectionHeaders
.
connection
!=
nullptr
)
{
// TODO(
0.7
): Connection header can actually have multiple tokens... but no one ever uses
// TODO(
soon
): Connection header can actually have multiple tokens... but no one ever uses
// that feature?
if
(
fastCaseCmp
<
'c'
,
'l'
,
'o'
,
's'
,
'e'
>
(
connectionHeaders
.
connection
.
cStr
()))
{
return
kj
::
heap
<
HttpConnectionCloseEntityReader
>
(
*
this
);
...
...
c++/src/kj/compat/http.h
View file @
ab5e35e4
...
...
@@ -144,7 +144,7 @@ public:
//
// HttpHeaderId::HOST
//
// TODO(
0.7
): Fill this out with more common headers.
// TODO(
soon
): Fill this out with more common headers.
#define DECLARE_HEADER(id, name) \
static const HttpHeaderId id;
...
...
c++/src/kj/debug.c++
View file @
ab5e35e4
...
...
@@ -136,7 +136,7 @@ Exception::Type typeOfErrno(int error) {
Exception
::
Type
typeOfWin32Error
(
DWORD
error
)
{
switch
(
error
)
{
// TODO(
0.7
): This needs more work.
// TODO(
soon
): This needs more work.
case
WSAETIMEDOUT
:
return
Exception
::
Type
::
OVERLOADED
;
...
...
@@ -357,8 +357,8 @@ void Debug::Fault::init(
const
char
*
file
,
int
line
,
Win32Error
osErrorNumber
,
const
char
*
condition
,
const
char
*
macroArgs
,
ArrayPtr
<
String
>
argValues
)
{
LPVOID
ptr
;
// TODO(
0.7
): Use FormatMessageW() instead.
// TODO(
0.7
): Why doesn't this work for winsock errors?
// TODO(
soon
): Use FormatMessageW() instead.
// TODO(
soon
): Why doesn't this work for winsock errors?
DWORD
result
=
FormatMessageA
(
FORMAT_MESSAGE_ALLOCATE_BUFFER
|
FORMAT_MESSAGE_FROM_SYSTEM
|
FORMAT_MESSAGE_IGNORE_INSERTS
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment