Commit 77da9266 authored by Kenton Varda's avatar Kenton Varda

Fix streaming: getsockopt(SO_SNDBUF) can throw EINVAL sometimes.

parent 755f675b
......@@ -222,7 +222,12 @@ size_t TwoPartyVatNetwork::getWindow() {
KJ_ASSERT(len == sizeof(bufSize));
})) {
if (exception->getType() != kj::Exception::Type::UNIMPLEMENTED) {
kj::throwRecoverableException(kj::mv(*exception));
// TODO(someday): Figure out why getting SO_SNDBUF sometimes throws EINVAL. I suspect it
// happens when the remote side has closed their read end, meaning we no longer have
// a send buffer, but I don't know what is the best way to verify that that was actually
// the reason. I'd prefer not to ignore EINVAL errors in general.
// kj::throwRecoverableException(kj::mv(*exception));
}
solSndbufUnimplemented = true;
bufSize = RpcFlowController::DEFAULT_WINDOW_SIZE;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment