Commit 25be62be authored by Kenton Varda's avatar Kenton Varda

sed -r is a GNU extension, apparently, and due to stars aligning, this didn't…

sed -r is a GNU extension, apparently, and due to stars aligning, this didn't break the build, but led to a totally bogus soname on non-GNU systems. Argh.

Apparently most systems (including GNU, undocumentedly) support -E instead, but perhaps the safest thing is to use a basic regular expression. Unfortunately on many systems ? and + are not available in basic regexes, but using * instead happens to work in our case.

Thanks to @neverpanic for catching this.

Fixes #210
parent 6315eaed
...@@ -189,7 +189,7 @@ endif ...@@ -189,7 +189,7 @@ endif
# Don't include security release in soname -- we want to replace old binaries # Don't include security release in soname -- we want to replace old binaries
# in this case. # in this case.
SO_VERSION = $(shell echo $(VERSION) | sed -re 's/^([0-9]+[.][0-9]+[.][0-9]+)([.][0-9]+)?(-.*)?$$/\1\3/g') SO_VERSION = $(shell echo $(VERSION) | sed -e 's/^\([0-9]*[.][0-9]*[.][0-9]*\)\([.][0-9]*\)*\(-.*\)*$$/\1\3/g')
libkj_la_LIBADD = $(PTHREAD_LIBS) libkj_la_LIBADD = $(PTHREAD_LIBS)
libkj_la_LDFLAGS = -release $(SO_VERSION) -no-undefined libkj_la_LDFLAGS = -release $(SO_VERSION) -no-undefined
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment