Commit 1a0fd094 authored by Kenton Varda's avatar Kenton Varda

Address @harrishancock's review comments.

parent b8b51f58
...@@ -157,6 +157,9 @@ void UnixEventPort::ChildSet::checkExits() { ...@@ -157,6 +157,9 @@ void UnixEventPort::ChildSet::checkExits() {
} }
Promise<int> UnixEventPort::onChildExit(Maybe<pid_t>& pid) { Promise<int> UnixEventPort::onChildExit(Maybe<pid_t>& pid) {
KJ_REQUIRE(capturedChildExit,
"must call UnixEventPort::captureChildExit() to use onChildExit().");
ChildSet* cs; ChildSet* cs;
KJ_IF_MAYBE(c, childSet) { KJ_IF_MAYBE(c, childSet) {
cs = *c; cs = *c;
......
...@@ -127,7 +127,7 @@ public: ...@@ -127,7 +127,7 @@ public:
// which child, and therefore it may inadvertently reap children created by other threads. // which child, and therefore it may inadvertently reap children created by other threads.
static void captureChildExit(); static void captureChildExit();
// Arranges for child process exit to be captured and handled via UnixEventPort, so than you may // Arranges for child process exit to be captured and handled via UnixEventPort, so that you may
// call `onChildExit()`. Much like `captureSignal()`, this static method must be called early on // call `onChildExit()`. Much like `captureSignal()`, this static method must be called early on
// in program startup. // in program startup.
// //
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment