redis_server_protocol: move some code

src/brpc/redis_command.cpp

@@ -28,6 +28,40 @@ namespace brpc {
 
 const size_t CTX_WIDTH = 5;
 
+// Much faster than snprintf(..., "%lu", d);
+inline size_t AppendDecimal(char* outbuf, unsigned long d) {
+    char buf[24];  // enough for decimal 64-bit integers
+    size_t n = sizeof(buf);
+    do {
+        const unsigned long q = d / 10;
+        buf[--n] = d - q * 10 + '0';
+        d = q;
+    } while (d);
+    fast_memcpy(outbuf, buf + n, sizeof(buf) - n);
+    return sizeof(buf) - n;
+}
+
+// This function is the hotspot of RedisCommandFormatV() when format is
+// short or does not have many %. In a 100K-time call to formating of
+// "GET key1", the time spent on RedisRequest.AddCommand() are ~700ns
+// vs. ~400ns while using snprintf() vs. AppendDecimal() respectively.
+inline void AppendHeader(std::string& buf, char fc, unsigned long value) {
+    char header[32];
+    header[0] = fc;
+    size_t len = AppendDecimal(header + 1, value);
+    header[len + 1] = '\r';
+    header[len + 2] = '\n';
+    buf.append(header, len + 3);
+}
+inline void AppendHeader(butil::IOBuf& buf, char fc, unsigned long value) {
+    char header[32];
+    header[0] = fc;
+    size_t len = AppendDecimal(header + 1, value);
+    header[len + 1] = '\r';
+    header[len + 2] = '\n';
+    buf.append(header, len + 3);
+}
+
 static void FlushComponent(std::string* out, std::string* compbuf, int* ncomp) {
     AppendHeader(*out, '$', compbuf->size());
     out->append(*compbuf);

src/brpc/redis_command.h

@@ -40,41 +40,6 @@ butil::Status RedisCommandByComponents(butil::IOBuf* buf,
                                       const butil::StringPiece* components,
                                       size_t num_components);
 
-// Much faster than snprintf(..., "%lu", d);
-inline size_t AppendDecimal(char* outbuf, unsigned long d) {
-    char buf[24];  // enough for decimal 64-bit integers
-    size_t n = sizeof(buf);
-    do {
-        const unsigned long q = d / 10;
-        buf[--n] = d - q * 10 + '0';
-        d = q;
-    } while (d);
-    fast_memcpy(outbuf, buf + n, sizeof(buf) - n);
-    return sizeof(buf) - n;
-}
-
-// This function is the hotspot of RedisCommandFormatV() when format is
-// short or does not have many %. In a 100K-time call to formating of
-// "GET key1", the time spent on RedisRequest.AddCommand() are ~700ns
-// vs. ~400ns while using snprintf() vs. AppendDecimal() respectively.
-inline void AppendHeader(std::string& buf, char fc, unsigned long value) {
-    char header[32];
-    header[0] = fc;
-    size_t len = AppendDecimal(header + 1, value);
-    header[len + 1] = '\r';
-    header[len + 2] = '\n';
-    buf.append(header, len + 3);
-}
-inline void AppendHeader(butil::IOBuf& buf, char fc, unsigned long value) {
-    char header[32];
-    header[0] = fc;
-    size_t len = AppendDecimal(header + 1, value);
-    header[len + 1] = '\r';
-    header[len + 2] = '\n';
-    buf.append(header, len + 3);
-}
-
-
 } // namespace brpc