Commit dcc7e003 authored by cdjgit's avatar cdjgit

fix for ci comments

parent 8b919c4d
......@@ -104,21 +104,12 @@ public:
// Caller is responsible for Destroy() the instance after usage.
virtual LoadBalancer* New() const = 0;
// Config user passed parameters to lb after constrction which
// Config user passed parameters to lb after construction which
// make lb function more flexible.
virtual bool SetParameters(const butil::StringPiece& params) { return true; }
protected:
virtual ~LoadBalancer() { }
static bool SplitParameters(const butil::StringPiece& params,
butil::StringPairs* param_vec) {
std::string params_str(params.data(), params.size());
if (!butil::SplitStringIntoKeyValuePairs(params_str, '=', ' ', param_vec)) {
param_vec->clear();
return false;
}
return true;
}
};
DECLARE_bool(show_lb_in_vars);
......@@ -197,6 +188,16 @@ inline Extension<const LoadBalancer>* LoadBalancerExtension() {
return Extension<const LoadBalancer>::instance();
}
inline bool SplitLoadBalancerParameters(const butil::StringPiece& params,
butil::StringPairs* param_vec) {
std::string params_str(params.data(), params.size());
if (!butil::SplitStringIntoKeyValuePairs(params_str, '=', ' ', param_vec)) {
param_vec->clear();
return false;
}
return true;
}
} // namespace brpc
......
......@@ -361,7 +361,7 @@ void ConsistentHashingLoadBalancer::GetLoads(
bool ConsistentHashingLoadBalancer::SetParameters(const butil::StringPiece& params) {
butil::StringPairs param_vec;
if (!SplitParameters(params, &param_vec)) {
if (!SplitLoadBalancerParameters(params, &param_vec)) {
return false;
}
for (const std::pair<std::string, std::string>& param : param_vec) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment