revived_from_all_failed: remove unnecessary logs and comments

src/brpc/circuit_breaker.cpp

@@ -18,8 +18,6 @@
 #include <gflags/gflags.h>
 #include <butil/time.h>
 #include "brpc/circuit_breaker.h"
-#include "brpc/errno.pb.h"
-#include "butil/logging.h"
 
 namespace brpc {
 

src/brpc/cluster_recover_policy.h

@@ -75,8 +75,7 @@ private:
     int64_t _usable_cache_time_ms;
 };
 
-// Return a DefaultClusterRecoverPolicy object by params. The caller is responsible
-// for memory management of the return value.
+// Return a DefaultClusterRecoverPolicy object by params.
 bool GetRecoverPolicyByParams(const butil::StringPiece& params,
                               std::shared_ptr<ClusterRecoverPolicy>* ptr_out);
 

src/brpc/policy/randomized_load_balancer.cpp

@@ -31,10 +31,6 @@ inline uint32_t GenRandomStride() {
     return prime_offset[butil::fast_rand_less_than(ARRAY_SIZE(prime_offset))];
 }
 
-RandomizedLoadBalancer::RandomizedLoadBalancer()
-    : _cluster_recover_policy(NULL)
-{}
-
 bool RandomizedLoadBalancer::Add(Servers& bg, const ServerId& id) {
     if (bg.server_list.capacity() < 128) {
         bg.server_list.reserve(128);

src/brpc/policy/randomized_load_balancer.h

@@ -31,7 +31,6 @@ namespace policy {
 // than RoundRobinLoadBalancer.
 class RandomizedLoadBalancer : public LoadBalancer {
 public:
-    RandomizedLoadBalancer();
     bool AddServer(const ServerId& id);
     bool RemoveServer(const ServerId& id);
     size_t AddServersInBatch(const std::vector<ServerId>& servers);

test/brpc_load_balancer_unittest.cpp

@@ -790,13 +790,13 @@ TEST_F(LoadBalancerTest, health_check_no_valid_server) {
 
 TEST_F(LoadBalancerTest, revived_from_all_failed_sanity) {
     brpc::LoadBalancer* lb = NULL;
-    // TODO(zhujiashun)
-    int rand = butil::fast_rand_less_than(1);
+    int rand = butil::fast_rand_less_than(2);
     if (rand == 0) {
         brpc::policy::RandomizedLoadBalancer rlb;
         lb = rlb.New("minimum_working_instances=2 hold_time_ms=2000");
     } else if (rand == 1) {
-        lb = new brpc::policy::RoundRobinLoadBalancer;
+        brpc::policy::RoundRobinLoadBalancer rrlb;
+        lb = rrlb.New("minimum_working_instances=2 hold_time_ms=2000");
     }
     brpc::SocketUniquePtr ptr[2];
     for (size_t i = 0; i < ARRAY_SIZE(servers); ++i) {