Commit ca66d1fe authored by wxf's avatar wxf

add option to allow access methods from default url

parent 7de0d7ea
...@@ -1011,7 +1011,7 @@ FindMethodPropertyByURI(const std::string& uri_path, const Server* server, ...@@ -1011,7 +1011,7 @@ FindMethodPropertyByURI(const std::string& uri_path, const Server* server,
const Server::MethodProperty* mp = const Server::MethodProperty* mp =
FindMethodPropertyByURIImpl(uri_path, server, unresolved_path); FindMethodPropertyByURIImpl(uri_path, server, unresolved_path);
if (mp != NULL) { if (mp != NULL) {
if (mp->http_url != NULL) { if (mp->http_url != NULL && mp->restful_mapped_only) {
// the restful method is accessed from its // the restful method is accessed from its
// default url (SERVICE/METHOD) which should be rejected. // default url (SERVICE/METHOD) which should be rejected.
return NULL; return NULL;
......
...@@ -1305,6 +1305,7 @@ int Server::AddServiceInternal(google::protobuf::Service* service, ...@@ -1305,6 +1305,7 @@ int Server::AddServiceInternal(google::protobuf::Service* service,
} }
if (mp->http_url == NULL) { if (mp->http_url == NULL) {
mp->http_url = new std::string(mappings[i].path.to_string()); mp->http_url = new std::string(mappings[i].path.to_string());
mp->restful_mapped_only = svc_opt.restful_mapped_only;
} else { } else {
if (!mp->http_url->empty()) { if (!mp->http_url->empty()) {
mp->http_url->append(" @"); mp->http_url->append(" @");
...@@ -1345,6 +1346,7 @@ int Server::AddServiceInternal(google::protobuf::Service* service, ...@@ -1345,6 +1346,7 @@ int Server::AddServiceInternal(google::protobuf::Service* service,
} }
if (mp->http_url == NULL) { if (mp->http_url == NULL) {
mp->http_url = new std::string(mappings[i].path.to_string()); mp->http_url = new std::string(mappings[i].path.to_string());
mp->restful_mapped_only = svc_opt.restful_mapped_only;
} else { } else {
if (!mp->http_url->empty()) { if (!mp->http_url->empty()) {
mp->http_url->append(" @"); mp->http_url->append(" @");
...@@ -1384,6 +1386,7 @@ int Server::AddServiceInternal(google::protobuf::Service* service, ...@@ -1384,6 +1386,7 @@ int Server::AddServiceInternal(google::protobuf::Service* service,
ServiceOptions::ServiceOptions() ServiceOptions::ServiceOptions()
: ownership(SERVER_DOESNT_OWN_SERVICE) : ownership(SERVER_DOESNT_OWN_SERVICE)
, restful_mapped_only(true)
, allow_http_body_to_pb(true) , allow_http_body_to_pb(true)
#ifdef BAIDU_INTERNAL #ifdef BAIDU_INTERNAL
, pb_bytes_to_base64(false) , pb_bytes_to_base64(false)
...@@ -1401,11 +1404,13 @@ int Server::AddService(google::protobuf::Service* service, ...@@ -1401,11 +1404,13 @@ int Server::AddService(google::protobuf::Service* service,
int Server::AddService(google::protobuf::Service* service, int Server::AddService(google::protobuf::Service* service,
ServiceOwnership ownership, ServiceOwnership ownership,
const butil::StringPiece& restful_mappings) { const butil::StringPiece& restful_mappings,
bool restful_mapped_only) {
ServiceOptions options; ServiceOptions options;
options.ownership = ownership; options.ownership = ownership;
// TODO: This is weird // TODO: This is weird
options.restful_mappings = restful_mappings.as_string(); options.restful_mappings = restful_mappings.as_string();
options.restful_mapped_only = restful_mapped_only;
return AddServiceInternal(service, false, options); return AddServiceInternal(service, false, options);
} }
......
...@@ -277,6 +277,11 @@ struct ServiceOptions { ...@@ -277,6 +277,11 @@ struct ServiceOptions {
// Default: empty // Default: empty
std::string restful_mappings; std::string restful_mappings;
// Work with restful_mappings, if this flag is true, reject methods accessed
// from default urls (SERVICE/METHOD).
// Default: true
bool restful_mapped_only;
// [ Not recommended to change this option ] // [ Not recommended to change this option ]
// If this flag is true, the service will convert http body to protobuf // If this flag is true, the service will convert http body to protobuf
// when the pb schema is non-empty in http servings. The body must be // when the pb schema is non-empty in http servings. The body must be
...@@ -334,6 +339,7 @@ public: ...@@ -334,6 +339,7 @@ public:
struct MethodProperty { struct MethodProperty {
bool is_builtin_service; bool is_builtin_service;
bool own_method_status; bool own_method_status;
bool restful_mapped_only;
// Parameters which have nothing to do with management of services, but // Parameters which have nothing to do with management of services, but
// will be used when the service is queried. // will be used when the service is queried.
struct OpaqueParams { struct OpaqueParams {
...@@ -414,7 +420,8 @@ public: ...@@ -414,7 +420,8 @@ public:
ServiceOwnership ownership); ServiceOwnership ownership);
int AddService(google::protobuf::Service* service, int AddService(google::protobuf::Service* service,
ServiceOwnership ownership, ServiceOwnership ownership,
const butil::StringPiece& restful_mappings); const butil::StringPiece& restful_mappings,
bool restful_mapped_only = true);
int AddService(google::protobuf::Service* service, int AddService(google::protobuf::Service* service,
const ServiceOptions& options); const ServiceOptions& options);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment