Commit bd502a72 authored by gejun's avatar gejun

Move contribution related info into contributing.md

parent 37ff0970
If you meet any problem or request a new feature, you're welcome to [create an issue](https://github.com/brpc/brpc/issues/new).
If you can solve any of [the issues](https://github.com/brpc/brpc/issues), you're welcome to send the PR to us.
Before the PR:
* Make sure your code style conforms to [google C++ coding style](https://google.github.io/styleguide/cppguide.html). Indentation is preferred to be 4 spaces.
* The code appears where it should be. For example the code to support an extra protocol should not be put in general classes like server.cpp, channel.cpp, while a general modification would better not be hidden inside a very specific protocol.
* Has unittests.
After the PR:
* Make sure the [travis-ci](https://travis-ci.org/brpc/brpc/pull_requests) passed.
# Chinese version
如果你遇到了问题或要求新的功能,欢迎[创建issue](https://github.com/brpc/brpc/issues/new).
如果你可以解决某个[issue](https://github.com/brpc/brpc/issues), 欢迎发送PR.
发送PR前请确认:
* 你的代码符合[google C++代码规范](https://google.github.io/styleguide/cppguide.html)。缩进最好为4个空格。
* 代码出现的位置和其定位相符。比如对于某特定协议的扩展代码不该出现在server.cpp, channel.cpp这些较为通用的类中,而一些非常通用的改动也不该深藏在某个特定协议的cpp中。
* 有对应的单测代码。
提交PR后请确认:
* [travis-ci](https://travis-ci.org/brpc/brpc/pull_requests)成功通过。
......@@ -99,18 +99,7 @@ You can use it to:
* [云平台代理服务](docs/cn/case_ubrpc.md)
# Contribute code
**If you can fix any of the issues or add new features, you're welcome to send the PR to us. If the PR is accepted, your contribution will be scored from 0 to 5 points according to the difficulty and quality (higher is better). If you accumulate 10 points, you can contact us for interviewing opportunities or recommendation letter for your future jobs.**
Make sure your code meets following requirements before submitting the PR:
- The code conforms to [google C++ coding style](https://google.github.io/styleguide/cppguide.html) and is indented by 4 spaces.
- The code appears where it should be. For example the code to support an extra protocol should not be put in general classes like server.cpp, channel.cpp, while a general modification would better not be hidden inside a very specific protocol.
- Has unittests.
Check following items after submitting the PR:
- Compilations and unittests in [travis-ci](https://travis-ci.org/brpc/brpc/pull_requests) are passed.
Please refer to [here](CONTRIBUTING.md).
# Feedback
Please report bugs, concerns, suggestions by issues, or join QQ-group 498837325 to discuss problems around source code.
......@@ -101,17 +101,7 @@
# 贡献代码
**如果你可以修复某个issue或增加一个新功能, 欢迎给我们发送PR. 如果对应的PR被接受了, 你的贡献将会根据难度和质量在0-5区间内打分(越高越好). 如果你累计获得了10分, 可以联系我们获得面试机会或为你写推荐信。**
提交PR前请确认你的代码符合如下要求:
* 符合[google C++代码规范](https://google.github.io/styleguide/cppguide.html), 且一次缩进为4个空格。
* 代码出现的位置和其定位相符。比如对于某特定协议的扩展代码不该出现在server.cpp, channel.cpp这些较为通用的类中,而一些非常通用的改动也不该深藏在某个特定协议的cpp中。
* 有对应的单测代码。
提交PR后请检查如下内容:
* [travis-ci](https://travis-ci.org/brpc/brpc/pull_requests)中的编译和单测均已成功。
请参考[这里](CONTRIBUTING.md#chinese-version)
# 反馈问题
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment