Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
B
brpc
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
brpc
Commits
9145cb8a
Commit
9145cb8a
authored
Sep 18, 2018
by
TousakaRin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
1. Remove cacheline alignment 2.make the logic clearer
parent
1ff59abf
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
7 deletions
+9
-7
circuit_breaker.cpp
src/brpc/circuit_breaker.cpp
+8
-6
circuit_breaker.h
src/brpc/circuit_breaker.h
+1
-1
No files found.
src/brpc/circuit_breaker.cpp
View file @
9145cb8a
...
...
@@ -152,10 +152,15 @@ CircuitBreaker::CircuitBreaker()
}
bool
CircuitBreaker
::
OnCallEnd
(
int
error_code
,
int64_t
latency
)
{
if
(
_broken
.
load
(
butil
::
memory_order_relaxed
)
||
!
_long_window
.
OnCallEnd
(
error_code
,
latency
)
||
bool
broken
=
_broken
.
load
(
butil
::
memory_order_relaxed
);
if
(
broken
)
{
return
false
;
}
if
(
!
_long_window
.
OnCallEnd
(
error_code
,
latency
)
||
!
_short_window
.
OnCallEnd
(
error_code
,
latency
))
{
UpdateIsolationDuration
();
if
(
!
_broken
.
exchange
(
true
,
butil
::
memory_order_acquire
))
{
UpdateIsolationDuration
();
}
return
false
;
}
return
true
;
...
...
@@ -169,8 +174,6 @@ void CircuitBreaker::Reset() {
}
void
CircuitBreaker
::
UpdateIsolationDuration
()
{
if
(
!
_broken
.
load
(
butil
::
memory_order_relaxed
)
&&
!
_broken
.
exchange
(
true
,
butil
::
memory_order_acquire
))
{
int64_t
now_time_ms
=
butil
::
cpuwide_time_ms
();
int
isolation_duration_ms
=
_isolation_duration_ms
.
load
(
butil
::
memory_order_relaxed
);
const
int
max_isolation_duration_ms
=
...
...
@@ -184,7 +187,6 @@ void CircuitBreaker::UpdateIsolationDuration() {
isolation_duration_ms
=
min_isolation_duration_ms
;
}
_isolation_duration_ms
.
store
(
isolation_duration_ms
,
butil
::
memory_order_relaxed
);
}
}
}
// namespace brpc
src/brpc/circuit_breaker.h
View file @
9145cb8a
...
...
@@ -64,7 +64,7 @@ private:
const
int
_max_error_percent
;
const
double
_smooth
;
butil
::
atomic
<
int64_t
>
BAIDU_CACHELINE_ALIGNMENT
_sample_count
;
butil
::
atomic
<
int64_t
>
_sample_count
;
butil
::
atomic
<
int64_t
>
_ema_error_cost
;
butil
::
atomic
<
int64_t
>
_ema_latency
;
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment