Merge pull request #1012 from eric-buaa-cn/fix_pid_overwrite

bugfix: pid file may be overwritten

Merge pull request #1012 from eric-buaa-cn/fix_pid_overwrite
bugfix: pid file may be overwritten
907eebe9 · Ge Jun · GitHub · 88bf6106 · 4d5d8e26 · 907eebe9
Unverified Commit 907eebe9 authored Jan 03, 2020 by Ge Jun Committed by GitHub Jan 03, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

server.cpp src/brpc/server.cpp +1 -1

No files found.
--- a/src/brpc/server.cpp
+++ b/src/brpc/server.cpp
@@ -1669,7 +1669,7 @@ void Server::PutPidFileIfNeeded() {
            return;
        }
    }
-    int fd = open(_options.pid_file.c_str(), O_WRONLY | O_CREAT, 0666);
+    int fd = open(_options.pid_file.c_str(), O_WRONLY | O_CREAT | O_TRUNC, 0666);
    if (fd < 0) {
        LOG(WARNING) << "Fail to open " << _options.pid_file;
        _options.pid_file.clear();