Unverified Commit 8e7db45f authored by Ge Jun's avatar Ge Jun Committed by GitHub

Merge pull request #549 from zyearn/fix_warnings

add virtual dtor to interface class
parents 0f4a864b be197872
......@@ -76,6 +76,7 @@ private:
// Note: don't forget the jquery.
class Tabbed {
public:
virtual ~Tabbed() = default;
virtual void GetTabInfo(TabInfoList* info_list) const = 0;
};
......
......@@ -37,6 +37,7 @@ typedef butil::ScopedGeneric<StreamId, detail::StreamIdTraits> ScopedStream;
class StreamInputHandler {
public:
virtual ~StreamInputHandler() = default;
virtual int on_received_messages(StreamId id,
butil::IOBuf *const messages[],
size_t size) = 0;
......
......@@ -28,6 +28,8 @@ class StreamUserData;
// generally this object is created before RPC and destroyed after RPC.
class StreamCreator {
public:
virtual ~StreamCreator() = default;
// Called when the socket for sending request is about to be created.
// If the RPC has retries, this function MAY be called before each retry.
// This function would not be called if some preconditions are not
......@@ -56,6 +58,8 @@ public:
// of a specific stream request.
class StreamUserData {
public:
virtual ~StreamUserData() = default;
// Called when the streamUserData is about to destroyed.
// This function MUST be called to clean up resources if OnCreatingStream
// of StreamCreator has returned a valid StreamUserData pointer.
......
......@@ -424,6 +424,7 @@ public:
};
virtual void print(const Site& site) = 0;
virtual ~VLogSitePrinter() = default;
};
void print_vlog_sites(VLogSitePrinter*);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment