use string in unordered_map

src/brpc/redis.cpp

@@ -436,22 +436,20 @@ std::ostream& operator<<(std::ostream& os, const RedisResponse& response) {
     return os;
 }
 
-bool RedisService::AddCommandHandler(const std::string& name, RedisCommandHandler* handler) {
-    butil::StringPiece name_piece(name);
-    auto it = _command_map.find(name_piece);
+bool RedisService::AddCommandHandler(const butil::StringPiece& name, 
+                                     RedisCommandHandler* handler) {
+    std::string lcname = StringToLowerASCII(name.as_string());
+    auto it = _command_map.find(lcname);
     if (it != _command_map.end()) {
         LOG(ERROR) << "redis command name=" << name << " exist";
         return false;
     }
-    
-    _all_commands.push_back(name);
-    name_piece = _all_commands.back();
-    _command_map[name_piece] = handler;
+    _command_map[lcname] = handler;
     return true;
 }
  
 RedisCommandHandler* RedisService::FindCommandHandler(const butil::StringPiece& name) const {
-    auto it = _command_map.find(name);
+    auto it = _command_map.find(name.as_string());
     if (it != _command_map.end()) {
         return it->second;
     }

src/brpc/redis.h

@@ -222,16 +222,14 @@ public:
     virtual ~RedisService() {}
     
     // Call this function to register `handler` that can handle command `name`.
-    bool AddCommandHandler(const std::string& name, RedisCommandHandler* handler);
+    bool AddCommandHandler(const butil::StringPiece& name, RedisCommandHandler* handler);
 
     // This function should not be touched by user and used by brpc deverloper only.
     RedisCommandHandler* FindCommandHandler(const butil::StringPiece& name) const;
 
 private:
-    typedef BUTIL_HASH_NAMESPACE::hash<butil::StringPiece> StringPieceHasher;
-    typedef std::unordered_map<butil::StringPiece, RedisCommandHandler*, StringPieceHasher> CommandMap;
+    typedef std::unordered_map<std::string, RedisCommandHandler*> CommandMap;
     CommandMap _command_map;
-    std::list<std::string> _all_commands;
 };
 
 enum RedisCommandHandlerResult {