Commit 74d156c8 authored by jamesge's avatar jamesge

fix some warnings

parent e3782eb8
...@@ -1660,7 +1660,7 @@ TEST_F(IOBufTest, append_user_data_and_share) { ...@@ -1660,7 +1660,7 @@ TEST_F(IOBufTest, append_user_data_and_share) {
TEST_F(IOBufTest, share_tls_block) { TEST_F(IOBufTest, share_tls_block) {
butil::iobuf::remove_tls_block_chain(); butil::iobuf::remove_tls_block_chain();
butil::IOBuf::Block* b = butil::iobuf::acquire_tls_block(); butil::IOBuf::Block* b = butil::iobuf::acquire_tls_block();
ASSERT_EQ(0, butil::iobuf::block_size(b)); ASSERT_EQ(0u, butil::iobuf::block_size(b));
butil::IOBuf::Block* b2 = butil::iobuf::share_tls_block(); butil::IOBuf::Block* b2 = butil::iobuf::share_tls_block();
butil::IOBuf buf; butil::IOBuf buf;
...@@ -1677,7 +1677,7 @@ TEST_F(IOBufTest, share_tls_block) { ...@@ -1677,7 +1677,7 @@ TEST_F(IOBufTest, share_tls_block) {
} }
// now tls block is b(full) -> b2(full) -> NULL // now tls block is b(full) -> b2(full) -> NULL
butil::IOBuf::Block* head_block = butil::iobuf::share_tls_block(); butil::IOBuf::Block* head_block = butil::iobuf::share_tls_block();
ASSERT_EQ(0, butil::iobuf::block_size(head_block)); ASSERT_EQ(0u, butil::iobuf::block_size(head_block));
ASSERT_NE(b, head_block); ASSERT_NE(b, head_block);
ASSERT_NE(b2, head_block); ASSERT_NE(b2, head_block);
} }
......
...@@ -138,8 +138,8 @@ TEST(RandUtilTest, RandGeneratorIsUniform) { ...@@ -138,8 +138,8 @@ TEST(RandUtilTest, RandGeneratorIsUniform) {
// Don't quit too quickly for things to start converging, or we may have // Don't quit too quickly for things to start converging, or we may have
// a false positive. // a false positive.
if (count > kMinAttempts && if (count > kMinAttempts &&
kExpectedAverage - kAllowedVariance < cumulative_average && double(kExpectedAverage - kAllowedVariance) < cumulative_average &&
cumulative_average < kExpectedAverage + kAllowedVariance) { cumulative_average < double(kExpectedAverage + kAllowedVariance)) {
break; break;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment