Commit 67b3f54e authored by TousakaRin's avatar TousakaRin

Remove the log in the critical section and change the type of ema_qps to double

parent 419816df
...@@ -156,19 +156,18 @@ int32_t GradientConcurrencyLimiter::AddSample(int error_code, ...@@ -156,19 +156,18 @@ int32_t GradientConcurrencyLimiter::AddSample(int error_code,
} }
if (sampling_time_us - _sw.start_time_us < if (sampling_time_us - _sw.start_time_us <
FLAGS_gradient_cl_sample_window_size_ms * 1000) { FLAGS_gradient_cl_sample_window_size_ms * 1000 ||
_sw.succ_count + _sw.failed_count <
FLAGS_gradient_cl_min_sample_count) {
return 0; return 0;
} }
if (_sw.succ_count + _sw.failed_count <
FLAGS_gradient_cl_min_sample_count) { if(_sw.succ_count > 0) {
LOG_EVERY_N(INFO, 100) << "Insufficient sample count";
return 0;
} else if (_sw.succ_count > 0) {
int max_concurrency = UpdateMaxConcurrency(sampling_time_us); int max_concurrency = UpdateMaxConcurrency(sampling_time_us);
ResetSampleWindow(sampling_time_us); ResetSampleWindow(sampling_time_us);
return max_concurrency; return max_concurrency;
} else { } else {
LOG(ERROR) << "All request failed, resize max_concurrency"; // All request failed
int32_t current_concurrency = int32_t current_concurrency =
_current_concurrency.load(butil::memory_order_relaxed); _current_concurrency.load(butil::memory_order_relaxed);
_current_concurrency.store( _current_concurrency.store(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment