Commit 6268d2fd authored by gejun's avatar gejun

Merge branch 'master' of https://github.com/brpc/brpc

parents b2cb9a4f 10733a60
...@@ -280,10 +280,10 @@ void Acceptor::OnNewConnectionsUntilEAGAIN(Socket* acception) { ...@@ -280,10 +280,10 @@ void Acceptor::OnNewConnectionsUntilEAGAIN(Socket* acception) {
// There's a funny race condition here. After Socket::Create, messages // There's a funny race condition here. After Socket::Create, messages
// from the socket are already handled and a RPC is possibly done // from the socket are already handled and a RPC is possibly done
// before the socket is added into _socket_map below. This is actually // before the socket is added into _socket_map below. This is found in
// found in ChannelTest.skip_parallel in test/brpc_channel_unittest.cpp. // ChannelTest.skip_parallel in test/brpc_channel_unittest.cpp (running
// When the race happens, the _messenger.ConnectionCount() may be 0 // on machines with few cores) where the _messenger.ConnectionCount()
// even if the RPC is already done. // may surprisingly be 0 even if the RPC is already done.
SocketUniquePtr sock; SocketUniquePtr sock;
if (Socket::AddressFailedAsWell(socket_id, &sock) >= 0) { if (Socket::AddressFailedAsWell(socket_id, &sock) >= 0) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment