Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
B
brpc
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
brpc
Commits
6268d2fd
Commit
6268d2fd
authored
Oct 31, 2017
by
gejun
Browse files
Options
Browse Files
Download
Plain Diff
Merge branch 'master' of
https://github.com/brpc/brpc
parents
b2cb9a4f
10733a60
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
acceptor.cpp
src/brpc/acceptor.cpp
+4
-4
No files found.
src/brpc/acceptor.cpp
View file @
6268d2fd
...
...
@@ -280,10 +280,10 @@ void Acceptor::OnNewConnectionsUntilEAGAIN(Socket* acception) {
// There's a funny race condition here. After Socket::Create, messages
// from the socket are already handled and a RPC is possibly done
// before the socket is added into _socket_map below. This is
actually
//
found in ChannelTest.skip_parallel in test/brpc_channel_unittest.cpp.
//
When the race happens, the _messenger.ConnectionCount() may be 0
// even if the RPC is already done.
// before the socket is added into _socket_map below. This is
found in
//
ChannelTest.skip_parallel in test/brpc_channel_unittest.cpp (running
//
on machines with few cores) where the _messenger.ConnectionCount()
//
may surprisingly be 0
even if the RPC is already done.
SocketUniquePtr
sock
;
if
(
Socket
::
AddressFailedAsWell
(
socket_id
,
&
sock
)
>=
0
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment