Commit 400d8c61 authored by zhujiashun's avatar zhujiashun

health_check_using_rpc: remove unnecessary friend class

parent 387d034b
...@@ -146,7 +146,6 @@ private: ...@@ -146,7 +146,6 @@ private:
class Channel : public ChannelBase { class Channel : public ChannelBase {
friend class Controller; friend class Controller;
friend class SelectiveChannel; friend class SelectiveChannel;
friend class HealthCheckTask;
public: public:
Channel(ProfilerLinker = ProfilerLinker()); Channel(ProfilerLinker = ProfilerLinker());
~Channel(); ~Channel();
......
...@@ -1084,7 +1084,7 @@ bool HealthCheckTask::OnTriggeringTask(timespec* next_abstime) { ...@@ -1084,7 +1084,7 @@ bool HealthCheckTask::OnTriggeringTask(timespec* next_abstime) {
<< cntl.ErrorText(); << cntl.ErrorText();
// the hc rpc above may fail too, we should handle this case // the hc rpc above may fail too, we should handle this case
// carefully. If this rpc fails, hc must be triggered again. // carefully. If this rpc fails, hc must be triggered again.
// One Solution is to trigger the second hc in Socket::SetFailed // One solution is to trigger the second hc in Socket::SetFailed
// in rpc code path, but rpc fails doesn't mean socket fails, // in rpc code path, but rpc fails doesn't mean socket fails,
// so we should call Socket::SetFailed[1] explicitly here. // so we should call Socket::SetFailed[1] explicitly here.
// But there is a race here: // But there is a race here:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment