Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in / Register
Toggle navigation
B
brpc
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Packages
Packages
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
submodule
brpc
Commits
400d8c61
Commit
400d8c61
authored
Mar 22, 2019
by
zhujiashun
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
health_check_using_rpc: remove unnecessary friend class
parent
387d034b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
2 deletions
+1
-2
channel.h
src/brpc/channel.h
+0
-1
socket.cpp
src/brpc/socket.cpp
+1
-1
No files found.
src/brpc/channel.h
View file @
400d8c61
...
...
@@ -146,7 +146,6 @@ private:
class
Channel
:
public
ChannelBase
{
friend
class
Controller
;
friend
class
SelectiveChannel
;
friend
class
HealthCheckTask
;
public
:
Channel
(
ProfilerLinker
=
ProfilerLinker
());
~
Channel
();
...
...
src/brpc/socket.cpp
View file @
400d8c61
...
...
@@ -1084,7 +1084,7 @@ bool HealthCheckTask::OnTriggeringTask(timespec* next_abstime) {
<<
cntl
.
ErrorText
();
// the hc rpc above may fail too, we should handle this case
// carefully. If this rpc fails, hc must be triggered again.
// One
S
olution is to trigger the second hc in Socket::SetFailed
// One
s
olution is to trigger the second hc in Socket::SetFailed
// in rpc code path, but rpc fails doesn't mean socket fails,
// so we should call Socket::SetFailed[1] explicitly here.
// But there is a race here:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment